Fix autofill styles by marcaaron · Pull Request #13119 · Expensify/App

marcaaron · 2022-11-29T03:27:27Z

Fixed Issues

$ #13116

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

This is not be affected by offline at all.

QA Steps

Log into an account that has no phone number set
Navigate to Settings -> Profile -> Add phone number
Ensure there is a phone number stored in the autofill information
Select the field and the phone number
Verify the color and background look normal

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots/Videos

Web

2022-11-28_17-22-40.mp4

Mobile Web - Chrome

Mobile Web - Safari

Not relevant

Desktop

Not Relevant

iOS

Not Relevant

Android

Not Relevant

marcaaron · 2022-11-29T03:39:19Z

FWIW, the autofill thinks that this is a username/password situation and not a phone number on Android Chrome - but the styles are correct. Will log this as a separate bug:

melvin-bot · 2022-11-29T03:40:56Z

@thesahindia @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2022-11-29T09:26:03Z

web/index.html

+        select:-webkit-autofill,
+        select:-webkit-autofill:hover,
+        select:-webkit-autofill:focus {
+            -webkit-transition-delay: 99999s;


NAB: Can we also add transition-delay?

Not sure if we need this, we are only targeting -webkit properties here.

thesahindia · 2022-11-29T09:36:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-11-29.at.2.53.11.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Can't be tested

Desktop

Can't be tested

iOS

Can't be tested

Android

thesahindia

LGTM!

MonilBhavsar

One NAB else looks good and works well.

github-actions · 2022-11-29T15:53:08Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

Fix autofill styles (cherry picked from commit 18eb1be)

…-13119 🍒 Cherry pick PR #13119 to staging 🍒

OSBotify · 2022-11-29T17:22:46Z

🚀 Cherry-picked to staging by @luacmartins in version: 1.2.33-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2022-11-30T04:01:43Z

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-30T04:26:16Z

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:40:16Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

marcaaron · 2023-06-16T18:52:28Z

wat 😅

OSBotify · 2023-06-16T18:58:01Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add comment

fe7576e

marcaaron self-assigned this Nov 29, 2022

marcaaron marked this pull request as ready for review November 29, 2022 03:40

marcaaron requested a review from a team as a code owner November 29, 2022 03:40

melvin-bot bot requested review from MonilBhavsar and thesahindia and removed request for a team November 29, 2022 03:40

marcaaron mentioned this pull request Nov 29, 2022

Deploy Checklist: New Expensify 2022-11-28 #13099

Closed

26 tasks

thesahindia reviewed Nov 29, 2022

View reviewed changes

thesahindia approved these changes Nov 29, 2022

View reviewed changes

MonilBhavsar approved these changes Nov 29, 2022

View reviewed changes

luacmartins added the CP Staging label Nov 29, 2022

luacmartins approved these changes Nov 29, 2022

View reviewed changes

luacmartins merged commit 18eb1be into main Nov 29, 2022

luacmartins deleted the marcaaron-fixAutoCompleteStyles branch November 29, 2022 15:57

OSBotify pushed a commit that referenced this pull request Nov 29, 2022

Merge pull request #13119 from Expensify/marcaaron-fixAutoCompleteStyles

89ac0fc

Fix autofill styles (cherry picked from commit 18eb1be)

OSBotify mentioned this pull request Nov 29, 2022

🍒 Cherry pick PR #13119 to staging 🍒 #13136

Merged

OSBotify added a commit that referenced this pull request Nov 29, 2022

Merge pull request #13136 from Expensify/OSBotify-cherry-pick-staging…

29bdc5c

…-13119 🍒 Cherry pick PR #13119 to staging 🍒

PauloGasparSv mentioned this pull request Nov 29, 2022

[HOLD for payment 2022-12-08] Web - Sign -The password is not visible in dark mode when you have autofill #13141

Closed

OSBotify mentioned this pull request Nov 30, 2022

Deploy Checklist: New Expensify 2022-11-30 #13180

Closed

32 tasks

melvin-bot bot mentioned this pull request Dec 1, 2022

[HOLD for payment 2022-12-08] Profile - If user uses saved information, background turns white & is very hard to read #13116

Closed

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Conversation

marcaaron commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots/Videos

Uh oh!

marcaaron commented Nov 29, 2022

Uh oh!

melvin-bot bot commented Nov 29, 2022

Uh oh!

thesahindia Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

luacmartins Nov 29, 2022

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 29, 2022

Uh oh!

OSBotify commented Nov 29, 2022

Uh oh!

OSBotify commented Nov 30, 2022

Uh oh!

OSBotify commented Nov 30, 2022

Uh oh!

OSBotify commented Jun 15, 2023

Uh oh!

marcaaron commented Jun 16, 2023

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcaaron commented Nov 29, 2022 •

edited

Loading

thesahindia commented Nov 29, 2022 •

edited

Loading