[No QA] Use yellow circle for meaningless regressions

[luacmartins]

Details

Prevents adding deploy blocker label for meaningless changes to duration regressions

Fixed Issues

$ #14159

Tests

1. Merge a PR with a meaningless performance regression.
2. Notice that the deploy blocker label is not added.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A since it only affects GH actions

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@thesahindia @Gonals One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[yuwenmemon]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	668.422 ms → 683.949 ms (+15.526 ms, +2.3%)
App start runJsBundle	180.031 ms → 192.375 ms (+12.344 ms, +6.9%)
App start nativeLaunch	9.581 ms → 19.586 ms (+10.006 ms, +104.4%) 🔴
App start regularAppStart	0.014 ms → 0.020 ms (+0.006 ms, +41.7%) 🔴
Open Search Page TTI	604.244 ms → 602.285 ms (-1.960 ms, ±0.0%)

Show details

Name	Duration
App start TTI	Baseline Mean: 668.422 ms Stdev: 34.197 ms (5.1%) Runs: 619.0270480001345 619.9719930002466 621.1219170000404 622.7941709998995 626.4292829995975 636.5237210001796 637.0455700000748 639.6547140004113 640.9279869999737 644.108659000136 645.3529369998723 645.7552220001817 649.1500770002604 650.5847009997815 656.4331499999389 668.9493920002133 671.2741459999233 673.4464480001479 678.5328120002523 678.8535230001435 681.0888189999387 689.2164169996977 689.2204369995743 697.652994999662 697.9814389999956 698.8604450002313 701.9033279996365 704.069024999626 704.6109009999782 720.5551810003817 731.1261529996991 747.2973050000146 Current Mean: 683.949 ms Stdev: 30.012 ms (4.4%) Runs: 628.8556430004537 632.4638979993761 642.9830900002271 645.3426900003105 648.9517950005829 659.5510310009122 661.567515000701 662.4324169997126 664.9498420003802 665.3717119991779 666.4844170007855 667.7713440004736 675.0529730003327 675.8869059998542 677.4132220000029 678.2546299993992 682.6733539998531 688.3883720003068 691.0715079996735 692.6064529996365 693.201099999249 697.1509060002863 697.6469250004739 698.6637009996921 700.4486779998988 709.2531029991806 711.4558070003986 719.7636309992522 727.1373059991747 732.8084469996393 737.3095100000501 753.445005999878
App start runJsBundle	Baseline Mean: 180.031 ms Stdev: 21.669 ms (12.0%) Runs: 151 155 156 157 158 158 158 158 158 159 165 167 169 170 172 172 173 178 181 183 186 192 192 203 204 208 209 211 212 214 216 216 Current Mean: 192.375 ms Stdev: 24.422 ms (12.7%) Runs: 157 158 160 162 169 171 173 173 176 177 179 181 181 183 183 186 187 189 194 197 199 199 200 207 208 213 214 217 232 237 241 253
App start nativeLaunch	Baseline Mean: 9.581 ms Stdev: 1.498 ms (15.6%) Runs: 7 8 8 8 8 8 8 8 9 9 9 9 9 9 9 9 9 10 10 10 10 10 10 11 11 11 11 11 12 12 14 Current Mean: 19.586 ms Stdev: 1.672 ms (8.5%) Runs: 17 17 17 18 18 18 18 18 19 19 19 19 19 19 19 20 20 20 20 20 20 21 21 21 21 22 22 22 24
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.002 ms (11.7%) Runs: 0.012492000125348568 0.0125730000436306 0.012817000038921833 0.012817000038921833 0.012817000038921833 0.012817999348044395 0.01285799965262413 0.012938999570906162 0.013141999952495098 0.013183999806642532 0.013264999724924564 0.013426999561488628 0.0134680001065135 0.013469000346958637 0.013508999720215797 0.013549999333918095 0.013631000183522701 0.013753000646829605 0.013753999955952168 0.013916000723838806 0.014078999869525433 0.014689000323414803 0.015381000004708767 0.01550300046801567 0.015747000463306904 0.016032000072300434 0.01769999973475933 0.017741000279784203 0.01887999940663576 Current Mean: 0.020 ms Stdev: 0.002 ms (7.7%) Runs: 0.01672299951314926 0.017659999430179596 0.01806599833071232 0.01826999895274639 0.018432999029755592 0.018472999334335327 0.018675999715924263 0.018880000337958336 0.018960999324917793 0.019123999401926994 0.019164999946951866 0.019368000328540802 0.019491000100970268 0.019572000950574875 0.0197759997099638 0.019937999546527863 0.020548000931739807 0.02075199969112873 0.020955000072717667 0.020955000072717667 0.021077001467347145 0.02115900069475174 0.021239999681711197 0.021403001621365547 0.021483998745679855 0.021525001153349876 0.02168699912726879 0.021768998354673386 0.021890999749302864 0.023843999952077866
Open Search Page TTI	Baseline Mean: 604.244 ms Stdev: 18.919 ms (3.1%) Runs: 572.140992000699 577.0786549998447 578.1303310003132 580.3566490001976 590.7043050006032 591.3134759999812 591.4792890008539 591.7081709988415 591.8222259990871 592.3658860009164 593.3802490010858 594.4325359994546 595.1837569996715 596.6833910010755 596.9943439997733 597.8426920007914 597.8428550008684 598.9097089990973 599.2278239987791 600.3187669999897 601.9019380006939 602.6649980004877 611.738567000255 619.2702639997005 621.0454520005733 621.9610190000385 626.3077400010079 628.0250650011003 629.0764169991016 629.8847659993917 631.8010660000145 637.2578129991889 651.2115070000291 Current Mean: 602.285 ms Stdev: 20.076 ms (3.3%) Runs: 561.2578129991889 575.409098001197 578.2445069998503 578.9639889989048 586.8848069999367 587.7282720003277 588.0147309992462 588.9426269996911 589.2387699987739 590.9832359999418 591.1699219997972 593.1673990003765 593.3182379994541 594.1508390009403 595.3655999992043 597.0961109995842 597.1655689999461 599.7314449995756 600.8642990011722 602.1179610006511 605.3771560005844 606.6416830010712 606.9766850005835 607.0111899990588 608.8342289999127 612.6519379988313 618.8728839997202 621.4462889991701 627.2209069989622 636.1148689985275 636.1847740001976 646.5579020008445 651.6886810008436

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[yuwenmemon]

Does this mean this didn't work? 🤔 Or is it that we were using the version of main before this merge for this comment?

[luacmartins]

I'm confused too haha. Let's see if the next merge has the same issue?

[AndrewGable]

I think it might take another "cycle" so agree let's wait and see.

[luacmartins]

Seems like it worked #14167 (comment)

[OSBotify]

🚀 Deployed to staging by @yuwenmemon in version: 1.2.52-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.2.52-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅