Update version of expensify-common by eh2077 · Pull Request #14582 · Expensify/App

eh2077 · 2023-01-26T01:10:39Z

Details

When replacing html with <p> and <li> tags, it misses newlines and some spaces. This PR fixes it by

adding a newline when replacing <p> tag
adding a newline and 2 leading spaces when replacing <li> tag

Fixed Issues

Tests

Login with any account and go to any chat room
Open/render HTML file in a browser

<!DOCTYPE html>
<html>
<body>
    <h1>HTML paragraphs and unordered list copy test</h1>
    <p>This is a HTML paragraph</p>
    <br>
    <p>An Unordered HTML List</p>
    <ul>
        <li><a href="https://example.com">Coffee</a> -- Coffee</li>
        <li><a href="https://example.com">Tea</a> -- Tea</li>
        <li><a href="https://example.com">Milk</a> -- Milk</li>
    </ul>
</body>
</html>

Copy and paste as is
Send it
Verify that <p> tag displays in newline and <li> item displays in newline with 2 prefix spaces

Note: For iOS native platform and Android native platform, only need to verify the sent text is displayed correctly because they don't support HTML pasting feature.

Verify that no errors appear in the JS console

Offline tests

Same as tests, but offline

QA Steps

Login with any account and go to any chat room
Open/render HTML file in a browser

<!DOCTYPE html>
<html>
<body>
    <h1>HTML paragraphs and unordered list copy test</h1>
    <p>This is a HTML paragraph</p>
    <br>
    <p>An Unordered HTML List</p>
    <ul>
        <li><a href="https://example.com">Coffee</a> -- Coffee</li>
        <li><a href="https://example.com">Tea</a> -- Tea</li>
        <li><a href="https://example.com">Milk</a> -- Milk</li>
    </ul>
</body>
</html>

Copy and paste as is
Send it
Verify that <p> tag displays in newline and <li> item displays in newline with 2 prefix spaces

Note: For iOS native platform and Android native platform, only need to verify the sent text is displayed correctly because they don't support HTML pasting feature.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mobile-web-chrome.mp4

Mobile Web - Safari

mobile-web-safari.mp4

Desktop

desktop.mp4

iOS

Only need to verify the sent text is displayed correctly on iOS native platform because it doesn't support HTML pasting feature.

Android

Only need to verify the sent text is displayed correctly on Android native platform because it doesn't support HTML pasting feature.

melvin-bot · 2023-01-26T01:10:45Z

@tgolen @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-01-26T01:10:56Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

eh2077 · 2023-01-26T01:11:30Z

I have read the CLA Document and I hereby sign the CLA

thesahindia · 2023-01-26T10:10:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

All good!

cc: @tgolen

OSBotify · 2023-01-26T16:10:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-01-26T20:39:38Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.2.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-01-27T20:33:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.60-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update expensify common module

01de3b2

eh2077 requested a review from a team as a code owner January 26, 2023 01:10

melvin-bot bot requested review from tgolen and thesahindia and removed request for a team January 26, 2023 01:10

thesahindia approved these changes Jan 26, 2023

View reviewed changes

tgolen approved these changes Jan 26, 2023

View reviewed changes

tgolen merged commit fafab61 into Expensify:main Jan 26, 2023

OSBotify mentioned this pull request Jan 26, 2023

Deploy Checklist: New Expensify 2023-01-26 #14604

Closed

13 tasks

melvin-bot bot mentioned this pull request Jan 27, 2023

[HOLD for payment 2023-02-03] [$4000] Chat - The Paragraphs are not displayed and some spaces missing between text after copied test from the opened HTML file #12155

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update version of expensify-common#14582

Update version of expensify-common#14582
tgolen merged 1 commit intoExpensify:mainfrom
eh2077:fix-newlines-and-spaces-when-replacing-p-tag-and-li-tag

eh2077 commented Jan 26, 2023

Uh oh!

melvin-bot bot commented Jan 26, 2023

Uh oh!

github-actions bot commented Jan 26, 2023 •

edited

Loading

Uh oh!

eh2077 commented Jan 26, 2023

Uh oh!

thesahindia commented Jan 26, 2023

Uh oh!

thesahindia left a comment

Uh oh!

OSBotify commented Jan 26, 2023

Uh oh!

OSBotify commented Jan 26, 2023

Uh oh!

OSBotify commented Jan 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

eh2077 commented Jan 26, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 26, 2023

Uh oh!

github-actions bot commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eh2077 commented Jan 26, 2023

Uh oh!

thesahindia commented Jan 26, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 26, 2023

Uh oh!

OSBotify commented Jan 26, 2023

Uh oh!

OSBotify commented Jan 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Jan 26, 2023 •

edited

Loading