Redirect to the last chat you were looking at if you are signed out #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
reviewed
Aug 14, 2020
| console.info('[API] UnhandledError', responseData); | ||
| }) | ||
| // eslint-disable-next-line no-unused-vars | ||
| // This will catch any HTTP network errors (like 404s and such), not to be confused with jsonCode which this |
Contributor
There was a problem hiding this comment.
Does catch 404s or not? The way I read the comment is it does catch 404s and I thought it only caught errors when the fetch actually fails to make the request?
Contributor
Author
There was a problem hiding this comment.
Yes, it catches 404s and any network layer failure. It does NOT catch jsonCode errors. Any suggestions to make the comment better?
Contributor
There was a problem hiding this comment.
Ah ok I didn't realize it caught 404s, so this is good!
AndrewGable
approved these changes
Aug 14, 2020
mountiny
pushed a commit
that referenced
this pull request
Feb 12, 2025
…om-tab-bar POC/Top level bottom tab bar
andriivitiv
added a commit
to andriivitiv/ExpensifyApp
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128