Fix/make emojis larger in other contexts

[josemak25]

Details

This solution covers several related scenarios:

Scenario 1

Action Performed:

Add an emoji with other plain text characters in a message in the composer.

Expected Result:

The emoji should be larger (19pt) compared to the default size for text (15pt) in the composer. The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of #4114 (comment).

Solution does not cover this case as handling emojis inside the input is a bit tricky

Scenario 2

Action Performed:

Send a message with emojis and text.

Expected Result:

The emoji should be larger (19pt) compared to the default size for text (15pt) in the chat history. The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of #4114 (comment)

Solution covers this case

Scenario 3

Action Performed

Draft a message (of any length) with only an emoji.

Expected Result:

The emoji should appear very large (27pt) in the composer.

Solution does not cover this case as handling emojis inside the input is a bit tricky

Scenario 4

Action Performed

Send a message (of any length) with only emoji.

Expected Result:

The emoji should appear very large (27pt) in the report history.

Solution covers this case

Scenario 5

Action Performed

Go to Settings -> Profile and add emoji(s) to your last name 😎

Expected Result:

The emoji should appear larger (19pt) than the rest of the text (15pt) in the text input. The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of #4114 (comment)

Solution does not cover this case as handling emojis inside the input is a bit tricky

Scenario 6

Action Performed

1. Go to Settings -> Profile and add emoji(s) to your last name 😎.
2. Save your profile.
3. Open the Settings RHP and look at your name:

Expected Result:

The emoji should appear larger (21pt) than the rest of the text (17pt) in the text input. The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of #4114 (comment)

Solution covers this case

Scenario 7

Action Performed

1. Go to Settings -> Profile and add emoji(s) to your last name 😎.
2. Save your profile.
3. Open a chat with another user and send them a message. Take a look at your message in the report history.

Expected Result:

The emoji should appear larger (19pt) than the rest of the test (15pt). The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji (like the right-hand-side of #4114 (comment)

Solution covers this case

Fixed Issues

$ #4114

Tests

1. The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji
2. Draft a message (of any length) with only emoji the emoji should appear very large (27pt) in the composer.
3. Go to Settings -> Profile and add emoji(s)[😎] to your last name or first name and save your profile. now open the settings RHP and look at your name, the emoji appear to be bigger in size than the text.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. The emoji and text should appear vertically centered with respect to each other, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji
2. Draft a message (of any length) with only emoji the emoji should appear very large (27pt) in the composer.
3. Go to Settings -> Profile and add emoji(s)[😎] to your last name or first name and save your profile. now open the settings RHP and look at your name, the emoji appear to be bigger in size than the text.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Chrome Web

Chrome.Web.Recording.mov

Safari Web

Safari.Web.Recording.mov

Mobile Web - Chrome

Mobile.Web.-.Chrome.mov

Mobile Web - Safari

Mobile.Web.-.Safari.mp4

Desktop

Desktop.mov

iOS

iOS.mp4

Android

Android.mov

[roryabraham]

@josemak25 this PR includes a lot of commits that it should not. Let's once more create a fresh PR with just the commits and changes that are relevant to this issue. This time, please make sure that all your commits are signed before creating the pull request. You can set up automatic commit signing so you don't have to think about it going forward

[parasharrajat]

@josemak25 details are looking good. let's add that in next PR.

[josemak25]

@josemak25 this PR includes a lot of commits that it should not. Let's once more create a fresh PR with just the commits and changes that are relevant to this issue. This time, please make sure that all your commits are signed before creating the pull request. You can set up automatic commit signing so you don't have to think about it going forward

@roryabraham here is the new PR as requested #15611