[Snyk] Security upgrade electron from 22.2.0 to 22.3.3 #16071

snyk-bot · 2023-03-17T08:45:00Z

Details

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
- package.json
- package-lock.json

Vulnerabilities that will be fixed

With an upgrade:

Issue	Breaking Change	Exploit Maturity
Use After Free SNYK-JS-ELECTRON-3356652	No	No Known Exploit
Use After Free SNYK-JS-ELECTRON-3356653	No	No Known Exploit
Use After Free SNYK-JS-ELECTRON-3361725	No	No Known Exploit
Use After Free SNYK-JS-ELECTRON-3361731	No	No Known Exploit

Check the changes in this PR to ensure they won't cause issues with your project.

Fixed Issues

$ #16072
PROPOSAL: https://github.com/Expensify/App/issues/16072_ISSUE(COMMENT)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELECTRON-3356652 - https://snyk.io/vuln/SNYK-JS-ELECTRON-3356653 - https://snyk.io/vuln/SNYK-JS-ELECTRON-3361725 - https://snyk.io/vuln/SNYK-JS-ELECTRON-3361731

MelvinBot · 2023-03-17T08:45:46Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-03-17T09:10:11Z

@pecanoro does this require C+ review? Asking since I am assigned on the issue.

pecanoro · 2023-03-17T16:17:39Z

Oh yes, we actually do. We are actually writing down guidelines on how to review these PRs. But for now, since we are updating electron here, it would be ideal if we can have general testing of the app and make sure nothing broke due to the package bump.

aimane-chnaif · 2023-03-17T17:28:08Z

Release Notes 22.2.0 -> 22.3.3

Features

Whole-program optimization is enabled by default in electron node headers config file. #37047 (Also in 21, 23)
Added several standard page size options to webContents.print(). #37263 (Also in 23, 24)

Fixes

Basic accessibility support is now enabled when macOS Voice Control is activated to allow for full voice control of Electron applications. #37146 (Also in 21, 23)
Fixed audio worklet scripts failing to run when nodeIntegrationInWorker: true. #37102 (Also in 23)
Fixed a crash when BrowserViews are present and a user attempts to prevent beforeunload in the renderer process. #37266 (Also in 23, 24)
Fixed an incorrect result returned when using secure as a cookies filter. #37247 (Also in 24)
Fixed an issue where minWidth/minHeight and maxWidth/maxHeight would not be enforced if the user set an aspectRatio on macOS. #37458 (Also in 23, 24)
Fixed an issue where passing both hasReply and actions to a main process Notification on macOS resulted in the first action being obscured and unavailable. #37447 (Also in 23, 24)
Fixed window could not go back to maximized state when restored on Linux. #37360 (Also in 23, 24)
Fixed an issue where unhandled rejections could cause duplicate logs in some cases. #37502 (Also in 23, 24)

Other changes

Security: backported fix for chromium:1408392. #37298
Improved error messages for contents.takeHeapSnapshot. #37459 (Also in 23, 24)
Security: backported fix for 1414224. #37483
Security: backported fix for CVE-2023-0928. #37481
Security: backported fix for CVE-2023-0929. #37479
Security: backported fix for CVE-2023-0931. #37477
Security: backported fix for CVE-2023-0932. #37485

It seems there are no major refactors or changes that can affect or break the app.
Performing app tests on all platforms...

aimane-chnaif · 2023-03-20T10:30:26Z

package-lock.json

        "diff-so-fancy": "^1.3.0",
        "dotenv": "^16.0.3",
-        "electron": "22.2.0",
+        "electron": "^22.3.3",


@pecanoro I noticed that package-lock.json Synk generated is different from ours after npm i

Suggested change

"electron": "^22.3.3",

"electron": "22.3.3",

Should we commit this change?

Sure, as long as everything is still working 😄 It is not letting me commit the suggestion, so I will push to the PR.

aimane-chnaif · 2023-03-21T02:00:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

Android

aimane-chnaif

All apps are working as normal. No console errors.

OSBotify · 2023-03-21T10:34:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-21T16:06:01Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.2.88-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-21T18:10:52Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.2.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-24T23:59:34Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-03-27T09:45:58Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

snyk-bot requested a review from a team as a code owner March 17, 2023 08:45

melvin-bot bot requested review from pecanoro and removed request for a team March 17, 2023 08:45

pecanoro requested a review from aimane-chnaif March 17, 2023 16:17

aimane-chnaif reviewed Mar 20, 2023

View reviewed changes

Update package-lock

dfb34ad

aimane-chnaif approved these changes Mar 21, 2023

View reviewed changes

pecanoro approved these changes Mar 21, 2023

View reviewed changes

pecanoro merged commit 3be4d99 into main Mar 21, 2023

pecanoro deleted the snyk-fix-435fad5356fa0834d90409b40c07f3ec branch March 21, 2023 10:28

OSBotify mentioned this pull request Mar 21, 2023

Deploy Checklist: New Expensify 2023-03-21 #16345

Closed

28 tasks

MelvinBot mentioned this pull request Mar 24, 2023

[HOLD for payment 2023-03-31] [Snyk] Security upgrade electron from 22.2.0 to 22.3.3 #16072

Closed

situchan mentioned this pull request Mar 28, 2023

[No QA] Fix lock file #16586

Merged

53 tasks

[Snyk] Security upgrade electron from 22.2.0 to 22.3.3 #16071

[Snyk] Security upgrade electron from 22.2.0 to 22.3.3 #16071

Uh oh!

Conversation

snyk-bot commented Mar 17, 2023 • edited by melvin-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Vulnerabilities that will be fixed

With an upgrade:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 17, 2023

Uh oh!

aimane-chnaif commented Mar 17, 2023

Uh oh!

pecanoro commented Mar 17, 2023

Uh oh!

aimane-chnaif commented Mar 17, 2023

Release Notes 22.2.0 -> 22.3.3

Features

Fixes

Other changes

Uh oh!

aimane-chnaif Mar 20, 2023

Choose a reason for hiding this comment

Uh oh!

pecanoro Mar 20, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Mar 21, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 21, 2023

Uh oh!

OSBotify commented Mar 21, 2023

Uh oh!

OSBotify commented Mar 21, 2023

Uh oh!

OSBotify commented Mar 24, 2023

Uh oh!

OSBotify commented Mar 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

snyk-bot commented Mar 17, 2023 •

edited by melvin-bot bot

Loading