fix details page crash without route params #16438

bernhardoj · 2023-03-23T08:45:57Z

Details

The app crash when we access details page without login params staging.new.expensify.com/details.

Fixed Issues

$ #15486
PROPOSAL: #15486 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any chat
Send staging.new.expensify.com/details link to the chat
Open the link you just sent
Verify "Not found" page is shown in the RHN

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-23.at.00.00.50.mov

Mobile Web - Chrome

WhatsApp.Video.2023-03-23.at.16.21.57.1.mp4

Mobile Web - Safari

Screen.Recording.2023-03-23.at.01.40.04.mov

Desktop

Screen.Recording.2023-03-23.at.00.11.05.mov

iOS

Screen.Recording.2023-03-23.at.01.42.38.mov

Android

WhatsApp.Video.2023-03-23.at.16.21.54.mp4

MelvinBot · 2023-03-23T08:46:04Z

@marcochavezf @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/DetailsPage.js

mananjadhav · 2023-03-23T09:00:19Z

src/pages/DetailsPage.js

        // If we have a reportID param this means that we
        // arrived here via the ParticipantsPage and should be allowed to navigate back to it
-        const shouldShowBackButton = Boolean(this.props.route.params.reportID);
+        const shouldShowBackButton = Boolean(reportID);


Why did we need update this line?

It will cause crash too when we go to staging.new.expensify.com/details because the params is undefined.

mananjadhav

2 minor comments, otherwise code looks good.

mananjadhav · 2023-03-24T17:14:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

This works well, Thanks for the quick PR @bernhardoj. @marcochavezf All yours.

Few points:

I am not sure if we should show the Back button. I am neutral about it.
For Desktop, Android and iOS I triggered a ROUTES.DETAILS on New Chat button click to test it out.
Do we specify RHS in the QA steps last point (pt 4), Verify "Not found" page is shown on the RHS.

bernhardoj · 2023-03-25T04:13:29Z

I am not sure if we should show the Back button. I am neutral about it.

Looking at the other pages, all of them show the back button.

Do we specify RHS in the QA steps last point (pt 4),

Yes, I think that's a good idea. Updated!

marcochavezf · 2023-03-27T10:00:31Z

I am not sure if we should show the Back button. I am neutral about it.

Looking at the other pages, all of them show the back button.

In theory it should go to the previous page, but if the user is navigating to a wrong route directly in the browser I think it doesn't make sense to show the back button. Where are we navigating the user when the back button is pressed?

mananjadhav · 2023-03-27T10:01:45Z

Where are we navigating the user when the back button is pressed?

At the moment it goes to the Chat page.

mananjadhav · 2023-03-27T10:08:03Z

but if the user is navigating to a wrong route directly in the browser

@marcochavezf It could also be the case that the user did hit the correct URL with the params, but removed the params and hit Enter. In that case we should allow going Back. I think we should keep this as of now, and ensure that it doesn't come as a regression later on.

bernhardoj · 2023-03-27T10:23:11Z

Both back and close button will call Navigation.dismissModal().

OSBotify · 2023-03-28T10:18:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-28T18:12:44Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.2.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-29T17:49:02Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.91-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix details page crash without route params

6ccfc4b

bernhardoj requested a review from a team as a code owner March 23, 2023 08:45

melvin-bot bot requested review from mananjadhav and marcochavezf and removed request for a team March 23, 2023 08:46

mananjadhav reviewed Mar 23, 2023

View reviewed changes

src/pages/DetailsPage.js Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 23, 2023

View reviewed changes

fix lint

113e66b

mananjadhav approved these changes Mar 24, 2023

View reviewed changes

marcochavezf approved these changes Mar 28, 2023

View reviewed changes

marcochavezf merged commit 69bba91 into Expensify:main Mar 28, 2023

OSBotify mentioned this pull request Mar 28, 2023

Deploy Checklist: New Expensify 2023-03-28 #16632

Closed

30 tasks

MelvinBot mentioned this pull request Mar 29, 2023

[HOLD for payment 2023-04-05] [HOLD][$2000] https://staging.new.expensify.com/details crashed app #15486

Closed

6 tasks

fix details page crash without route params #16438

fix details page crash without route params #16438

Uh oh!

Conversation

bernhardoj commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 23, 2023

Uh oh!

Uh oh!

mananjadhav Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

bernhardoj Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Mar 24, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Mar 25, 2023

Uh oh!

marcochavezf commented Mar 27, 2023

Uh oh!

mananjadhav commented Mar 27, 2023

Uh oh!

mananjadhav commented Mar 27, 2023

Uh oh!

bernhardoj commented Mar 27, 2023

Uh oh!

OSBotify commented Mar 28, 2023

Uh oh!

OSBotify commented Mar 28, 2023

Uh oh!

OSBotify commented Mar 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bernhardoj commented Mar 23, 2023 •

edited

Loading