Update version React-Native-Onyx 1.0.39 by tienifr · Pull Request #16531 · Expensify/App

tienifr · 2023-03-27T09:27:44Z

Details

It comes from this PR

Fixed Issues

$ #15321
$ #15321 (comment)

Tests

Open the app in the browser
Open another tab in the same browser
Log out from one of the tabs
Verify that in other tab the app is not crashed and logged out to the login page.

Verify that no errors appear in the JS console

Offline tests

Open the app in the browser
Open another tab in the same browser
Disable the internet
Log out from one of the tabs
Verify that in other tab the app is not crashed and logged out to the login page.

QA Steps

Open the app in the browser
Open another tab in the same browser
Log out from one of the tabs
Verify that in other tab the app is not crashed and logged out to the login page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

15321.Web.mov

Mobile Web - Chrome

mobile.mp4

Mobile Web - Safari

RPReplay_Final1681716247.mp4

Desktop

15321.Desktop.mov

iOS

15321.iOS.mov

Android

15321.android.webm

MelvinBot · 2023-03-27T09:27:51Z

@roryabraham @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-03-27T10:42:40Z

Hi @sobitneupane @roryabraham This PR update the React-Native-ONYX version to 1.0.39. Please help to review this PR first

sobitneupane · 2023-03-28T08:08:32Z

package.json

    "react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#84ee97dec11c2e65609511eb5a757d61bbeeab79",
    "react-native-plaid-link-sdk": "^10.0.0",
-    "react-native-quick-sqlite": "^5.0.3",
+    "react-native-quick-sqlite": "^8.0.0-beta.2",


Why is this change required here?

In the react-Native-Onyx, we just updated "react-native-quick-sqlite": "^8.0.0-beta.2" and this package is peerDependencies so we need to update it in the App repo

Can you please link your PR in "react-native-onyx" in the PR body for which we are making update in "react-native-onyx" through this PR.

Yes, it is this PR

sobitneupane

Yet to test on android. Getting some errors while building android app.

Screenshots/Videos

Web

Screen.Recording.2023-03-28.at.13.28.52.mov

Mobile Web - Chrome

Screen.Recording.2023-03-28.at.13.44.57.mov

Mobile Web - Safari

Screen.Recording.2023-03-28.at.13.40.45.mov

Desktop

Screen.Recording.2023-03-28.at.13.39.05.mov

iOS

Screen.Recording.2023-03-28.at.13.42.40.mov

Android

tienifr · 2023-03-28T10:16:21Z

@sobitneupane
This bug causes by upgrading the version of "react-native-quick-sqlite": "^8.0.0-beta.2" that is merged in React-Native-ONYX but it has not been updated in the app repo
So I think we need to wait for a PR update React-Native-ONYX version to 1.0.38 from this issue

cc @priyeshshah11 @mountiny

priyeshshah11 · 2023-03-31T05:04:42Z

@sobitneupane This bug causes by upgrading the version of "react-native-quick-sqlite": "^8.0.0-beta.2" that is merged in React-Native-ONYX but it has not been updated in the app repo So I think we need to wait for a PR update React-Native-ONYX version to 1.0.38 from this issue

cc @priyeshshah11 @mountiny

Commented here #15124 (comment)

roryabraham

@tienifr LGTM, but looks like we've got conflicts

mountiny · 2023-03-31T13:51:44Z

I think this needs to be on hold for the RN update @roryabraham

mountiny · 2023-04-11T13:00:38Z

We are very close to merging the RN update.

mountiny

@tienifr The RN update has been merged, would you be able to resolve the merge conflicts? I think we should wait one release cycle before merging so this is not merged together with the RN update in case there are some regressions from either.

mountiny · 2023-04-13T13:07:08Z

@tienifr bumping this one, I think we are good to go now

mountiny · 2023-04-14T07:26:11Z

@sobitneupane would you be able to retest please 🙇

mountiny

LGTM, lets test this and get the checklist done and we can

sobitneupane · 2023-04-14T08:44:38Z

@tienifr Can you please update the Screenshots.

sobitneupane

Screenshots/Videos

Web

Screen.Recording.2023-04-17.at.11.18.28.mov

Mobile Web - Chrome

Screen.Recording.2023-04-17.at.11.55.52.mov

Mobile Web - Safari

Screen.Recording.2023-04-17.at.12.02.56.mov

Desktop

Screen.Recording.2023-04-17.at.12.06.55.mov

iOS

Screen.Recording.2023-04-17.at.12.07.56.mov

Android

Screen.Recording.2023-04-17.at.11.22.26.mov

sobitneupane · 2023-04-17T06:25:19Z

@tienifr Bump on #16531 (comment)

tienifr · 2023-04-17T07:40:01Z

@sobitneupane I've updated the screenshots please help take a look. Thanks

mountiny

I think this is looking good based on the @sobitneupane testing, can you also please finish the checklist now that @tienifr updated the screenshots?

tests/unit/NetworkTest.js

sobitneupane · 2023-04-21T07:22:11Z

@tienifr Can you please update #15556 and make it ready for review. I would like to test it before this PR gets merged?

roryabraham · 2023-04-21T16:08:57Z

package.json

    "shim-keyboard-event-key": "^1.0.3",
-    "underscore": "^1.13.1"
+    "underscore": "^1.13.1",
+    "localforage-removeitems": "^1.4.0"


Minor point but package.json is currently in alphabetical order – let's keep it that way

tienifr · 2023-04-22T07:52:13Z

@roryabraham I've changed localforage-removeitems order in package.json.
@sobitneupane I don't actually understand your mean. I think the PR: #15556 is ready for testing (includes all the changes of this PR). Please correct me if i'm wrong. Thanks

roryabraham · 2023-04-22T13:08:34Z

LGTM, thanks @tienifr 🙇🏼

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mountiny

Nice I think we are good to go, thanks!

OSBotify · 2023-04-24T04:31:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-25T06:09:23Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

iwiznia · 2023-04-25T18:36:03Z

It's possible this caused this regression #17966 (comment)

OSBotify · 2023-04-26T05:51:23Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update RN-onyx 1.0.39

ec71ccc

tienifr requested a review from a team as a code owner March 27, 2023 09:27

melvin-bot bot requested review from roryabraham and sobitneupane and removed request for a team March 27, 2023 09:27

fix: UTs

0dfd9ab

sobitneupane reviewed Mar 28, 2023

View reviewed changes

mountiny assigned tienifr Mar 28, 2023

tienifr mentioned this pull request Mar 31, 2023

[HOLD for payment 2023-04-20] [$4000] Update RN version to our latest v0.71.2-alpha.3 #15124

Closed

roryabraham previously approved these changes Mar 31, 2023

View reviewed changes

resolve conflict

4e67189

tienifr dismissed roryabraham’s stale review via 4e67189 April 11, 2023 10:34

mountiny reviewed Apr 11, 2023

View reviewed changes

roryabraham mentioned this pull request Apr 12, 2023

[HOLD #34289] [$2000] The app crashes when the user is logged into multiple tabs and logs out of one of the tabs #15321

Closed

6 tasks

merge main

01251dc

mountiny approved these changes Apr 14, 2023

View reviewed changes

sobitneupane reviewed Apr 17, 2023

View reviewed changes

mountiny previously approved these changes Apr 17, 2023

View reviewed changes

roryabraham reviewed Apr 17, 2023

View reviewed changes

tests/unit/NetworkTest.js Show resolved Hide resolved

roryabraham requested changes Apr 21, 2023

View reviewed changes

tienifr added 2 commits April 22, 2023 14:41

Merge branch 'main' into update-version-react-native-onyx-1.0.39

e7a7830

fix: update package order

c4393f9

tienifr dismissed mountiny’s stale review via c4393f9 April 22, 2023 07:44

roryabraham approved these changes Apr 22, 2023

View reviewed changes

sobitneupane approved these changes Apr 23, 2023

View reviewed changes

mountiny approved these changes Apr 24, 2023

View reviewed changes

mountiny merged commit 8635c98 into Expensify:main Apr 24, 2023

sobitneupane mentioned this pull request Apr 25, 2023

fix: The app crashes when the user is logged into multiple tabs and logs out of one of the tabs #15321 #15556

Merged

55 tasks

OSBotify mentioned this pull request Apr 25, 2023

Deploy Checklist: New Expensify 2023-04-25 #17948

Closed

37 tasks

kbecciv mentioned this pull request Apr 25, 2023

mWeb - Login - Skeleton appears for a while before log out automatically on a second tab #17967

Closed

6 tasks

iwiznia mentioned this pull request Apr 25, 2023

Login - Infinite spinner appears in login page after tap didn't receive a magic code #17966

Closed

6 tasks

Conversation

tienifr commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 27, 2023

Uh oh!

tienifr commented Mar 27, 2023

Uh oh!

sobitneupane Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sobitneupane Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

tienifr commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

priyeshshah11 commented Mar 31, 2023

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Mar 31, 2023

Uh oh!

mountiny commented Apr 11, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Apr 13, 2023

Uh oh!

mountiny commented Apr 14, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

sobitneupane commented Apr 14, 2023

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

sobitneupane commented Apr 17, 2023

Uh oh!

tienifr commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sobitneupane commented Apr 21, 2023

Uh oh!

roryabraham Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr commented Apr 22, 2023

Uh oh!

roryabraham commented Apr 22, 2023

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

tienifr commented Mar 27, 2023 •

edited

Loading

tienifr Mar 28, 2023 •

edited

Loading

tienifr commented Mar 28, 2023 •

edited

Loading

tienifr commented Apr 17, 2023 •

edited

Loading