Update login flow error handling

[suphero]

Details

This pull request updates error handling on the login flow to improve the identification of errors and their proper display.

Fixed Issues

$ #16874
PROPOSAL: #16874 (comment)

Tests

Scenario 1 - Invalid Phone number

1. If logged in, log out of the app.
2. Enter "1234567890" into the "Phone or email" field.
3. Press the "Continue" button.
4. Ensure the app underlines the "Phone or email" field in red.

Success scenario:

1. Enter the phone number of an existing account.
2. Press the "Continue" button.
3. Ensure the app navigates to the "Password" page.

Scenario 2 - Invalid Password

1. If logged in, log out of the app.
2. Enter a valid phone number or email into the "Phone or email" field.
3. Press the "Continue" button.
4. Enter an invalid password into the "Password" field.
5. Press the "Sign In" button.
6. Ensure the app underlines the "Password" field in red.

Success scenario:

1. Enter the valid password into the "Password" field.
2. Press the "Sign In" button.
3. Ensure the app successfully signs in.

Scenario 3 - Invalid Two-Factor Code

1. If logged in, log out of the app.
2. Enter the email/phone of an account with TFA enabled into the "Phone or email" field.
3. Press the "Continue" button.
4. Enter the valid password into the "Password" field.
5. Press the "Sign In" button.
6. Enter an invalid two-factor code into the "Two factor code" field.
7. Press the "Sign In" button.
8. Ensure the app underlines only the "Two factor code" field in red.

Success scenario:

1. Enter the valid two-factor code into the "Two factor code" field.
2. Press the "Sign In" button.
3. Ensure the app successfully signs in.

Scenario 4 - Invalid Magic code

1. If logged in, log out of the app.
2. Enter the email/phone of an account with Passwordless input enabled (beta feature) into the "Phone or email" field.
3. Enter an invalid magic code into the "Magic code" field.
4. Press the "Sign In" button.
5. Ensure the app underlines the "Magic code" field in red.

Success scenario:

1. Enter the valid magic code into the "Magic code" field.
2. Press the "Sign In" button.
3. Ensure the app successfully signs in.

• Verify that no errors appear in the JS console

Offline tests

N/A, this flow requires being online

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Scenario 1 - Invalid Phone number:

Scenario 2 - Invalid Password

Scenario 3 - Invalid Two-Factor Code

Scenario 4 - Invalid Magic code

Mobile Web - Chrome

Scenario 1 - Invalid Phone number:

Scenario 2 - Invalid Password

Scenario 3 - Invalid Two-Factor Code

Scenario 4 - Invalid Magic code

Mobile Web - Safari

Scenario 1 - Invalid Phone number:

Scenario 2 - Invalid Password

Scenario 3 - Invalid Two-Factor Code

Scenario 4 - Invalid Magic code

Desktop

Scenario 1 - Invalid Phone number:

Scenario 2 - Invalid Password

Scenario 3 - Invalid Two-Factor Code

Scenario 4 - Invalid Magic code

iOS

Scenario 1 - Invalid Phone number:

Scenario 2 - Invalid Password

Scenario 3 - Invalid Two-Factor Code

Scenario 4 - Invalid Magic code

Android

Scenario 1 - Invalid Phone number:

Scenario 2 - Invalid Password

Scenario 3 - Invalid Two-Factor Code

Scenario 4 - Invalid Magic code

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[MelvinBot]

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[suphero]

I have read the CLA Document and I hereby sign the CLA

[cristipaval]

@suphero next time please link the issue and the comment with the proposal when you create the PR, in order to get the appropriate reviewers assigned.

[suphero]

@cristipaval, I've already linked the issue and the comment with the proposal. Is there any other step that I missed?

[cristipaval]

@cristipaval, I've already linked the issue and the comment with the proposal. Is there any other step that I missed?

Did you link them at the PR creation or afterward?

[suphero]

@cristipaval, I've already linked the issue and the comment with the proposal. Is there any other step that I missed?

Did you link them at the PR creation or afterward?

I've linked them at the PR creation.

[cristipaval]

Hmm... @mountiny I guess Melvin failed this time, or?

[Santhosh-Sellavel]

@suphero

It is linked like this.

 ### Fixed Issues
 $ [#16874](https://github.com/Expensify/App/issues/16874) 

But it should be linked like this

 ### Fixed Issues
 $ https://github.com/Expensify/App/issues/16874

[suphero]

Oh I see, I'll be careful next time

[Santhosh-Sellavel]

The password page is not handled here, check this #16874 (comment)

[Santhosh-Sellavel]

@flodnv We should handle password and validate the code form too right?

Screen.Recording.2023-04-11.at.1.38.16.AM.mov

cc: @suphero

[flodnv]

Yes this makes sense to me 👍

[Santhosh-Sellavel]

Cool, @suphero Can you make the change and update PR details accordingly thanks!

[suphero]

Cool, @suphero Can you make the change and update PR details accordingly thanks!

I've made the change and updated the PR.

[mountiny]

I think it was not initially linked as a full link

@suphero for next prs, make sure its a full link after the dollar sign $ https://github.com/Expensify/App/pull/17168

Thank you 🙇 Great to see a first time contributor!! 🎉

[suphero]

I think it was not initially linked as a full link

@suphero for next prs, make sure its a full link after the dollar sign $ https://github.com/Expensify/App/pull/17168

Thank you 🙇 Great to see a first time contributor!! 🎉

Thanks @mountiny, I'll keep it in mind.

[Santhosh-Sellavel]

@suphero password page is missed here

[suphero]

@suphero password page is missed here

You mean in description or changed files? I think both requirements in the issue (red underline in phone number and magic code) are met.

[Santhosh-Sellavel]

@flodnv We should handle password and validate the code form too right?

Screen.Recording.2023-04-11.at.1.38.16.AM.mov

cc: @suphero

I mentioned here to handle on password page and magic code also

[Santhosh-Sellavel]

@flodnv Can you run workflows

[flodnv]

Sure, done

[Santhosh-Sellavel]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

#17168 (comment)

[Santhosh-Sellavel]

@suphero

Look Have a look at this sign commits

[Santhosh-Sellavel]

LGTM tests well, to waiting to sign commits

[suphero]

@flodnv @Santhosh-Sellavel Can you please run workflows?

[Santhosh-Sellavel]

LGTM, all you!

@flodnv Can you run the workflow again?

[flodnv]

Just one minor comment, looks good 👍

[suphero]

Fixed the minor comment, can you please run the workflow again?

@flodnv @Santhosh-Sellavel

[Santhosh-Sellavel]

Minor, thing!

[suphero]

Minor, thing!

Fixed that too.

[suphero]

Is there any issue with the workflow jobs? It seems that workflows were stuck at 99.7% for 30 minutes.

Received 1448274937 of 1452469241 (99.7%)

https://github.com/Expensify/App/actions/runs/4726168929/jobs/8385976224
https://github.com/Expensify/App/actions/runs/4726168929/jobs/8385975889

[suphero]

Is there any issue with the workflow jobs? It seems that workflows were stuck at 99.7% for 30 minutes.

Received 1448274937 of 1452469241 (99.7%)

https://github.com/Expensify/App/actions/runs/4726168929/jobs/8385976224 https://github.com/Expensify/App/actions/runs/4726168929/jobs/8385975889

The workflows passed after 1 hour with the following message.

Warning: Failed to restore: Aborting cache download as the download time exceeded the timeout.
npm cache is not found

[Santhosh-Sellavel]

@flodnv if workflows pass feel free to merge this one!

LGTM tests well!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.2-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅