Fix Spanish copy in a few places #17302

pecanoro · 2023-04-11T21:05:17Z

Details

Just some copy

Fixed Issues

$ #17184

Tests / QA Steps

Open the app
Enter an email address of an account that already exists.
Continue to the next screen
Under the Sign in button, the copy to go back should say: Not <email?>? Go back

Change the language to Spanish and repeat the process. Now the copy under Conectarse should say: ¿No eres <email>? Volver.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Monosnap New Expensify 2023-04-11 17-16-00

Monosnap New Expensify 2023-04-11 17-16-25

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-04-12T00:58:09Z

@thesahindia @Beamanator One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pecanoro · 2023-04-12T00:58:33Z

It's all Spanish copy changes, so just leaving @iwiznia as reviewer.

src/languages/es.js

iwiznia · 2023-04-12T14:07:57Z

src/languages/es.js

+            invalidAmount: 'Importe no válido',
            acceptTerms: 'Debes aceptar los Términos de servicio para continuar',
-            phoneNumber: `Ingresa un teléfono válido, incluyendo el código de país (p. ej. ${CONST.EXAMPLE_PHONE_NUMBER})`,
+            phoneNumber: `Introduce un teléfono válido, incluyendo el código del país (p. ej. ${CONST.EXAMPLE_PHONE_NUMBER})`,


ok so it is introduce everywhere from now on

Yeah, I used https://www.deepl.com/en/translator to check which would be the most common translation to see what would make more sense.

pecanoro · 2023-04-12T16:45:36Z

Updated, I cleaned even more copy and retested it for the change in the login page.

src/languages/es.js

iwiznia · 2023-04-12T17:09:00Z

src/languages/es.js

        headerTitle: 'Detalles adicionales',
-        helpText: 'Necesitamos confirmar la siguiente información antes de que podamos procesar este pago.',
-        helpTextIdologyQuestions: 'Tenemos que preguntarte unas preguntas mas para terminar de verificar tu identidad',
+        helpText: 'Necesitamos confirmar la siguiente información antes de que podamos procesar el pago.',


English says this, I think this is shown in the flow of attempting to pay a request?

It's inferred that is referring to the payment that they are trying to perform but I can say este again. Up to you

pecanoro · 2023-04-13T01:14:07Z

@iwiznia Ok, went through everything we changed to add more "por favor" when the english copy has it.

iwiznia

Thanks!!

MelvinBot · 2023-04-13T14:34:56Z

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

iwiznia · 2023-04-13T14:35:17Z

Not emergency, but just copy changes, so I did not do the reviewer checklist

OSBotify · 2023-04-13T14:42:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

parasharrajat · 2023-04-13T19:43:24Z

src/pages/signin/ChangeExpensifyLoginLink.js

+                {props.translate('loginForm.notYou', {user: Str.removeSMSDomain(props.credentials.login)})}
            </Text>
        )}
+        &nbsp;


This is causing crashes on the Android. Gonna send a PR. Creating problems in testing.

Fix is live #17412

OSBotify · 2023-04-18T06:10:27Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-19T17:23:36Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix spanish copy in a few places

09939f4

pecanoro self-assigned this Apr 11, 2023

pecanoro added 2 commits April 11, 2023 20:34

Fix copy mistakes

4255899

More copy mistakes

b71e119

pecanoro requested a review from iwiznia April 12, 2023 00:49

pecanoro marked this pull request as ready for review April 12, 2023 00:57

pecanoro requested a review from a team as a code owner April 12, 2023 00:57

melvin-bot bot requested review from Beamanator and thesahindia and removed request for a team April 12, 2023 00:58

pecanoro removed request for Beamanator and thesahindia April 12, 2023 00:58

iwiznia requested changes Apr 12, 2023

View reviewed changes

pecanoro added 2 commits April 12, 2023 12:27

Clean up translation

51f583d

Change even more copy

cb954b6

iwiznia reviewed Apr 12, 2023

View reviewed changes

pecanoro added 2 commits April 12, 2023 21:01

A lot of por favor

640ce6e

Add more por favors

9810fd5

iwiznia approved these changes Apr 13, 2023

View reviewed changes

iwiznia merged commit 6e6adb0 into main Apr 13, 2023

iwiznia deleted the rocio-NotLogin branch April 13, 2023 14:34

melvin-bot bot added the Emergency label Apr 13, 2023

iwiznia removed the Emergency label Apr 13, 2023

parasharrajat reviewed Apr 13, 2023

View reviewed changes

OSBotify mentioned this pull request Apr 17, 2023

Deploy Checklist: New Expensify 2023-04-17 #17546

Closed

53 tasks

MelvinBot mentioned this pull request Apr 19, 2023

[HOLD for payment 2023-04-26] Login - Phrases translated to Spanish with poor translation #17184

Closed

6 tasks

Fix Spanish copy in a few places #17302

Fix Spanish copy in a few places #17302

Uh oh!

Conversation

pecanoro commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests / QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 12, 2023

Uh oh!

pecanoro commented Apr 12, 2023

Uh oh!

Uh oh!

iwiznia Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

pecanoro Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

pecanoro commented Apr 12, 2023

Uh oh!

Uh oh!

Uh oh!

iwiznia Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

pecanoro Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

pecanoro commented Apr 13, 2023

Uh oh!

iwiznia left a comment

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Apr 13, 2023

Uh oh!

iwiznia commented Apr 13, 2023

Uh oh!

OSBotify commented Apr 13, 2023

Uh oh!

parasharrajat Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 18, 2023

Uh oh!

OSBotify commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pecanoro commented Apr 11, 2023 •

edited

Loading

parasharrajat Apr 13, 2023 •

edited

Loading