-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Re-titled one of the playbooks #17406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-04-14.at.12.19.42.PM.movMobile Web - ChromeScreen.Recording.2023-04-14.at.12.27.46.PM.movMobile Web - SafariScreen.Recording.2023-04-14.at.12.24.50.PM.movDesktopNA iOSNA AndroidNA |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@deetergp is this prod QA? |
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.1-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.1-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀
|
Details
We needed to change the title of one of the playbooks to match the recently updated content.
cc @zsgreenwald
Fixed Issues
$ N/A
Tests/QA/Offline
Expensify Playbook for Small to Medium-Sized Businessesand click on it.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android