fix: use placeholder on the search input #18251
Conversation
melvin-bot
bot
requested review from
AndrewGable and
Santhosh-Sellavel
and removed request for
a team
|
@Santhosh-Sellavel @AndrewGable One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWeb
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
|
|
Assigning @parasharrajat here since we are treating this as a regression and un-assigning @Santhosh-Sellavel : ) |
PauloGasparSv
requested review from
parasharrajat
and removed request for
Santhosh-Sellavel
|
I disagree that this is a regression from the original PR. We solved all the components that were using the Options List in the original PR. This is completely unrelated. If we needed to change all the instances in the app that should have been clarified on the original issue/PR. But I am happy to review it. |
|
So we can do a full audit of the App on this issue and find other places which need to be updated as well and make those changes in this PR. What do you say @PauloGasparSv? |
I think we should treat it as a regression because the original issue's intent and title was to fix "Placeholder padding inconsistent among different fields" and this P.R. fixes that for a field we could have included there, but I agree there is room for discussion : ) (also the original issue didn't specify which fields we should update).
We discussed that in slack here, do you mind adding to that discussion? cc @sakluger because yesterday we discussed if this should be treated as a regression |
|
I can bump the Slack thread for regression chat. I am not convinced that this is a regression. That title does not clarify either what needs to be updated. Based on the issue description only the Search page was mentioned and we updated a lot of other pages which were similar to the search so IMO that task was done. Even if this and other inputs need to be updated, it should be communicated otherwise there is no way for us to know what needs to be changed in UI as UI is always fixed/confirmed in each PR and the expectation is that it is correct after each PR merge. That issue was not a bug but a feature request. Apart from it, @PauloGasparSv Do you think we should do an audit of the App before we merge this PR? Or we should only fix the issue and close the PR. |
Makes sense @parasharrajat! Do you mind if we wait on @sakluger input on this before we deciding anything or start a thread?
IMO we should just fix and close this : ) |
Screenshots🔲 iOS / native
🔲 iOS / Safari
🔲 MacOS / Desktop
🔲 Android / native
|
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
cc: @PauloGasparSv
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Sorry for the delay! I agree with @PauloGasparSv that we should just fix this one field for now. |
|
I also agree with @PauloGasparSv that we should treat as a regression based on the original issue's intent to fix inconsistent padding across multiple fields. |
|
I am happy to fix this as part of the original PR but not as a regression. It is not something that got broken by the original PR or prevented anyone from using the App. It can be said that it was left out but not a regression. Also, the scope was not clear. I perceived that we have to fix all the search fields based on the discussion #17873 (comment). I think it comes to the triage team to clear the expected behavior. For regressions, we lose payments. So I still disagree and can't simply accept this as a regression. At last, whatever works best for the project. |
|
🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.12-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀
|
|
🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.12-0 🚀
|
6 participants
Details
This PR edits the
TextInputon theInvite Memberspage, such that it useslabelinstead ofplaceholder.Fixed Issues
$ #18158
PROPOSAL: #17873 (comment)
Tests
Find a memberinput has a label style similar to the one on other pages ieSearch pageOffline tests
N/A
QA Steps
Find a memberinput has a label style similar to the one on other pages ieSearch pagePR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android