[MoneyRequestConfirmation] add hover style to fields on the money confirmation modal #18347

Prince-Mendiratta · 2023-05-03T16:31:30Z

Details

With this PR, we are enabling the hover effect for the Description and Amount fields on the MoneyRequestConfirmationList component.

Fixed Issues

$ #17635
PROPOSAL: #17635 (comment)

Tests

Login to ND.
Click on the FAB menu.
Select Send Money. Choose any amount. Choose any user.
Hover on the Description and Amount fields and ensure that the hover effect is shown.
Go back to home screen. Click on the FAB menu.
Select Split Bill. Enter any amount. Choose more than 3 users.
Hover on the Description and Amount fields and ensure that the hover effect is shown properly.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

android-mWeb.mp4

Mobile Web - Safari

iOS-mWeb.mp4

Desktop

desktop.mp4

iOS

iOS.mp4

Android

android.mp4

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

MelvinBot · 2023-05-03T16:31:37Z

@marcochavezf @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Prince-Mendiratta · 2023-05-03T16:32:23Z

Deferring adding the recordings for all platforms until we reach the final design.

Added the recording for Web for quick reference for @shawnborton and @aimane-chnaif before review.

aimane-chnaif · 2023-05-03T16:42:13Z

Field itself looks good but not when combined with button since no space between them.
@shawnborton do you have feedback on this?

Prince-Mendiratta · 2023-05-03T16:45:25Z

@aimane-chnaif agreed, would like to have the both the top and bottom margin finalised since right now the top margin is 8px, which might look weird in the video.

shawnborton · 2023-05-03T16:45:51Z

I think that's probably fine as-is

shawnborton · 2023-05-03T16:46:04Z

We could add some bottom margin under that field though, even just like 4-8px

Prince-Mendiratta · 2023-05-03T16:50:56Z

@shawnborton How's this?
Vertical padding: 12px,
Horizontal padding: 20px,
Vertical margin: 8px.

Leads to a separation of 12px between the two fields where the hover effect is not shown. Is this good or does no gap between the fields look better?

2023-05-03.22-19-19.mp4

shawnborton · 2023-05-03T16:52:23Z

I don't think Amount and Description should have a gap between them though, they can be "touching"

Prince-Mendiratta · 2023-05-03T16:54:38Z

Great, this should be good then?

2023-05-03.22-23-53.mp4

shawnborton · 2023-05-03T17:08:05Z

Yup that works for me, thanks!

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

aimane-chnaif · 2023-05-03T17:11:15Z

src/components/OptionsSelector/BaseOptionsSelector.js

                                        {optionsList}
                                    </View>
-                                    <View style={[styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0]}>
+                                    <View style={this.props.shouldUseStyleForChildren && [styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0]}>


it's not recommended to pass boolean value to style. let's use ternary operator

@aimane-chnaif updated

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

aimane-chnaif · 2023-05-04T06:44:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

https://github.com/Expensify/App/pull/18347/files#diff-a9bb6f5b7c223e3c0a5f49b1a55692c74a63287a411527bbac37cabd95b2ffe2R344

Please apply same change here, though it's not used anywhere yet.

-                                   <View style={[styles.ph5, styles.pb3]}>
+                                   <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pb3] : []}>

aimane-chnaif · 2023-05-04T06:53:27Z

src/components/OptionsSelector/BaseOptionsSelector.js

                                        {optionsList}
                                    </View>
-                                    <View style={[styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0]}>
+                                    <View style={this.props.shouldUseStyleForChildren ? [styles.ph5, styles.pv5, styles.flexGrow1, styles.flexShrink0] : []}>


Let's make sure that styles.flexGrow1, styles.flexShrink0 removal doesn't cause any regressions, though I tested and confirmed.

@aimane-chnaif Yes, I tested again and can confirm, doesn't look prone to any regressions.

I tried resizing the window on desktop and web and the existence / lack thereof flex styles does not affect the position or behaviour.

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-05-04T14:03:17Z

Added recordings for all platforms in the OP.

aimane-chnaif

LGTM 🎉
@marcochavezf all yours!

marcochavezf

Thanks guys! LGTM

OSBotify · 2023-05-04T17:03:23Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.10-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:05:28Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

feat: add hover style to money request modal

612eadc

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta requested a review from a team as a code owner May 3, 2023 16:31

melvin-bot bot requested review from aimane-chnaif and marcochavezf and removed request for a team May 3, 2023 16:31

Prince-Mendiratta mentioned this pull request May 3, 2023

[HOLD for payment 2023-05-16] [$1000] No hover effect on Amount and Description fields on new send money page #17635

Closed

6 tasks

feat: add extra margins

6028d82

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

aimane-chnaif reviewed May 3, 2023

View reviewed changes

fix: use ternary operators

74e2084

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

aimane-chnaif reviewed May 4, 2023

View reviewed changes

fix: use prop for both scenarios

cf8fa02

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

aimane-chnaif approved these changes May 4, 2023

View reviewed changes

marcochavezf approved these changes May 4, 2023

View reviewed changes

marcochavezf merged commit f14be7b into Expensify:main May 4, 2023

OSBotify mentioned this pull request May 4, 2023

Deploy Checklist: New Expensify 2023-05-04 #18411

Closed

32 tasks

aimane-chnaif mentioned this pull request May 18, 2023

Add Push-to-Page support for IOUConfirmationList #16919

Merged

54 tasks

[MoneyRequestConfirmation] add hover style to fields on the money confirmation modal #18347

[MoneyRequestConfirmation] add hover style to fields on the money confirmation modal #18347

Uh oh!

Conversation

Prince-Mendiratta commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 3, 2023

Uh oh!

Prince-Mendiratta commented May 3, 2023

Uh oh!

aimane-chnaif commented May 3, 2023

Uh oh!

Prince-Mendiratta commented May 3, 2023

Uh oh!

shawnborton commented May 3, 2023

Uh oh!

shawnborton commented May 3, 2023

Uh oh!

Prince-Mendiratta commented May 3, 2023

Uh oh!

shawnborton commented May 3, 2023

Uh oh!

Prince-Mendiratta commented May 3, 2023

Uh oh!

shawnborton commented May 3, 2023

Uh oh!

aimane-chnaif May 3, 2023

Choose a reason for hiding this comment

Uh oh!

Prince-Mendiratta May 3, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented May 4, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif May 4, 2023

Choose a reason for hiding this comment

Uh oh!

Prince-Mendiratta May 4, 2023

Choose a reason for hiding this comment

Uh oh!

Prince-Mendiratta commented May 4, 2023

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 4, 2023

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Prince-Mendiratta commented May 3, 2023 •

edited

Loading