Use goBack so that the `<` works for threads and other chats #18350

stitesExpensify · 2023-05-03T16:40:16Z

Details

Fixed Issues

$ #18756
PROPOSAL: N/A

Tests

Open a chat from the main LHN screen
(For web/desktop shrink the width of the window) you need to Click the back button and make sure it works

Mobile web / computer web only:

Change the URL to a report you don't have access to
(For web shrink the width of the window) Click the back button and make sure it works

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Open a chat from the main LHN screen
(For web/desktop shrink the width of the window until the back button appears) you need to Click the back button and make sure it works

Mobile web / computer web only:

Change the URL to a report you don't have access to
(For web shrink the width of the window until the back button appears) Click the back button and make sure it works

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

n/a

Mobile Web - Chrome

2023-05-03_10-31-58.mp4

Mobile Web - Safari

2023-05-03_10-29-19.mp4

Desktop

n/a

iOS

2023-05-03_10-27-35.mp4

Android

2023-05-03_10-39-55.mp4

MelvinBot · 2023-05-03T16:40:51Z

@eVoloshchak @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

PauloGasparSv · 2023-05-03T17:29:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

Screen.Recording.2023-05-11.at.15.27.36.mov

Mobile Web - Safari

Screen.Recording.2023-05-11.at.15.31.19.mov

Desktop

N/A

iOS

Screen.Recording.2023-05-11.at.15.45.22.mov

Android

Screen.Recording.2023-05-11.at.15.38.52.mov

grgia · 2023-05-10T16:03:40Z

@PauloGasparSv fixed merge conflicts

PauloGasparSv · 2023-05-10T20:52:19Z

Re-running failed "Jest Unit Tests / test" travis tests

stitesExpensify · 2023-05-10T22:25:11Z

@eVoloshchak can you give this a quick review with tests please?

eVoloshchak · 2023-05-11T11:11:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-11.at.14.32.34.mov

Mobile Web - Chrome

Screen_Recording_20230511-144411_Chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-05-11.at.14.35.09.mov

Desktop

Screen.Recording.2023-05-11.at.14.27.05.mov

iOS

Screen.Recording.2023-05-11.at.14.38.21.mov

Android

Screen_Recording_20230511-144106_New.Expensify.mp4

eVoloshchak · 2023-05-11T11:58:58Z

Mobile only, there is no back button on web/desktop

There is a back button, you just have to shrink window width below 800

stitesExpensify · 2023-05-11T15:51:42Z

Updated QA. @eVoloshchak did it test well for you?

PauloGasparSv

LGTM, re-tested and updated evidences

eVoloshchak

Tests well!

melvin-bot · 2023-05-11T18:48:24Z

🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #18790.

PauloGasparSv · 2023-05-11T18:50:39Z

Forgot to check the very last item here, now checked.

Merging this since latest commits are from @grgia!

OSBotify · 2023-05-11T18:57:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-15T09:20:23Z

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-17T00:20:13Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-07-08T00:57:50Z

src/pages/home/ReportScreen.js

-                                            onNavigationMenuButtonClicked={() => Navigation.navigate(ROUTES.HOME)}
+                                            onNavigationMenuButtonClicked={Navigation.goBack}


This caused a regression #20370. After viewing many reports (that are not threaded nor linked to each other i.e. any random reports from LHN) then we click the < button on the last report (and only on the last report), we will navigate back to the previous report instead of LHN. This is kinda an edge case I think.

Use goBack so that this works for threads and other chats

2e9e1cd

stitesExpensify self-assigned this May 3, 2023

stitesExpensify requested a review from a team as a code owner May 3, 2023 16:40

melvin-bot bot requested review from PauloGasparSv and eVoloshchak and removed request for a team May 3, 2023 16:40

PauloGasparSv previously approved these changes May 3, 2023

View reviewed changes

stitesExpensify requested a review from chiragsalian May 4, 2023 02:18

grgia assigned grgia and unassigned grgia May 4, 2023

grgia self-requested a review May 4, 2023 10:17

Merge branch 'main' into stites-updateBackFunctionality

09860f1

grgia dismissed PauloGasparSv’s stale review via 09860f1 May 10, 2023 16:03

grgia previously approved these changes May 10, 2023

View reviewed changes

prettier

8d8e7ff

grgia dismissed their stale review via 8d8e7ff May 10, 2023 16:15

PauloGasparSv approved these changes May 11, 2023

View reviewed changes

eVoloshchak approved these changes May 11, 2023

View reviewed changes

melvin-bot bot mentioned this pull request May 11, 2023

[Awaiting Payment 24th May] Payment issue for E/App PR#18350 #18790

Closed

PauloGasparSv merged commit 4d23e82 into main May 11, 2023

PauloGasparSv deleted the stites-updateBackFunctionality branch May 11, 2023 18:51

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-23] Updating what the < button does for thread report headers #18756

Closed

s77rt reviewed Jul 8, 2023

View reviewed changes

s77rt mentioned this pull request Jul 8, 2023

[HOLD for payment 2023-07-14] Up button does not redirect to LHN when other chats are opened previously and window was resized to mobile #20370

Closed

6 tasks

		onNavigationMenuButtonClicked={() => Navigation.navigate(ROUTES.HOME)}
		onNavigationMenuButtonClicked={Navigation.goBack}

Use goBack so that the < works for threads and other chats #18350

Use goBack so that the < works for threads and other chats #18350

Uh oh!

Conversation

stitesExpensify commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 3, 2023

Uh oh!

PauloGasparSv commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

grgia commented May 10, 2023

Uh oh!

PauloGasparSv commented May 10, 2023

Uh oh!

stitesExpensify commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stitesExpensify commented May 11, 2023

Uh oh!

PauloGasparSv left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 11, 2023

Uh oh!

PauloGasparSv commented May 11, 2023

Uh oh!

OSBotify commented May 11, 2023

Uh oh!

OSBotify commented May 15, 2023

Uh oh!

OSBotify commented May 17, 2023

Uh oh!

s77rt Jul 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Use goBack so that the `<` works for threads and other chats #18350

Use goBack so that the `<` works for threads and other chats #18350

stitesExpensify commented May 3, 2023 •

edited

Loading

PauloGasparSv commented May 3, 2023 •

edited

Loading

stitesExpensify commented May 10, 2023 •

edited

Loading

eVoloshchak commented May 11, 2023 •

edited

Loading

eVoloshchak commented May 11, 2023 •

edited

Loading

s77rt Jul 8, 2023 •

edited

Loading