Fix: Failed IOU requests are still deletable

[tienifr]

Details

Failed IOU requests are still deletable. This PR fixes that.

Fixed Issues

$ #16748
PROPOSAL: #16748 (comment)

Tests

1. Login with any account
2. Click profile avatar >> Preferences
3. Turn on Simulate failing network requests
4. Close Settings modal
5. Open any chat
6. Click on Actions icon (plus icon) >> Request Money
7. Enter an arbitrary amount then Request
8. Click profile avatar >> Preferences
9. Turn off Simulate failing network requests
10. Verify that an error message appears below the IOU report
11. Click on the IOU report
12. Verify that the error IOU report is not deletable (i.e. does not show Delete button)

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Login with any account
2. Click profile avatar >> Preferences
3. Turn on Simulate failing network requests
4. Close Settings modal
5. Open any chat
6. Click on Actions icon (plus icon) >> Request Money
7. Enter an arbitrary amount then Request
8. Click profile avatar >> Preferences
9. Turn off Simulate failing network requests
10. Verify that an error message appears below the IOU report
11. Click on the IOU report
12. Verify that the error IOU report is not deletable (i.e. does not show Delete button)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@roryabraham @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[tienifr]

Currently I couldn't reproduce the bug after #18237 was merged. Simulate failing network requests no longer works here.

About the PR

Basically this PRs will throw a HttpError when server responds with 400 code. However, this change will block all the middlewares including SaveResponseInOnyx which merges failureData of the IOU request in Onyx. Thus, the error message (shown when there's failureData) won't be shown.

Flow

1. As long as we turn off Simulate failing network requests, the server will respond with 400 json code:

2. The HttpUtils will throw an error:

App/src/libs/HttpUtils.js

Lines 91 to 97 in 22b971d

	if (response.jsonCode === CONST.JSON_CODE.BAD_REQUEST && response.message === CONST.ERROR_TITLE.DUPLICATE_RECORD) {
	throw new HttpsError({
	message: CONST.ERROR.DUPLICATE_RECORD,
	status: CONST.JSON_CODE.BAD_REQUEST,
	title: CONST.ERROR_TITLE.DUPLICATE_RECORD,
	});
	}

3. This will block all the afterward middle-wares including SaveResponseInOnyx, which prevent failureData update in Onyx.
4. Thus the error message wouldn't be shown on the UI.

In conclusion, I think we need to find other test cases to simulate a failed IOU request as Simulate failing network requests no longer works here.

[tienifr]

@roryabraham @0xmiroslav friendly bump

[0xmiroslav]

reviewing now

@tienifr please pull main

[tienifr]

Done!

[0xmiroslav]

Now the behavior completely changed. Instead of opening IOU details modal, switch to money request chat. And Delete button is in 3 dots menu at the top right.
I am not sure this PR is worthy anymore.

And latest main is very buggy. Money request report is created endlessly whenever click IOU preview

Screen.Recording.2023-05-16.at.6.55.52.AM.mov