Fix currency selection is saved even though we don't press Save yet #18995

bernhardoj · 2023-05-16T08:19:02Z

Details

When we select a currency from the currency list selection, it will immediately saved it to the onyx. We want to change it so the currency is only saved when the user press Save.

Fixed Issues

$ #18667
PROPOSAL: #18667 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Press the global + (FAB) button
Choose Send Money
Enter any amount and press Next
Select any participant
Press Amount to edit the amount
Press the currency to go to the currency selection page
Choose any currency that is different from the current currency
Press the arrow back (Go back)
Verify the currency shown in Amount is not changed
Repeat step 6-7
Now, press Save
Verify the currency shown in Amount is changed with the new selected currency

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-05-16.at.15.02.34.mov

Mobile Web - Chrome

WhatsApp.Video.2023-05-16.at.15.27.42.mp4

Mobile Web - Safari

Screen.Recording.2023-05-16.at.15.10.33.mov

Desktop

Screen.Recording.2023-05-16.at.15.04.08.mov

iOS

Screen.Recording.2023-05-16.at.15.11.24.mov

Android

Screen.Recording.2023-05-16.at.15.11.24.mov

…he previous page instead

melvin-bot · 2023-05-16T08:19:08Z

@arosiclair @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-05-16T09:10:13Z

Sorry for taking it long. I was trying to make sure to cover edge cases.

Accessing the currency list without backTo params
A user can directly access the url of currency list (/send/new/currency) without passing the backTo params. To prevent any error, we just navigate them back if backTo is empty when the user select any currency.
Refreshing the page while at the currency list page
We have an open issue that is caused by this action in the year picker page here [HOLD for payment 2023-06-01] [$1000] On reload on date year search page, date search selection breaks #18815. Here is the issue:

When we refresh the page, the navigation stack history will be lost. So, when we go to the currency list, we have this stack:
Home -> MoneyRequestModal -> IOU currency list

If we refresh the page, the stack becomes
Home -> IOU currency list

When we select a currency, instead of going back, it will push the MoneyRequestModal to the stack. However, focus listener won't get called on component mount. This will messed up the selection as can be seen from the mentioned issue above. The solution from the selected proposal on that issue is to also get the selected option on component mount. However, the solution raise another issue for our case (explanation below). So, to (maybe temporarily) solve this, we check if IOU currency is the only route on the stack, we just go back, the same thing we did with the 1st case above.

I will show first the video of the issue if we get the selected currency on component mount too.

Screen.Recording.2023-05-16.at.16.41.55.mov

Notice that the currency looks like it is "saved" in the amount page. How can that happen?

First, we open the send money page. It will show the initial amount step. Then we go all the way to the confirmation step. Notice that the url path does not change because the money request step is all in one screen/page (MoneyRequestModal).
Then, we open the iou currency list (a separate screen/page). The backTo params value will be /send/new
When we pick a currency (let say USD), we will go back to /send/new with a new params, currency. So, the new path is /send/new/?currency=USD even though the params is not shown on the url. (full url now new.expensify.com/send/new/?currency=USD)
Now, we go back from the amount step to the confirmation step. Then, we go again to the edit amount step. When the edit amount step mount, it will get the currency from the current url params which is USD. This makes the edit amount have the previous selected currency.

This can happen because all money request step is in the same screen/page. The selected currency from IOU currency list is "shared" to all steps. One way we can solve this is to separate each step to each stack screen, so all of them has their own path. I have an open PR for that, but currently we are waiting for some confirmation before continuing it.

Let me know if there is anything confusing 😄.

src/ROUTES.js

bernhardoj · 2023-05-17T03:45:16Z

Hmm, the lint failed because there is a prettier dif, so I run npm run prettier but nothing changes. 😕

bernhardoj · 2023-05-17T05:05:35Z

prettier diff comes from this PR #18865

src/pages/iou/IOUCurrencySelection.js

arosiclair

Looks good thanks for the changes

Santhosh-Sellavel · 2023-05-18T20:28:51Z

@bernhardoj App gets crashed while trying to open Currency selection page

Screen.Recording.2023-05-19.at.1.57.30.AM.mov

cc: @arosiclair

Santhosh-Sellavel · 2023-05-18T20:34:41Z

src/pages/iou/IOUCurrencySelection.js

        return _.map(this.props.currencyList, (currencyInfo, currencyCode) => {
-            const isSelectedCurrency = currencyCode === this.props.iou.selectedCurrencyCode;
+            const isSelectedCurrency = currencyCode === this.state.selectedCurrencyCode;


The crash occurs here. This methodgetCurrencyOptions is called while initializing the state and trying to access the state.selectedCurrencyCode while it's not defined

Ah, my bad. I didn't retest after moving the selected currency code to a state. So, I guess we have 2 options:

Take it out from the state and just put it back in a static variable

Update getCurrencyOptions to accept selectedCurrencyCode.

I personally prefer the first one as it's a static value. What do you think? @Santhosh-Sellavel @arosiclair

After looking closer I think we should replace selectedCurrencyCode with a getSelectedCurrencyCode function instead. We can use that function in getCurrencyOptions() and render(). That should fix this while keeping everything reactive to prop changes.

That's a nice idea. Updated and test well. Thanks for the help!

Santhosh-Sellavel · 2023-05-19T19:53:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-05-20.at.1.13.11.AM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-05-20.at.1.07.18.AM.mov

iOS & Android

Screen.Recording.2023-05-20.at.1.11.27.AM.mov

Santhosh-Sellavel

LGTM tests well!

All yours @arosiclair

OSBotify · 2023-05-19T22:55:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:50:33Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T00:22:25Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2023-06-06T16:57:31Z

Came across this PR and had some general feedback. I have some doubts about passing the currency in the route params with the "backTo". And wonder if it's the best way to achieve what we are trying to do. Another way this could work is something like:

Create a unique page for each case where we need to save the currency selection with the logic to save the currency
No need to pass the currency or activeRoute around to create a link between the pages. Whatever needs it can get it from the props of the data that we are changing when we call a "save" function.

I'm not too sure what would go into setting things up to work that way and there are probably even better solutions - just something to think about!

bernhardoj added 2 commits May 16, 2023 15:58

don't save currency from the selection immediately and return it to t…

f79a800

…he previous page instead

add comment

97a5b38

bernhardoj requested a review from a team as a code owner May 16, 2023 08:19

melvin-bot bot requested review from Santhosh-Sellavel and arosiclair and removed request for a team May 16, 2023 08:19

Santhosh-Sellavel reviewed May 17, 2023

View reviewed changes

src/ROUTES.js Outdated Show resolved Hide resolved

simplify param name

53f0065

arosiclair requested changes May 17, 2023

View reviewed changes

src/pages/iou/IOUCurrencySelection.js Show resolved Hide resolved

src/pages/iou/IOUCurrencySelection.js Outdated Show resolved Hide resolved

bernhardoj added 3 commits May 18, 2023 12:28

Merge branch 'main' into fix/18667-return-selected-currency

300eb8e

add comment and convert var to a state

ebf7398

fix lint

cfe8b76

arosiclair previously approved these changes May 18, 2023

View reviewed changes

Santhosh-Sellavel suggested changes May 18, 2023

View reviewed changes

bernhardoj added 2 commits May 20, 2023 00:18

Merge branch 'main' into fix/18667-return-selected-currency

5f5711f

move selected currency from state to a function

af78a3e

bernhardoj dismissed arosiclair’s stale review via af78a3e May 19, 2023 16:24

Santhosh-Sellavel approved these changes May 19, 2023

View reviewed changes

arosiclair approved these changes May 19, 2023

View reviewed changes

arosiclair merged commit 84ef813 into Expensify:main May 19, 2023

bernhardoj mentioned this pull request May 21, 2023

Refactor iou page by separating each step as individual screen #17964

Merged

56 tasks

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

melvin-bot bot mentioned this pull request May 25, 2023

[HOLD for payment 2023-06-01] [$1000] The currency is updated even without clicking the save button #18667

Closed

6 tasks

Fix currency selection is saved even though we don't press Save yet #18995

Fix currency selection is saved even though we don't press Save yet #18995

Uh oh!

Conversation

bernhardoj commented May 16, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 16, 2023

Uh oh!

bernhardoj commented May 16, 2023

Uh oh!

Uh oh!

bernhardoj commented May 17, 2023

Uh oh!

bernhardoj commented May 17, 2023

Uh oh!

Uh oh!

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented May 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel May 18, 2023

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 19, 2023

Choose a reason for hiding this comment

Uh oh!

arosiclair May 19, 2023

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 19, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented May 19, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 19, 2023

Uh oh!

OSBotify commented May 22, 2023

Uh oh!

OSBotify commented May 25, 2023

Uh oh!

marcaaron commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Santhosh-Sellavel commented May 18, 2023 •

edited

Loading

marcaaron commented Jun 6, 2023 •

edited

Loading