Add ability for admins to restrict who can post within rooms #19094

amyevans · 2023-05-17T01:53:46Z

Details

Adds the ability for admins to restrict who can post within rooms

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/282865

Tests

Test 1: #announce room as policy admin and setting is “admins”

on a report in a policy where you are an admin, open the report settings page
open the “Who can post” page
change the setting to “Admins only”
verify you can still comment in the report

Test 2: #announce room as policy user and setting is “admins”

as a member (not admin) of the above report, open the report settings page
verify you see a read-only value for “Who can post”
verify you cannot comment in the report

Test 3: #announce room as policy user and setting is “all”

as the admin, change the "Who can post" setting back to "All members"
as a member, verify you can now comment in the report

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb-chrome.mov

Mobile Web - Safari

mweb-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-05-17T01:54:17Z

@parasharrajat @tgolen One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator

Code is looking great! I'm not "approving" because i've done 0 testing, but just wanted to add a few very small comments for now 👍

src/CONST.js

src/libs/ReportUtils.js

src/pages/reportPropTypes.js

src/libs/ReportUtils.js

tgolen · 2023-05-17T16:10:21Z

src/pages/ReportSettingsPage.js

                                </OfflineWithFeedback>
                            </View>
                        )}
+                        <View>


Is the nested View necessary?

It's not needed, I'll remove it. Thanks!

src/pages/ReportSettingsPage.js

src/pages/home/report/ReportFooter.js

src/libs/ReportUtils.js

parasharrajat · 2023-05-17T17:02:28Z

src/libs/ReportUtils.js

+
+    // If we've made it here, commenting on this report is restricted
+    // If the user is an admin, allow them to post
+    if (lodashGet(policy, 'role', '') === CONST.POLICY.ROLE.ADMIN) {


Suggested change

if (lodashGet(policy, 'role', '') === CONST.POLICY.ROLE.ADMIN) {

if (policy.role === CONST.POLICY.ROLE.ADMIN) {

policy is required.

Hmm, public rooms is a case where policy would be null because a user is opening a link to a report without having access to the policy

github-actions · 2023-05-17T18:52:21Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

amyevans · 2023-05-17T18:54:27Z

Code updated per review comments and screenshots added. I also added the CP Staging label per Slack. Still on HOLD for merging though until the Web-E PR is merged/deployed.

amyevans · 2023-05-18T01:01:56Z

The Web-E PR was cherry picked. Buuuut looks like #16910 got merged today which removes the ReportSettingsPage so I guess I need to refactor this :lolsob:

parasharrajat · 2023-05-23T08:02:55Z

Testing in few minutes.

parasharrajat · 2023-05-23T15:06:47Z

Finishing up the checklist

parasharrajat · 2023-05-23T15:54:45Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-05-23.at.9.26.36.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-05-23.at.9.27.57.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-05-23.at.9.30.17.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-05-23.at.9.25.19.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-05-23.at.9.33.33.PM.mov

🔲 Android / native

Screen.Recording.2023-05-23.at.9.34.35.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @Beamanator

🎀 👀 🎀 C+ reviewed

Dismissing stale review as concerns were addressed!

Add ability for admins to restrict who can post within rooms (cherry picked from commit 4c3cea5)

…-19094 🍒 Cherry pick PR #19094 to staging 🍒

parasharrajat · 2023-05-23T18:16:22Z

An issue should have been created for C+ payment but it didn't. Can someone help with that? Thanks.

OSBotify · 2023-05-23T18:21:43Z

🚀 Cherry-picked to staging by https://github.com/amyevans in version: 1.3.17-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-25T00:21:25Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:27:45Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:45:34Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sobitneupane · 2023-07-24T14:25:47Z

This case was missed while adding the functionality to allow admins to restrict who can post within rooms.

Issue: #21418
Title: 'All members' option shown on #admins channel

parasharrajat · 2023-08-09T08:40:51Z

Another edge case was missed where we should clear the draft icon on LHN when a user is no more allowed to comment. #21835

situchan · 2023-08-13T17:48:22Z

[HOLD for payment 2023-08-16] [$1000] Web - No margin between composer box and whisper message #23722

Another edge case was missed where we should re-render ReportActionsView when permission is changed dynamically.
Why should re-render?
ReportActionsView has ReportActionsList as children where its style changes based on composer visibility:

App/src/pages/home/report/ReportActionsList.js

Line 164 in a03a21d

    
           <Animated.View style={[animatedStyles, styles.flex1, !shouldShowReportRecipientLocalTime && !hideComposer ? styles.pb4 : {}]}>

rayane-d · 2025-02-16T22:35:12Z

FYI, Another edge case was missed:

[Due for payment 2025-02-18] [$250] All members should be able to post in the workspace chat and Who can post option should not have Admins only #55820

amyevans added 7 commits May 16, 2023 08:08

Scaffold field for restricting commenting capabilities

48f0ad2

Call API to update write capability setting

8e0a27f

Use CONST values for capability options

18d7341

Add spanish translations

4db2308

Hide composer if user is not allowed to post

ab2075d

Restrict editing of the field to admins

45ca540

Show the setting as view-only for non-admins

3766b5a

amyevans self-assigned this May 17, 2023

amyevans requested a review from a team as a code owner May 17, 2023 01:53

melvin-bot bot requested review from parasharrajat and tgolen and removed request for a team May 17, 2023 01:54

amyevans added 3 commits May 16, 2023 23:04

Merge branch 'main' into amy-admins-only

94d450a

Remove task related check

eaa3b93

Fix prettier style

daf53e3

Beamanator reviewed May 17, 2023

View reviewed changes

src/CONST.js Show resolved Hide resolved

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/pages/reportPropTypes.js Show resolved Hide resolved

tgolen requested changes May 17, 2023

View reviewed changes

parasharrajat suggested changes May 17, 2023

View reviewed changes

amyevans added 2 commits May 17, 2023 10:41

Address PR feedback

5cebc09

Additional improvements per PR reviews

c9d1631

amyevans added the CP Staging label May 17, 2023

amyevans requested a review from tgolen May 17, 2023 18:54

tgolen previously approved these changes May 17, 2023

View reviewed changes

amyevans changed the title ~~[Hold Web-E 37464] Add ability for admins to restrict who can post within rooms~~ Add ability for admins to restrict who can post within rooms May 18, 2023

amyevans added 2 commits May 17, 2023 21:19

Merge branch 'main' into amy-admins-only

33f9ce2

Refactor to push to page (WIP)

c146e0f

amyevans requested a review from parasharrajat May 23, 2023 02:06

tgolen approved these changes May 23, 2023

View reviewed changes

parasharrajat approved these changes May 23, 2023

View reviewed changes

amyevans merged commit 4c3cea5 into main May 23, 2023

amyevans deleted the amy-admins-only branch May 23, 2023 16:59

OSBotify pushed a commit that referenced this pull request May 23, 2023

Merge pull request #19094 from Expensify/amy-admins-only

e1f98d4

Add ability for admins to restrict who can post within rooms (cherry picked from commit 4c3cea5)

OSBotify mentioned this pull request May 23, 2023

🍒 Cherry pick PR #19094 to staging 🍒 #19466

Merged

OSBotify added a commit that referenced this pull request May 23, 2023

Merge pull request #19466 from Expensify/OSBotify-cherry-pick-staging…

f6e07d9

…-19094 🍒 Cherry pick PR #19094 to staging 🍒

OSBotify mentioned this pull request May 23, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

amyevans mentioned this pull request May 23, 2023

Payment issue for E/App PR#19094 #19474

Closed

OSBotify mentioned this pull request May 25, 2023

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed

53 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

amyevans mentioned this pull request Jun 27, 2023

[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-03] [$1000] Polish admins-only policy room feature #21456

Closed

4 tasks

sobitneupane mentioned this pull request Jul 24, 2023

[HOLD for payment 2023-07-14] [$1000] 'All members' option shown on #admins channel #21418

Closed

6 tasks

parasharrajat mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-10] [$1000] Chat - Account B will have a pencil saved when only the admin can write in the announcement room #21835

Closed

6 tasks

situchan mentioned this pull request Aug 13, 2023

[HOLD for payment 2023-08-16] [$1000] Web - No margin between composer box and whisper message #23722

Closed

6 tasks

rayane-d mentioned this pull request Feb 16, 2025

[Due for payment 2025-02-18] [$250] All members should be able to post in the workspace chat and Who can post option should not have Admins only #55820

Closed

8 tasks

	if (lodashGet(policy, 'role', '') === CONST.POLICY.ROLE.ADMIN) {
	if (policy.role === CONST.POLICY.ROLE.ADMIN) {

Add ability for admins to restrict who can post within rooms #19094

Add ability for admins to restrict who can post within rooms #19094

Uh oh!

Conversation

amyevans commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 17, 2023

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgolen May 17, 2023

Choose a reason for hiding this comment

Uh oh!

amyevans May 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parasharrajat May 17, 2023

Choose a reason for hiding this comment

Uh oh!

amyevans May 17, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 17, 2023

Uh oh!

amyevans commented May 17, 2023

Uh oh!

amyevans commented May 18, 2023

Uh oh!

parasharrajat commented May 23, 2023

Uh oh!

parasharrajat commented May 23, 2023

Uh oh!

parasharrajat commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

parasharrajat commented May 23, 2023

Uh oh!

OSBotify commented May 23, 2023

Uh oh!

OSBotify commented May 25, 2023

Uh oh!

OSBotify commented Jun 15, 2023

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

sobitneupane commented Jul 24, 2023

Uh oh!

parasharrajat commented Aug 9, 2023

Uh oh!

situchan commented Aug 13, 2023

Uh oh!

rayane-d commented Feb 16, 2025

Uh oh!

amyevans commented May 17, 2023 •

edited

Loading

parasharrajat commented May 23, 2023 •

edited

Loading