fix: double click compose box and select placeholder by dukenv0307 · Pull Request #19096 · Expensify/App

dukenv0307 · 2023-05-17T03:55:32Z

Details

App displays normal pointer on some parts of compose box when not in focus and double click, it selects placeholder text

Fixed Issues

$ #18110
PROPOSAL: #18110 (comment)

Tests

Open the app
Open any report
Lose focus from compose box
Hover over compose box and observe that few area above and below 'Write something...' text displays normal pointer
Double click when normal pointer is visible and observe
Verify placeholder 'Write something...' is not highlighted

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Open any report
Lose focus from compose box
Hover over compose box and observe that few area above and below 'Write something...' text displays normal pointer
Double click when normal pointer is visible and observe
Verify placeholder 'Write something...' is not highlighted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.mp4

Mobile Web - Chrome

mb-chrome.mp4

Mobile Web - Safari

mb-safari.mp4

Desktop

Desktop.mp4

iOS

IOS.mp4

Android

Android.mp4

Screenshots/Videos #12669

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

IOS

Android

melvin-bot · 2023-05-17T11:06:36Z

@tgolen @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-05-17T11:12:36Z

src/styles/styles.js

            paddingHorizontal: variables.avatarChatSpacing,
-            paddingTop: 0,
-            paddingBottom: 0,
+            paddingTop: 5,


@dukenv0307 Your proposal mentioned that if the numberOfLines would be 1, the padding values should be 9. I don't see that change here, can you please explain?

I think that's covered in the textInputCompose style right above this? The styles will be used conditionally: this.props.numberOfLines > 1 ? styles.textInputComposeMultiLines : styles.textInputCompose,

I just updated

tgolen

Looking at the comment above the textInputCompose style, could you please be sure to update the PR description to run all the tests mentioned in #12669 ?

tgolen · 2023-05-17T16:29:13Z

src/styles/styles.js

            paddingHorizontal: variables.avatarChatSpacing,
-            paddingTop: 0,
-            paddingBottom: 0,
+            paddingTop: 5,


I think that's covered in the textInputCompose style right above this? The styles will be used conditionally: this.props.numberOfLines > 1 ? styles.textInputComposeMultiLines : styles.textInputCompose,

tgolen · 2023-05-17T16:31:47Z

src/styles/styles.js

+            // On Android, multiline TextInput with height: 'auto' will show extra padding unless they are configured with
+            // paddingVertical: 0, alignSelf: 'center', and textAlignVertical: 'center'


I'm not sure what to make of this. Why is this explanation here, but it doesn't really appear to do anything or be valuable.

mananjadhav

Thanks for addressing the changes @dukenv0307. I'll now starting testing.

mananjadhav · 2023-05-17T19:04:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-cursor.mov

Mobile Web - Chrome

mweb-chrome-cursor.mov

Mobile Web - Safari

mweb-safari-cursor.mov

Desktop

desktop-cursor.mov

iOS

ios-cursor.mov

Android

android-cursor.mov

Thanks for the quicl PR @dukenv0307. all yours @tgolen

OSBotify · 2023-05-17T19:45:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-18T07:38:30Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2023-05-22T15:06:50Z

@dukenv0307 This PR has caused a regression #19358

mountiny · 2023-05-22T18:33:11Z

Creating a revert for now

OSBotify · 2023-05-22T23:39:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T00:15:52Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T19:53:46Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T21:52:30Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: double click composo box and select placeholder

401d1e9

dukenv0307 marked this pull request as ready for review May 17, 2023 11:06

dukenv0307 requested a review from a team as a code owner May 17, 2023 11:06

melvin-bot bot requested review from mananjadhav and tgolen and removed request for a team May 17, 2023 11:06

mananjadhav reviewed May 17, 2023

View reviewed changes

dukenv0307 added 3 commits May 17, 2023 18:13

Merge branch main to fix lint

11e0672

fix: width compose input when multiple lines

12849ab

fix lint

7dd7d80

tgolen requested changes May 17, 2023

View reviewed changes

remove useless comment

eb5a67d

tgolen approved these changes May 17, 2023

View reviewed changes

mananjadhav approved these changes May 17, 2023

View reviewed changes

tgolen merged commit 1fcd04e into Expensify:main May 17, 2023

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-18 #19175

Closed

39 tasks

bernhardoj mentioned this pull request May 22, 2023

[HOLD for payment 2023-08-02] [HOLD for payment 2023-06-01] [HOLD for payment 2023-05-29] composer height is bigger in Android #19358

Closed

6 tasks

mountiny mentioned this pull request May 22, 2023

Revert "fix: double click compose box and select placeholder" #19402

Merged

55 tasks

		// On Android, multiline TextInput with height: 'auto' will show extra padding unless they are configured with
		// paddingVertical: 0, alignSelf: 'center', and textAlignVertical: 'center'

Conversation

dukenv0307 commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Screenshots/Videos #12669

Uh oh!

melvin-bot bot commented May 17, 2023

Uh oh!

mananjadhav May 17, 2023

Choose a reason for hiding this comment

Uh oh!

tgolen May 17, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 May 17, 2023

Choose a reason for hiding this comment

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen May 17, 2023

Choose a reason for hiding this comment

Uh oh!

tgolen May 17, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented May 17, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented May 17, 2023

Uh oh!

OSBotify commented May 18, 2023

Uh oh!

mountiny commented May 22, 2023

Uh oh!

mountiny commented May 22, 2023

Uh oh!

OSBotify commented May 22, 2023

Uh oh!

OSBotify commented May 23, 2023

Uh oh!

OSBotify commented May 23, 2023

Uh oh!

OSBotify commented May 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented May 17, 2023 •

edited

Loading