Make Threads Searchable by grgia · Pull Request #19117 · Expensify/App

grgia · 2023-05-17T13:04:38Z

Details

Make threads appear in the search bar.

Fixed Issues

$ #19043

Tests

Verify that no errors appear in the JS console
Navigate back to the parent report
Verify the thread shows on the search page, with the same appearance as in the LHN.
Click on the thread from the search page and verify you are navigated correctly
Repeat for group chat
Repeat for workspace chat
Repeat for workspace room
Repeat for a sub thread

Offline tests

QA Steps

Verify that no errors appear in the JS console
Navigate back to the parent report
Verify the thread shows on the search page, with the same appearance as in the LHN.
Click on the thread from the search page and verify you are navigated correctly
Repeat for group chat
Repeat for workspace chat
Repeat for workspace room
Repeat for a sub thread

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-05-17T13:04:44Z

@stitesExpensify @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-05-17T17:40:35Z

I'm going to jump in and review this since I have some time and it's interesting.

neil-marcellini

@grgia would you please fill out the test and QA sections? It's pretty self explanatory so I'll go ahead and continue to test, but let's not skip filling it out.

neil-marcellini

Tests I used:

Create a thread in a DM
Navigate back to the parent report
Verify the thread shows on the search page, with the same appearance as in the LHN.
Click on the thread from the search page and verify you are navigated correctly
Same for group chat
Same for workspace chat
Same for workspace room
Same for a sub thread

The appearance of threads on a workspace chat doesn't look quite right in the LHN or the search, but we can fix that bug separately.

There's an inconsistency between the LHN and Search page for threads on messages workspace rooms. We probably want to match the LHN.

All the other cases look great.

neil-marcellini · 2023-05-17T18:41:25Z

Also there's a lint error.

grgia · 2023-05-18T12:27:18Z

@neil-marcellini merging main fixed the matching headers and #19185 addresses the incorrect header for workspace non-room chats!

Also, my bad for forgetting to update the test steps, I added yours and I appreciate you sending them!

thesahindia · 2023-05-18T15:02:39Z

I think I experienced something unexpected. Here are the steps -

Use account A
Search for user B
Send a message
Hover over it and click on thread
Thread will be created in the LHN
Go to search > You will not see the thread
Now send a message in the thread and go to search > Still no thread in the search page
Use account B and open the thread you created with account A
Now go to account A and refresh the page
Go to search and the thread will be visible

neil-marcellini

Thanks for the update, the issues from my last review were fixed as you noted. I think we're really close on this, one small thing.

I'm seeing the same problem that @thesahindia pointed out. If I create a new thread on a message but don't send a message in the thread, it shows in the LHN but not on the search page. The message I threaded is "My message I'm going to thread" sent in a DM with "Neil Chat".

grgia · 2023-05-23T13:06:04Z

looking into that bug

stitesExpensify

Code LGTM!

grgia · 2023-05-24T12:12:30Z

@neil-marcellini @thesahindia that bug should be fixed by this PR which hides threads reports opened with no messages https://github.com/Expensify/App/pull/19375/files

neil-marcellini · 2023-05-24T17:14:19Z

@grgia thanks for linking the PR to fix that bug. It looks like there's some merge conflicts, let me know when those are resolved in case a re-review is required. @thesahindia will probably want to review once more before we merge.

grgia · 2023-05-24T18:04:31Z

@neil-marcellini @thesahindia merged main, ready for final review

stitesExpensify

LGTM, one NAB

stitesExpensify · 2023-05-24T18:13:26Z

src/libs/OptionsListUtils.js

+            const title = ReportUtils.getReportName(report);
+            const chatRoomSubtitle = ReportUtils.getChatRoomSubtitle(report);
+
+            Array.prototype.push.apply(searchTerms, title.split(/[,\s]/));


NAB A comment here would be nice to explain what we're doing with this regex

thesahindia · 2023-05-24T18:57:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

Looks good to me!

OSBotify · 2023-05-25T16:58:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-26T07:53:24Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-29T23:37:00Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.19-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Make threads searchable

e0c6776

grgia self-assigned this May 17, 2023

grgia requested a review from a team as a code owner May 17, 2023 13:04

melvin-bot bot requested review from stitesExpensify and thesahindia and removed request for a team May 17, 2023 13:04

neil-marcellini self-requested a review May 17, 2023 17:39

neil-marcellini reviewed May 17, 2023

View reviewed changes

neil-marcellini requested changes May 17, 2023

View reviewed changes

grgia mentioned this pull request May 18, 2023

[HOLD for payment 2023-06-19] Fix Header subtitle for workspace chats #19186

Closed

grgia added 2 commits May 18, 2023 13:24

Merge branch 'main' into georgia-makeThreadsSearchable

9bb2b95

prettier

cbaf7bd

grgia requested a review from neil-marcellini May 18, 2023 12:26

neil-marcellini requested changes May 18, 2023

View reviewed changes

stitesExpensify previously approved these changes May 23, 2023

View reviewed changes

neil-marcellini previously approved these changes May 24, 2023

View reviewed changes

grgia added 2 commits May 24, 2023 18:54

Merge branch 'main' into georgia-makeThreadsSearchable

a05cb1e

Merge branch 'main' into georgia-makeThreadsSearchable

7ca93e5

grgia dismissed stale reviews from stitesExpensify and neil-marcellini via 7ca93e5 May 24, 2023 17:56

grgia requested review from neil-marcellini and stitesExpensify May 24, 2023 17:57

stitesExpensify approved these changes May 24, 2023

View reviewed changes

thesahindia approved these changes May 24, 2023

View reviewed changes

neil-marcellini approved these changes May 25, 2023

View reviewed changes

neil-marcellini merged commit 63f314c into main May 25, 2023

neil-marcellini deleted the georgia-makeThreadsSearchable branch May 25, 2023 16:51

OSBotify mentioned this pull request May 26, 2023

Deploy Checklist: New Expensify 2023-05-26 #19657

Closed

32 tasks

kbecciv mentioned this pull request May 26, 2023

[$1000] Search - Only one of threads/chats is shown on search page for threads in direct and group messages #19697

Closed

6 tasks

melvin-bot bot mentioned this pull request May 29, 2023

[HOLD for payment 2023-06-05] [$1000] Bug - Threads should be searchable in NewDot #19043

Closed

mkhutornyi mentioned this pull request Jul 30, 2024

perf: remove getSearchText function #46409

Merged

50 tasks

Conversation

grgia commented May 17, 2023 • edited by pronin-denis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 17, 2023

Uh oh!

neil-marcellini commented May 17, 2023

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented May 17, 2023

Uh oh!

grgia commented May 18, 2023

Uh oh!

thesahindia commented May 18, 2023

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented May 23, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented May 24, 2023

Uh oh!

neil-marcellini commented May 24, 2023

Uh oh!

grgia commented May 24, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

stitesExpensify May 24, 2023

Choose a reason for hiding this comment

Uh oh!

thesahindia commented May 24, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 25, 2023

Uh oh!

OSBotify commented May 26, 2023

Uh oh!

OSBotify commented May 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

grgia commented May 17, 2023 •

edited by pronin-denis

Loading