fix console error TypeError can't read properties of null in Hoverable.js #19488

ahmedGaber93 · 2023-05-23T20:43:39Z

Details

Fixed Issues

$ #19228
$ #19228 (comment)

Tests

Open the app.
Open login page and enter your email then click continue to the Magic Code page.
Scroll down and click on either login or create a new account link.
Verify that no errors appear in the JS console.

Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Same as Tests step.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-23.at.9.20.46.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-23.at.10.06.45.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-23.at.10.18.52.PM.mov

Desktop

Screen.Recording.2023-05-23.at.10.22.30.PM.mov

iOS

Screen.Recording.2023-05-23.at.10.20.52.PM.mov

Android

Screen.Recording.2023-05-23.at.9.24.22.PM.mov

…ontains') in Hoverable.js

melvin-bot · 2023-05-23T20:43:44Z

@dangrous @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dangrous

LGTM!

mollfpr · 2023-05-24T16:47:47Z

src/components/Hoverable/index.js

                onMouseLeave={() => this.setIsHovered(false)}
                onBlur={(el) => {
-                    if (this.wrapperView.contains(el.relatedTarget)) {
+                    if (!_.isNull(this.wrapperView) && this.wrapperView.contains(el.relatedTarget)) {


@ahmedGaber93 Should we do this in other onBlur too?

App/src/components/Hoverable/index.js

Lines 83 to 86 in 8f9d1c5

onBlur: (el) => {

if (!this.wrapperView.contains(el.relatedTarget)) {

this.setIsHovered(false);

}

@mollfpr yes, we should.
I think we need to check null here also to prevent this error in all places
if (!_.isNull(this.wrapperView) && !this.wrapperView.contains(el.relatedTarget))
do you agree?

@ahmedGaber93 Sounds good to me!

@ahmedGaber93 On second thought, looking and the original condition !this.wrapperView.contains(el.relatedTarget), so that's mean null this.wrapperView is also true?

I'm not sure to understand the condition; it's either

!_.isNull(this.wrapperView) && !this.wrapperView.contains(el.relatedTarget)

_.isNull(this.wrapperView) || !this.wrapperView.contains(el.relatedTarget)

What do you guys think?

@mollfpr I think the two conditions will prevent call contains from null this.wrapperView.
But even though we don't have any UI visual issues, I think the second condition logic is better because it will set isHovered to fallback false.

@ahmedGaber93 Let's go with the second logic then! Sorry for the hustle 🙏

@mollfpr are you mean use !_.isNull(this.wrapperView) && in the two places
or remove it from the second place here.

App/src/components/Hoverable/index.js

Lines 83 to 86 in 8f9d1c5

onBlur: (el) => {

if (!this.wrapperView.contains(el.relatedTarget)) {

this.setIsHovered(false);

}

@ahmedGaber93 Only for remove it from this.

if (!this.wrapperView.contains(el.relatedTarget)) { this.setIsHovered(false); }

@mollfpr removed, you can review now.

Is there any problem if just adding this?

- if (this.wrapperView.contains(el.relatedTarget)) { + if (this.wrapperView && this.wrapperView.contains(el.relatedTarget)) {

mollfpr · 2023-05-24T17:16:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

19488.Web.mov

Mobile Web - Chrome

19488.mWeb.Chrome.mp4

Mobile Web - Safari

19488.mWeb.Safari.mp4

Desktop

19488.Desktop.mov

iOS

19488.iOS.mp4

Android

19488.Android.mp4

mollfpr · 2023-05-25T14:59:15Z

@ahmedGaber93 Could you resolve the conflict? Thanks!

ahmedGaber93 · 2023-05-25T15:21:28Z

@mollfpr
The section has the edit is removed from the component by this PR #16052.
See render method here

I will try to reproduce the issue on the new code and till you if new code still reproduce the issue or not

ahmedGaber93 · 2023-05-25T15:38:55Z

@mollfpr I can't reproduce the issue in the new code by the pr #16052.

dangrous · 2023-05-31T16:53:55Z

We can close this right?

fix console error TypeError can't read properties of null (reading 'c…

557bfa8

…ontains') in Hoverable.js

ahmedGaber93 requested a review from a team as a code owner May 23, 2023 20:43

melvin-bot bot requested review from dangrous and mollfpr and removed request for a team May 23, 2023 20:43

ahmedGaber93 mentioned this pull request May 23, 2023

[$1000] Error in JS console when pressing the "Login" button or the "Create a New Account" link in the footer of Magic Code page #19228

Closed

6 tasks

dangrous previously approved these changes May 24, 2023

View reviewed changes

mollfpr reviewed May 24, 2023

View reviewed changes

ahmedGaber93 dismissed dangrous’s stale review via ce79122 May 24, 2023 17:49

ahmedGaber93 requested a review from mollfpr May 24, 2023 17:49

ahmedGaber93 force-pushed the issue-19228 branch from ce79122 to 557bfa8 Compare May 25, 2023 14:55

dangrous closed this Jun 1, 2023

	onBlur: (el) => {
	if (!this.wrapperView.contains(el.relatedTarget)) {
	this.setIsHovered(false);
	}

fix console error TypeError can't read properties of null in Hoverable.js #19488

fix console error TypeError can't read properties of null in Hoverable.js #19488

Uh oh!

Conversation

ahmedGaber93 commented May 23, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 23, 2023

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mollfpr commented May 24, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr commented May 25, 2023

Uh oh!

ahmedGaber93 commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented May 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ahmedGaber93 May 24, 2023 •

edited

Loading

ahmedGaber93 commented May 25, 2023 •

edited

Loading

ahmedGaber93 commented May 25, 2023 •

edited

Loading