17027 - migrated CollapsibleSection to PressableWithFeedback #19753

Skalakid · 2023-05-29T17:48:56Z

Details

Fixed Issues

Tests

To make testing easier and safe some time you can make some changes in code to navigate directly to the Terms and fees screen in EnablePaymentsPage.

In EnablePaymentsPage.js change:

        ...
-      return (
-            <>
-                 {(currentStep === CONST.WALLET.STEP.ADDITIONAL_DETAILS || currentStep === CONST.WALLET.STEP.ADDITIONAL_DETAILS_KBA) && <AdditionalDetailsStep />}
-                  {currentStep === CONST.WALLET.STEP.ONFIDO && <OnfidoStep />}
-                  {currentStep === CONST.WALLET.STEP.TERMS && <TermsStep />}
-                  {currentStep === CONST.WALLET.STEP.ACTIVATE && <ActivateStep userWallet={this.props.userWallet} />}
-             </>
-      );
+      return (
+       <TermsStep />
+      )

and in FloatingActionButtonAndPopover.js change:

         ...
         text: this.props.translate('iou.splitBill'),
-        onSelected: () => Navigation.navigate(ROUTES.IOU_BILL),
+        onSelected: () => Navigation.navigate(ROUTES.ENABLE_PAYMENTS),

Now you can navigate to the proper screen simply by clicking + button and choosing Split bill option 😉

Or instead of modifying FloatingActionButtonAndPopover.js you can deep-link into the enable-payments page:

Android: adb shell am start -a android.intent.action.VIEW -d new-expensify://enable-payments
iOS: xcrun simctl openurl booted new-expensify://enable-payments
Web/mWeb: go to /enable-payments in the browser
Desktop: I changed navigation method in FloatingActionButtonAndPopover.js 🤷‍♂️

Then you can start testing:

Log in
Navigate to /enable-page normally or using methods described above
Click on A list of all Expensify Wallet fees item. Verify the styling and the behaviour of the component.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Have an account (under the wallet beta) with a silver/pending wallet. Note: every account under the wallet beta has a silver wallet created automatically.
If this account does not have a personal bank account (PBA) set up, follow the below steps:

Log into NewDot and navigate to Settings > Payments > Add payment method > Bank account
Select Connect via plaid and use the following credentials:

Wells Fargo
Username: user_good
password: pass_good
Mobile verification code: credential_good
Plaid saving

Have another user request money to the user you are testing with
Attempt to pay the money request and verify the KYC wall is triggered
In the additional details form, enter first name Alberta, last name Charleson and SSN as 3333. Enter any data for the other fields.
Click Save & continue
In Verify identity page click Continue
In Terms and fees page click on A list of all Expensify Wallet fees item. Verify the styling and the behaviour of the component.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

WEB.mov

Mobile Web - Chrome

web-mobile-chrome.mov

Mobile Web - Safari

web-mobile-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-05-29T17:49:28Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

stitesExpensify

LGTM, leaving testing to @fedirjh

fedirjh · 2023-05-29T20:26:27Z

@Skalakid, @stitesExpensify Looks good , just noticed that text is selectable which is different from old behaviour

Screen.Recording.2023-05-29.at.9.24.26.PM.mov

fedirjh · 2023-05-29T20:31:01Z

We also have this warning which doesn’t seems related to this PR , but it looks to be related with PressableWithFeedback component

fedirjh · 2023-05-29T21:43:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web.mov

Mobile Web - Chrome

Chrome.mov

Mobile Web - Safari

Safari.mov

Desktop

Desktop.mov

iOS

IOS.mov

Android

AAndrroidd.mov

fedirjh · 2023-05-29T21:49:07Z

@Skalakid for QA steps , maybe we can add similar steps to #14988

Skalakid · 2023-05-31T08:11:11Z

We also have this warning which doesn’t seems related to this PR , but it looks to be related with PressableWithFeedback component

@fedirjh I think it is because of the missing accessibility label, which is required. @robertKozik I think it can be fixed in your PR #18792, can you check it out?

robertKozik · 2023-05-31T09:10:41Z

Hi!👋🏼
PR #18792 will solve this problem which you encountered. It marks the PressableWithFeedback as non-accessible (as we have accessible checkbox itself, and this is only clickable label) so it won't require the accessibility label.

Skalakid · 2023-05-31T11:50:33Z

@Skalakid for QA steps , maybe we can add similar steps to #14988

@fedirjh for sure the steps that you mentioned are better, but I can't reproduce them :( After adding a bank account I can't go further. Do you know how can I enable paying with the bank account and be able to pass threw enable payments page to terms and fees page?

fedirjh · 2023-05-31T18:11:53Z

but I can't reproduce them :( After adding a bank account I can't go further.

@Skalakid It require wallet beta access , as of #14988 (comment) , QA can access it using an expensifail account. I think it will be fine to add those test to QA section and keep dev tests as they’re

robertKozik · 2023-06-02T12:44:34Z

@Skalakid @fedirjh the PR which should resolve the accessibilityLabel errors was merged. So error you encoutered should be gone.

Skalakid · 2023-06-02T13:22:55Z

@fedirjh I've just added those tests to QA section :D And like @robertKozik said, the erros are gone

fedirjh

LGTM and tests well

cc @stitesExpensify all yours

🎀 👀 🎀 C+ reviewed

stitesExpensify

LGTM

melvin-bot · 2023-06-02T16:59:38Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-06-02T17:05:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-05T19:25:44Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2023-06-06T16:13:33Z

This PR is failing QA because of issue #20280

OSBotify · 2023-06-07T03:29:34Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T13:21:13Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

migrated CollapsibleSection to PressableWithFeedback

da9c95f

Skalakid requested a review from a team as a code owner May 29, 2023 17:48

melvin-bot bot requested review from stitesExpensify and removed request for a team May 29, 2023 17:49

stitesExpensify requested a review from fedirjh May 29, 2023 18:25

stitesExpensify assigned Skalakid May 29, 2023

stitesExpensify previously approved these changes May 29, 2023

View reviewed changes

fixed text selection problem

7816cfc

Skalakid dismissed stitesExpensify’s stale review via 7816cfc May 31, 2023 09:44

Merge branch 'main' into 17027-migrate-CollapsibleSection

49608e3

Skalakid requested a review from stitesExpensify June 2, 2023 13:24

fedirjh approved these changes Jun 2, 2023

View reviewed changes

stitesExpensify approved these changes Jun 2, 2023

View reviewed changes

stitesExpensify merged commit fc30ddc into Expensify:main Jun 2, 2023

OSBotify mentioned this pull request Jun 5, 2023

Deploy Checklist: New Expensify 2023-06-05 #20195

Closed

51 tasks

isagoico mentioned this pull request Jun 6, 2023

[$2000] IOU - Add bank account is looping when clicking pay with expensify #20280

Closed

6 tasks

Christinadobrzyn mentioned this pull request Jun 7, 2023

[$250] [Group 2][Accessible Pressable] Migrate CollapsibleSection #17027

Closed

17027 - migrated CollapsibleSection to PressableWithFeedback #19753

17027 - migrated CollapsibleSection to PressableWithFeedback #19753

Uh oh!

Conversation

Skalakid commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 29, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

fedirjh commented May 29, 2023

Uh oh!

fedirjh commented May 29, 2023

Uh oh!

fedirjh commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fedirjh commented May 29, 2023

Uh oh!

Skalakid commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robertKozik commented May 31, 2023

Uh oh!

Skalakid commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh commented May 31, 2023

Uh oh!

robertKozik commented Jun 2, 2023

Uh oh!

Skalakid commented Jun 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh left a comment

Choose a reason for hiding this comment

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jun 2, 2023

Uh oh!

OSBotify commented Jun 2, 2023

Uh oh!

OSBotify commented Jun 5, 2023

Uh oh!

isagoico commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 7, 2023

Uh oh!

OSBotify commented Jun 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Skalakid commented May 29, 2023 •

edited

Loading

fedirjh commented May 29, 2023 •

edited

Loading

Skalakid commented May 31, 2023 •

edited

Loading

Skalakid commented May 31, 2023 •

edited

Loading

Skalakid commented Jun 2, 2023 •

edited

Loading

isagoico commented Jun 6, 2023 •

edited

Loading