17038 - migrate AddReactionBubble to PressableWithFeedback #20158

Skalakid · 2023-06-05T09:33:42Z

Details

Fixed Issues

$ #17038
PROPOSAL: #17038

Tests

Log in
Enter a chat with somebody
Add reaction
Click the Add reaction bubble that appeared next to the previously added reaction, verify styling and behavior

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mWeb--chrome.mov

Mobile Web - Safari

mWeb-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-06-05T09:34:14Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…r etc

luacmartins · 2023-06-06T16:29:18Z

@abdulrahuman5196 assigning you for review/test

luacmartins · 2023-06-06T16:30:08Z

src/components/Reactions/AddReactionBubble.js

                // Prevent text input blur when Add reaction is clicked
                onMouseDown={(e) => e.preventDefault()}
+                accessibilityLabel={props.translate('emojiReactions.addReactionTooltip')}
+                accessibilityRole="button"


NAB should we create a CONST for "button"?

We're adding the CONSTs here. Let's incorporate those changes in this PR as well.

abdulrahuman5196 · 2023-06-06T16:36:41Z

Will start reviewing today

abdulrahuman5196 · 2023-06-07T15:22:51Z

src/components/Reactions/AddReactionBubble.js

+                accessibilityLabel={props.translate('emojiReactions.addReactionTooltip')}
+                accessibilityRole="button"
+                // disable dimming
+                hoverDimmingValue={1}


We had a slack conversion for providing hoverDimmingValue from parent here - https://expensify.slack.com/archives/C01GTK53T8Q/p1686151320529999?thread_ts=1685741951.521769&cid=C01GTK53T8Q

Will confirm on the same before approving.

It seems like we will be setting hoverDimmingValue as 1 as default. But that change is in PR.
Anyways i am fine with this for now. Since its not wrong to pass default value again as well(just not required) and I don't think we need to block this PR for the defaultValue change as well. Correct me if wrong @luacmartins

https://github.com/Expensify/App/pull/19882/files#diff-4c815c48cfd171056c4be0e2bc556302e115c20c2bef5b5b00dbe55450faca5aR142

Yea, that seems fine to me.

abdulrahuman5196 · 2023-06-07T15:45:56Z

Got it. then we can have this PR in hold for the other 2 PRs to be merged.

Skalakid · 2023-06-13T14:43:46Z

@luacmartins how about pushing this PR forward and just adding CONSTs from here in another PR? Because for sure there are a lot of places where er need to change roles to CONST so we can change it too but in another PR

luacmartins · 2023-06-13T15:01:05Z

Sounds fine, we've been waiting on the other PR long enough and it seems like there are some issues now. @abdulrahuman5196 wanna review and complete the checklist?

abdulrahuman5196 · 2023-06-13T15:23:42Z

Sure @luacmartins Will work on this today.

abdulrahuman5196 · 2023-06-13T22:35:17Z

Just closing out other overdue PRs and proposals. Will work on reviewer's checklist on this PR in half a day. Apologies for the delay.

luacmartins · 2023-06-14T16:52:41Z

Just missing a review from @abdulrahuman5196

abdulrahuman5196 · 2023-06-14T17:12:34Z

Yes. Working on this PR review.

abdulrahuman5196 · 2023-06-14T18:14:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.39.mp4

Mobile Web - Chrome

az_recorder_20230614_232043.mp4

Mobile Web - Safari

ScreenRecording.mov

Desktop

Screen.Recording.2023-06-14.at.11.25.50.PM.mov

iOS

Screen.Recording.2023-06-14.at.11.30.50.PM.mov

Android

Untitled.40.mp4

abdulrahuman5196 · 2023-06-14T18:25:02Z

@Skalakid Kindly mark the Offline tests and QA test as "Same as tests"

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours @luacmartins . good to merge.

@Skalakid Kindly make sure to update the QA section as mentioned here #20158 (comment)

luacmartins · 2023-06-14T20:07:45Z

I updated the OP with steps for offline and QA. Merging.

OSBotify · 2023-06-14T20:11:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-14T21:24:50Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.28-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2023-06-16T18:39:49Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

migrated AddReactionBubble to PressableWithoutFeedback

1c4d9cf

Skalakid requested a review from a team as a code owner June 5, 2023 09:33

melvin-bot bot requested review from luacmartins and removed request for a team June 5, 2023 09:34

Skalakid added 2 commits June 5, 2023 12:51

changed PressableWithFeedback to be able to change icon color on hove…

895cf5e

…r etc

disabled dimming

77fd23f

Skalakid changed the title ~~17038 - migrated AddReactionBubble to PressableWithoutFeedback~~ 17038 - migrated AddReactionBubble to PressableWithFeedback Jun 5, 2023

Skalakid changed the title ~~17038 - migrated AddReactionBubble to PressableWithFeedback~~ 17038 - migrate AddReactionBubble to PressableWithFeedback Jun 5, 2023

Skalakid mentioned this pull request Jun 5, 2023

17040 - migrate EmojiPickerButton to PressableWithFeedback #20159

Closed

57 tasks

luacmartins requested a review from abdulrahuman5196 June 6, 2023 16:28

luacmartins previously approved these changes Jun 6, 2023

View reviewed changes

abdulrahuman5196 reviewed Jun 7, 2023

View reviewed changes

Skalakid marked this pull request as draft June 12, 2023 10:36

Skalakid added 2 commits June 13, 2023 09:19

Merge branch 'main' into 17038-migrate-AddReactionBubble

3bc0c79

removed repeating default dimming value

d9cabaa

Skalakid dismissed luacmartins’s stale review via d9cabaa June 13, 2023 07:25

Skalakid changed the title ~~17038 - migrate AddReactionBubble to PressableWithFeedback~~ [HOLD #20251] 17038 - migrate AddReactionBubble to PressableWithFeedback Jun 13, 2023

Skalakid changed the title ~~[HOLD #20251] 17038 - migrate AddReactionBubble to PressableWithFeedback~~ 17038 - migrate AddReactionBubble to PressableWithFeedback Jun 13, 2023

Skalakid marked this pull request as ready for review June 13, 2023 14:45

luacmartins approved these changes Jun 13, 2023

View reviewed changes

abdulrahuman5196 approved these changes Jun 14, 2023

View reviewed changes

luacmartins merged commit 2a1c36d into Expensify:main Jun 14, 2023

OSBotify mentioned this pull request Jun 14, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

abdulrahuman5196 mentioned this pull request Jun 23, 2023

[Payment June 23rd, 2023] [$250] [Group 4][Accessible Pressable] Migrate AddReactionBubble #17038

Closed

17038 - migrate AddReactionBubble to PressableWithFeedback #20158

17038 - migrate AddReactionBubble to PressableWithFeedback #20158

Uh oh!

Conversation

Skalakid commented Jun 5, 2023 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 5, 2023

Uh oh!

luacmartins commented Jun 6, 2023

Uh oh!

luacmartins Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Jun 6, 2023

Uh oh!

abdulrahuman5196 Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Jun 7, 2023

Uh oh!

Skalakid commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Jun 13, 2023

Uh oh!

abdulrahuman5196 commented Jun 13, 2023

Uh oh!

abdulrahuman5196 commented Jun 13, 2023

Uh oh!

luacmartins commented Jun 14, 2023

Uh oh!

abdulrahuman5196 commented Jun 14, 2023

Uh oh!

abdulrahuman5196 commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 commented Jun 14, 2023

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Jun 14, 2023

Uh oh!

OSBotify commented Jun 14, 2023

Uh oh!

OSBotify commented Jun 14, 2023

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Skalakid commented Jun 5, 2023 •

edited by luacmartins

Loading

luacmartins Jun 6, 2023 •

edited

Loading

Skalakid commented Jun 13, 2023 •

edited

Loading

abdulrahuman5196 commented Jun 14, 2023 •

edited

Loading