Remove redundant error messages for report actions #20666

therealsujitk · 2023-06-13T11:18:56Z

Details

This PR makes the following changes.

Set the error fields in failureData to { [timestamp]: null } to set an error with no message (removing redundant error messages).

Modify OfflineWithFeedback to show only valid error messages.

const errorMessages = _.omit(props.errors, e => e === null);
const hasErrorMessages = !_.isEmpty(errorMessages);

Fixed Issues

$ #18839
PROPOSAL: #18839 (comment)

Tests

Log in with the same account in the main testing device and a secondary device
Disable the internet connection in the main testing device (Force Offline)
In the secondary device Split a bill with 2 users, this should create a new group and 2 new 1:1 conversations
In the main testing device (should be offline) create the SAME split bill with the 2 users
Enable the internet connection in the main testing device. The split bill request will be sent and you will get an error in the main device only
Duplicated chats are display in the LHN
Open the group chat report, 1:1 chat reports & 1:1 IOU reports and verify that there are no redundant error messages.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with the same account in the main testing device and a secondary device
Disable the internet connection in the main testing device (Force Offline)
In the secondary device Split a bill with 2 users, this should create a new group and 2 new 1:1 conversations
In the main testing device (should be offline) create the SAME split bill with the 2 users
Enable the internet connection in the main testing device. The split bill request will be sent and you will get an error in the main device only
Duplicated chats are display in the LHN
Open the group chat report, 1:1 chat reports & 1:1 IOU reports and verify that there are no redundant error messages.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-13T11:19:02Z

@yuwenmemon @s77rt One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

therealsujitk · 2023-06-13T11:37:48Z

Few things I'd like to point out,

While testing this PR I ran into a bug that I've reported on Slack. This might be a regression as I don't remember this happening before (reproducible in staging).
Normally in chat reports the error for the report in displayed in the create report action, however this action is not displayed for IOU reports, therefore currently no error is shown if the IOU report failed to create.

src/components/OfflineWithFeedback.js

s77rt · 2023-06-13T12:21:55Z

@therealsujitk Please double check if those errors are a regression or not before reporting in Slack. If they are, we should fix them here.

therealsujitk · 2023-06-13T12:32:11Z

@s77rt the bug I mentioned above isn't caused by this PR. Both points I mentioned can be considered out of scope.

src/components/OfflineWithFeedback.js

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

src/libs/actions/IOU.js

s77rt · 2023-06-15T00:52:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt · 2023-06-15T00:53:04Z

@therealsujitk Please add missing screenshots

therealsujitk · 2023-06-15T10:02:22Z

@s77rt I've added the screenshot for Desktop but I can't test on iPhone right now since I don't own a Mac and my hackintosh is not powerful enough to handle a simulator. I have already ordered a MacBook which should be arriving by the end of this month after which I will be able to upload tests with iPhone for future PRs. Sorry for the inconvenience.

s77rt · 2023-06-15T10:46:16Z

@therealsujitk It's a requirement to test on all platforms. Please take into consideration to rent a mac from macincloud.com or similar services for the time being.

s77rt

LGTM! 🚀

cc @yuwenmemon

OSBotify · 2023-06-16T17:49:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-16T18:50:13Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-21T02:17:44Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove redundant error messages

b5e5c22

therealsujitk requested a review from a team as a code owner June 13, 2023 11:18

melvin-bot bot requested review from s77rt and yuwenmemon and removed request for a team June 13, 2023 11:18

Fix lint

ffe8084

s77rt suggested changes Jun 13, 2023

View reviewed changes

src/components/OfflineWithFeedback.js Show resolved Hide resolved

Add comment explaining the removal of null errors

53cb8fd

s77rt reviewed Jun 13, 2023

View reviewed changes

src/components/OfflineWithFeedback.js Outdated Show resolved Hide resolved

Update comment

276eaec

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

therealsujitk requested a review from s77rt June 13, 2023 18:35

s77rt suggested changes Jun 13, 2023

View reviewed changes

src/libs/actions/IOU.js Show resolved Hide resolved

src/libs/actions/IOU.js Show resolved Hide resolved

src/libs/actions/IOU.js Show resolved Hide resolved

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

Add failure data conditionally instead of overwriting

999cd0b

s77rt reviewed Jun 14, 2023

View reviewed changes

src/libs/actions/IOU.js Show resolved Hide resolved

Remove redundant code

b2e307f

s77rt approved these changes Jun 15, 2023

View reviewed changes

yuwenmemon approved these changes Jun 16, 2023

View reviewed changes

yuwenmemon merged commit 5028b49 into Expensify:main Jun 16, 2023

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

melvin-bot bot mentioned this pull request Jun 21, 2023

[BONUS PAYOUT ONLY] [$1000] Chat - Redundant "Unexpected error" below the IOU" message after split from 2 devices #18839

Closed

6 tasks

Remove redundant error messages for report actions #20666

Remove redundant error messages for report actions #20666

Uh oh!

Conversation

therealsujitk commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 13, 2023

Uh oh!

therealsujitk commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

s77rt commented Jun 13, 2023

Uh oh!

therealsujitk commented Jun 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Jun 15, 2023

Uh oh!

therealsujitk commented Jun 15, 2023

Uh oh!

s77rt commented Jun 15, 2023

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

OSBotify commented Jun 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

therealsujitk commented Jun 13, 2023 •

edited

Loading

therealsujitk commented Jun 13, 2023 •

edited

Loading

s77rt commented Jun 15, 2023 •

edited

Loading