Allow DM'ing from profile even if you don't "know" the user #21231

puneetlath · 2023-06-21T17:16:11Z

Details

This PR allows you to send someone a DM from their profile, even if you don't "know" them (aka you don't have their login info in Onyx). It does this by calling openReport with the accountID instead of the email address.

Fixed Issues

$ #21235

Tests

Go into a public room (e.g. this one: https://staging.new.expensify.com/r/5593084223054221)
Click on the avatar of someone that has posted that you don't currently "know"
Make sure you see the option to message them
Click the button to send them a message
Make sure you are taken to the DM report with that user
Send them a message
Make sure you are able to message them without error
Sign out and view the room as an anonymous user
Click on someone's avatar to open their profile
Make sure you don't see the option to message them

Verify that no errors appear in the JS console

Offline tests

Go into a public room (e.g. this one: https://staging.new.expensify.com/r/5593084223054221)
Click on the avatar of someone that has posted that you don't currently "know"
Make sure you see the option to message them
Click the button to send them a message
Make sure you are taken to the DM report with that user
Send them a message
Make sure you are able to message them without error

QA Steps

Go into a public room (e.g. this one: https://staging.new.expensify.com/r/5593084223054221)
Click on the avatar of someone that has posted that you don't currently "know"
Make sure you see the option to message them
Click the button to send them a message
Make sure you are taken to the DM report with that user
Send them a message
Make sure you are able to message them without error
Sign out and view the room as an anonymous user
Click on someone's avatar to open their profile
Make sure you don't see the option to message them

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Beamanator · 2023-06-21T17:47:03Z

Currently looks like this when I view an account that exists & has a display name, but i don't "know"

Currently looks like this when I view an account that I know - but doesn't have a display name:

Beamanator · 2023-06-21T17:47:53Z

& looks like this when there's an account that doesn't exist:

(sometimes I got "it's not here" - maybe just when the accountID is super high like 12312312312342342)

~~Hmm I even got the "Hmm, it's not here" when I used a small accountID that definitely does exist in my db~~ (i was using the wrong url lol)

Beamanator · 2023-06-21T18:00:06Z

Hmm here's an account whose displayName was already set to their email (i don't remember why, from previous tests) and their email shows twice in their profile page... problem? Probably not?

Beamanator · 2023-06-21T18:02:42Z

And here's if i literally just created the account, which looks good 👍

And after creating the chat, the classic double-whisper

And even in the main user's chat I see the "watch out" whisper 😅 ( i think this is known and needs to be fixed?)

melvin-bot · 2023-06-21T18:19:14Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-06-21T19:33:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

allroundexperts

Looking good.
Few unrelated things I found during testing:

Send / Request money does not work for chat with a public room user.
Found a console error which I reported here.

melvin-bot · 2023-06-21T21:19:45Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #21235... Please reach out for help on Slack if no one gets assigned!

allroundexperts · 2023-06-21T21:27:07Z

src/pages/ProfilePage.js

-                            />
-                        )}
+                        {!isCurrentUser &&
+                            !Session.isAnonymousUser(


Nice catch @luacmartins!
How did I miss that 😮‍💨

src/pages/ProfilePage.js

github-actions · 2023-06-21T21:50:23Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

youssef-lr

LGTM!

Allow DM'ing from profile even if you don't "know" the user (cherry picked from commit 1745b01)

…-21231 🍒 Cherry pick PR #21231 to staging 🍒

OSBotify · 2023-06-21T23:03:16Z

🚀 Cherry-picked to staging by https://github.com/youssef-lr in version: 1.3.30-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-22T16:53:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.30-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T21:05:49Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T21:25:34Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T22:17:16Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-26T20:47:53Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

puneetlath added 2 commits June 21, 2023 13:15

Allow opening report using acocuntIDs instead of emails

e859254

Allow messaging from profile page

84f02de

puneetlath self-assigned this Jun 21, 2023

Improve function comment

a6c73cc

puneetlath marked this pull request as ready for review June 21, 2023 18:19

puneetlath requested a review from a team as a code owner June 21, 2023 18:19

melvin-bot bot requested review from parasharrajat and removed request for a team June 21, 2023 18:19

Beamanator previously approved these changes Jun 21, 2023

View reviewed changes

puneetlath requested review from allroundexperts and removed request for parasharrajat June 21, 2023 19:33

Dont show message option if anonymous user

249376d

puneetlath dismissed Beamanator’s stale review via 249376d June 21, 2023 20:30

prettier

795dc10

allroundexperts approved these changes Jun 21, 2023

View reviewed changes

youssef-lr self-requested a review June 21, 2023 21:20

allroundexperts reviewed Jun 21, 2023

View reviewed changes

youssef-lr reviewed Jun 21, 2023

View reviewed changes

src/pages/ProfilePage.js Outdated Show resolved Hide resolved

luacmartins requested changes Jun 21, 2023

View reviewed changes

src/pages/ProfilePage.js Outdated Show resolved Hide resolved

Fix anonymous user function call

d869710

puneetlath requested review from luacmartins and youssef-lr June 21, 2023 21:48

luacmartins approved these changes Jun 21, 2023

View reviewed changes

luacmartins added the CP Staging label Jun 21, 2023

youssef-lr approved these changes Jun 21, 2023

View reviewed changes

youssef-lr merged commit 1745b01 into main Jun 21, 2023

youssef-lr deleted the dm-from-profile branch June 21, 2023 21:57

OSBotify pushed a commit that referenced this pull request Jun 21, 2023

Merge pull request #21231 from Expensify/dm-from-profile

2afca6e

Allow DM'ing from profile even if you don't "know" the user (cherry picked from commit 1745b01)

OSBotify mentioned this pull request Jun 21, 2023

🍒 Cherry pick PR #21231 to staging 🍒 #21275

Merged

OSBotify added a commit that referenced this pull request Jun 21, 2023

Merge pull request #21275 from Expensify/OSBotify-cherry-pick-staging…

a4d3054

…-21231 🍒 Cherry pick PR #21231 to staging 🍒

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

melvin-bot bot mentioned this pull request Jun 22, 2023

[HOLD for payment 2023-06-29] [SNH] Allow messaging from profile #21235

Closed

OSBotify mentioned this pull request Jun 22, 2023

Deploy Checklist: New Expensify 2023-06-22 #21330

Closed

39 tasks

OSBotify mentioned this pull request Jun 24, 2023

Deploy Checklist: New Expensify 2023-06-24 #21477

Closed

45 tasks

Allow DM'ing from profile even if you don't "know" the user #21231

Allow DM'ing from profile even if you don't "know" the user #21231

Uh oh!

Conversation

puneetlath commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Beamanator commented Jun 21, 2023

Uh oh!

Beamanator commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented Jun 21, 2023

Uh oh!

Beamanator commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Jun 21, 2023

Uh oh!

allroundexperts commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jun 21, 2023

Uh oh!

allroundexperts Jun 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 21, 2023

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 21, 2023

Uh oh!

OSBotify commented Jun 22, 2023

Uh oh!

OSBotify commented Jun 23, 2023

Uh oh!

OSBotify commented Jun 23, 2023

Uh oh!

OSBotify commented Jun 23, 2023

Uh oh!

OSBotify commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

puneetlath commented Jun 21, 2023 •

edited

Loading

Beamanator commented Jun 21, 2023 •

edited

Loading

Beamanator commented Jun 21, 2023 •

edited

Loading

allroundexperts commented Jun 21, 2023 •

edited

Loading