Create Currency Modal, with geolocation and Location permissions

[rameshhpathak]

<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>

Details

Fixed Issues

Fixes #1970

Tests

1. Go to /iou/split on web. Verify that the currency is based on your location.
2. Click on the currency, a list with all currencies should show.
3. Search for a currency, or scroll down to your desired currency
4. Click on the currency to select and click on the Confirm button the confirm selection
5. Verify that the selected currency shows now in the amount page
6. Refresh the page, and verify that the same currency shows in the amount page

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Screen.Recording.2021-03-27.at.15.24.24.mov

Android

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[rameshhpathak]

I have read the CLA Document and I hereby sign the CLA

[rameshhpathak]

@Julesssss @iwiznia any idea on why this is not accessing react-native-onyx? It works OK on local environment

[shawnborton]

Since this entire area is already wrapped in 20px padding, let's remove the padding top from this view.

[shawnborton]

Maybe this is just a matter of pulling master, but by default, our modal views should not have a bottom border under the title. So the border you see here should not be included:

CC @Julesssss in case maybe this needs to be changed elsewhere.

[Julesssss]

Maybe this is just a matter of pulling master, but by default, our modal views should not have a bottom border under the title. So the border you see here should not be included:

Yeah, this change will need to be made elsewhere. I'll create an issue for it.

[iwiznia]

@Julesssss @iwiznia any idea on why this is not accessing react-native-onyx? It works OK on local environment

What do you mean exactly? What's not working? I see you are using Onyx already...

[rameshhpathak]

@Julesssss @iwiznia any idea on why this is not accessing react-native-onyx? It works OK on local environment

What do you mean exactly? What's not working? I see you are using Onyx already...

The checks are failing with this error after not able to access onyx.

[Julesssss]

Hi @rameshhpathak,

I'm really not sure why this happened, but I was able to solve this by making your commit in my name. You can see here that the tests are failing for JSLint errors now, instead of the auth error.

I would suggest that you try cherry-picking your changes onto a clean branch/PR to see if that solves the issue (this is probably the quickest path forward)

[Julesssss]

Maybe you know this already, but the Podfile wasn't updated either, so you'll need to run pod install from /ios

[rameshhpathak]

Hi @rameshhpathak,

I'm really not sure why this happened, but I was able to solve this by making your commit in my name. You can see here that the tests are failing for JSLint errors now, instead of the auth error.

I would suggest that you try cherry-picking your changes onto a clean branch/PR to see if that solves the issue (this is probably the quickest path forward)

I'll do that. Thank you for your help.

[Julesssss]

Hey @rameshhpathak, any luck with the suggested fix?

[rameshhpathak]

Hey @rameshhpathak, any luck with the suggested fix?

Hey @Julesssss, I couldn't find time to do it yesterday. Been trying - failed three times today - latest: #2182 . I will try separating out into bits and try pushing commit by commit later today

[rameshhpathak]

@Julesssss I installed it fresh in this PR #2194 . WIll close this PR now :) Thank you for your help!!!