-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Ignore embedded images when pasting in composer #21370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore embedded images when pasting in composer #21370
Conversation
…AE0-2CD3-40A8-8DCB-C8F744CA9F80 Update version to 1.3.28-2 on main (cherry picked from commit 23ca9a7)
[No QA] Revert pod cache (cherry picked from commit 4343d28)
…pick-staging-20784 🍒 Cherry pick PR Expensify#20784 to staging 🍒
…44C-2777-44BD-A7CD-203FAF8585FC Update version to 1.3.28-3 on main (cherry picked from commit 8742a58)
fix: 20412 new user is not navigating to concierge chat after tab on link (cherry picked from commit 9ed4a16)
…k-staging-20740 🍒 Cherry pick PR Expensify#20740 to staging 🍒
…0EE-5E80-4D3B-A3B5-AC69AAD0DDD8 Update version to 1.3.28-5 on main (cherry picked from commit c4ef02b)
…color-our-mention Fix: Wrong text color for our mention (cherry picked from commit 9fda6a5)
…k-staging-20845 🍒 Cherry pick PR Expensify#20845 to staging 🍒
…-main Update version to 1.3.29-0 on staging
…381-2BB9-48BA-8AA7-DCFE3C371E22 Update version to 1.3.29-1 on main (cherry picked from commit cd4c246)
Fix: Error message "Can't remove admin" isn't shown when selecting workspace admins (cherry picked from commit 0b6a0ca)
…k-staging-21023 🍒 Cherry pick PR Expensify#21023 to staging 🍒
…81A-F884-4652-9E3A-E866333417C0 Update version to 1.3.29-2 on main (cherry picked from commit 057a182)
…ltip fix avatar tooltip issues across the app (cherry picked from commit 84a2048)
…k-staging-21026 🍒 Cherry pick PR Expensify#21026 to staging 🍒
…04A-5205-4860-90DE-9205AC4D07DA Update version to 1.3.29-3 on main (cherry picked from commit 55e3cb9)
…lFallback [CP Staging] Make sure that we first check the PersonalDetails we already have before creating fake optimistic personal details (cherry picked from commit 8456d27)
…k-staging-20951 🍒 Cherry pick PR Expensify#20951 to staging 🍒
…15B-302A-410D-BB0B-132FC608343C Update version to 1.3.29-4 on main (cherry picked from commit b0e8364)
…ingIndicator Fix "user is typing..." indicator - key by accountID (cherry picked from commit b25a014)
…k-staging-21029 🍒 Cherry pick PR Expensify#21029 to staging 🍒
…922-2674-4550-B151-1327430FD5F9 Update version to 1.3.29-5 on main (cherry picked from commit ad08447)
[Fix] New Room participants list is empty (cherry picked from commit 3cd537c)
…k-staging-21072 🍒 Cherry pick PR Expensify#21072 to staging 🍒
…BEB-CDC0-4383-A11A-D303D4BAB5C7 Update version to 1.3.29-6 on main (cherry picked from commit 6d92bc3)
Fix Mentions crash (cherry picked from commit 332d2c9)
…k-staging-21030 🍒 Cherry pick PR Expensify#21030 to staging 🍒
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@qispark What's with these 37 commits? You must be doing something wrong. There should only be your commits. |
|
@parasharrajat ok I'll cherry pick and update my branch. It's because I started working on it from an earlier commit. As you see from files changed it's only affecting one file. |
|
@parasharrajat Please check new PR here: #21476 |

Details
When pasting some HTML containing images into Composer, it will cause an error modal. This is because of the server's Content Security Policy, which prevents those images from being fetched separately. This PR prevents the images from being fetched, instead it will paste the plaintext that is copied.
Fixed Issues
$ #18583
$ #18583 (comment)
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-06-23.at.9.08.11.pm.mov
Mobile Web - Chrome
Screen.Recording.2023-06-23.at.10.48.26.pm.mov
Mobile Web - Safari
Screen.Recording.2023-06-23.at.9.10.32.pm.mov
Desktop
Screen.Recording.2023-06-23.at.11.17.31.pm.mov
iOS
Screen.Recording.2023-06-23.at.10.21.31.pm.mov
Android
Screen.Recording.2023-06-23.at.10.58.14.pm.mov