Fire off network requests as soon as they're queued #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cead22
commented
Aug 18, 2020
Comment on lines
+65
to
+67
| // Try to fire off the request as soon as it's queued so we don't add a delay to every queued command | ||
| // eslint-disable-next-line no-use-before-define | ||
| processNetworkRequestQueue(); |
Contributor
Author
There was a problem hiding this comment.
Everything except for this is just changing names
marcaaron
approved these changes
Aug 18, 2020
| .then(delayedWriteRequest.callback); | ||
| const queuedRequest = networkRequestQueue.shift(); | ||
| request(queuedRequest.command, queuedRequest.data) | ||
| .then(queuedRequest.callback); |
Contributor
There was a problem hiding this comment.
I'm guessing we are ok with not catching whatever error might pop up here for now.
Contributor
There was a problem hiding this comment.
I can't think of a reason why we'd need to beyond making the console.debug show something more useful on mobile than unhandled promise rejection (which it will if you click on it anyway)
AndrewGable
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processNetworkRequestQueue()call in the now calledqueueRequest