Extract emojis from paste text

[jeet-dhandha]

Details

• Emojis from pasted text in Composer are now added to the frequently used emojis section.

Fixed Issues

$ #21786
PROPOSAL: #21786 (comment)

Tests

1. Open any chat.
2. Enter some emojis in a text editor and copy that message. (You can also try copying emojis from a previously sent message.)
3. Now paste it in the composer.
4. Verify that the emojis are added in frequently used emojis section.

• Verify that no errors appear in the JS console

Offline tests

1. Open any chat.
2. Enter some emojis in a text editor and copy that message. (You can also try copying emojis from a previously sent message.)
3. Now paste it in the composer.
4. Verify that the emojis are added in frequently used emojis section.

QA Steps

1. Open any chat.
2. Enter some emojis in a text editor and copy that message. (You can also try copying emojis from a previously sent message.)
3. Now paste it in the composer.
4. Verify that the emojis are added in frequently used emojis section.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

EmojiPasteFix-Chrome-min.mp4

Mobile Web - Chrome

EmojiPasteFix-Mobile-Chrome-min.mp4

Mobile Web - Safari

EmojiPasteFix-Mobile-Safari-min.mp4

Desktop

EmojiPasteFix-Desktop-min.mp4

iOS

EmojiPasteFix-iOS-min.mp4

Android

EmojiPasteFix-Android-min.mp4

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

We should also update ReportActionItemMessageEdit?

[jeet-dhandha]

Also i am glad @parasharrajat that you have been great at pointing out each steps. 🤗

[jeet-dhandha]

Done with the changes @parasharrajat. Please ping if there are any more.

[parasharrajat]

Please update ReportActionItemMessageEdit as well.

[parasharrajat]

There is a request above if you missed it.

[parasharrajat]

Please update ReportActionItemMessageEdit as well. This is the third time I am repeating this. Please read all the comments.

[jeet-dhandha]

@parasharrajat Please check slack https://expensify.slack.com/archives/C01GTK53T8Q/p1689935412377979

[parasharrajat]

My bad. Sorry for the confusion.

[parasharrajat]

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

[jeet-dhandha]

Do i need to send them individually ? As i have already attached them in PR.

[jeet-dhandha]

Screenshots/Videos

Web

EmojiFrequentPaste-Chrome-min.mp4

Mobile Web - Chrome

EmojiFrequentPaste-WebChrome-min.mp4

Mobile Web - Safari

EmojiFrequentPaste-WebSafari-min.mp4

Desktop

EmojiFrequentPaste-Desktop-min.mp4

iOS

EmojiFrequentPaste-iOS-min.mp4

Android

EmojiFrequentPaste-Android-min.mp4

[parasharrajat]

Lol, those screenshots' comment is for me. There is no action left for you for now.

[jeet-dhandha]

Will send again its gonna take some time 😢 .

[parasharrajat]

It does not work for me on the web.

Screen.Recording.2023-07-21.at.9.20.49.PM.mov

[jeet-dhandha]

Solution 1

function extractEmojis(text) {
    const emojis = [];

    if (!text) {
        return [];
    }

    // Parsed Emojis with skin tone - Eg: ['👩🏻', '👩🏼', '👩🏽', '👩🏾', '👩🏿', '👩🏻', '👩🏼', '👩🏽', '👩🏾', '👩🏿']
    const parsedEmojis = text.match(CONST.REGEX.EMOJIS);

    if (!parsedEmojis) {
        return [];
    }

    const alreadyParsedEmojis = new Set();

    for (let i = 0; i < parsedEmojis.length; i++) {
        const character = parsedEmojis[i];
        const emoji = Emojis.emojiCodeTableWithSkinTones[character];
        if (emoji && !alreadyParsedEmojis.has(emoji.code)) {
            alreadyParsedEmojis.add(emoji.code);
            emojis.push(emoji);
        }
    }

    return emojis;
}

Solution 2

function extractEmojis(text) {
    if (!text) {
        return [];
    }

    // Parsed Emojis with skin tone - Eg: ['👩🏻', '👩🏼', '👩🏽', '👩🏾', '👩🏿', '👩🏻', '👩🏼', '👩🏽', '👩🏾', '👩🏿']
    const parsedEmojis = text.match(CONST.REGEX.EMOJIS);

    if (!parsedEmojis) {
        return [];
    }

    const emojiCodes = new Set();

    return parsedEmojis.reduce((acc, character) => {
        const emoji = Emojis.emojiCodeTableWithSkinTones[character];
        
        if (emoji && !emojiCodes.has(emoji.code)) {
                emojiCodes.add(emoji.code);
                acc.push(emoji);
        }

        return acc;
    }, []);
}

[parasharrajat]

I didn't understand at all the purpose of posting these diffs. Are you asking to pick one of these? Can you please tell me your reasoning for the suggestions I posted?

Again, if you think those suggestions work. I see that that solution can eliminate pushing into both Set and array.

let's just do this and later Marc can suggest improvements if any.

[jeet-dhandha]

I am little confused here where are you getting the alreadyParsedEmojis constant without defining it.

[jeet-dhandha]

Going with solution one.

[parasharrajat]

alreadyParsedEmojis that will be emoji set which was created earlier in the logic. Updated suggestion snippet.

[jeet-dhandha]

Done with the changes @parasharrajat

[jeet-dhandha]

But @parasharrajat don't we need the whole object instead of just emoji ?

[parasharrajat]

Good question. Let me check.

[jeet-dhandha]

[ '🤔' ] - Not this
[ {name: 'thinking', code: '🤔'} ] - but this.

[parasharrajat]

Suggested change

	const alreadyParsedEmojis = new Set();
	// Text can contain similar emojis as well as their skin tone variants. Create a Set to remove duplicate emojis from the search.
	const alreadyParsedEmojis = new Set();

[parasharrajat]

Suggested change

	if (emoji && !alreadyParsedEmojis.has(emoji.code)) {
	// Add the parsed emoji to the final emojis if not already present.
	if (emoji && !alreadyParsedEmojis.has(emoji.code)) {

[parasharrajat]

Suggested change

	const alreadyParsedEmojis = new Set();
	const foundEmojiCodes = new Set();

Rename the variable to better match its content.

[parasharrajat]

let's do the preceding changes instead.

I am not against using reduce but this primitive logic is fine too IMO.

[jeet-dhandha]

Done @parasharrajat

[jeet-dhandha]

Finally Done ✅

[parasharrajat]

LGTM. Let's wait for @marcaaron's review.

[marcaaron]

Thanks for the teamwork! Looks much better 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅