[Feat #23130] Add custom status settings to profile by hannojg · Pull Request #23267 · Expensify/App

hannojg · 2023-07-20T12:18:32Z

Details

This is the first part of a series of PRs to implement the UI for the new custom status feature.
It implements the Status option in the profile settings, and the screen to set a status.
As this feature is incomplete yet and build in iterations it will be hidden behind the customStatus beta.

Fixed Issues

$ #23130
PROPOSAL:

Tests

Add the customStatus beta to your account or simply let this function return true
Navigate to settings
Navigate to settings
Verify there is the "Status" option
Navigate to the status screen
Verify that you can assign a emoji and a message

Offline tests

QA Steps

Same as testing

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-06.at.14.56.40.mov

Mobile Web - Chrome

Screen.Recording.2023-08-06.at.15.03.19.mov

Mobile Web - Safari

mWebIos.mp4

Desktop

Screen.Recording.2023-08-06.at.15.02.11.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-06.at.15.08.02.mp4

Android

telegram-cloud-document-2-5366357118599312182.mp4

hannojg · 2023-07-24T06:52:17Z

…into feat/#Expensify#23130-status-page-settings

src/components/EmojiPicker/EmojiPickerButtonDropdown.js

narefyev91 · 2023-08-07T09:12:46Z

src/components/StaticHeaderPageLayout.js

+    children: PropTypes.node.isRequired,
+
+    /** The illustration to display in the header. Can be either an SVG component or a JSON object representing a Lottie animation. */
+    // illustration: PropTypes.oneOfType([PropTypes.func, PropTypes.object]).isRequired,


do we need this?

oops, cleaned
thanks!

narefyev91 · 2023-08-07T09:13:59Z

src/components/StaticHeaderPageLayout.js

+                    <HeaderWithBackButton
+                        // eslint-disable-next-line react/jsx-props-no-spreading
+                        {...propsToPassToHeader}
+                        titleColor={backgroundColor === themeColors.appBG ? undefined : themeColors.textColorfulBackground}


i think we can define a variable and put this backgroundColor === themeColors.appBG ? undefined : themeColors.textColorfulBackground - in case it's duplicating multiple times

the first one ending with textColorfulBackground and the second with iconColorfulBackground so they are different
I moved it out of the render

narefyev91 · 2023-08-07T09:14:26Z

src/components/StaticHeaderPageLayout.js

+                                    style={styles.staticHeaderImage}
+                                />
+                            </View>
+                            <View style={[styles.pt5]}>{children}</View>


no needs for []

narefyev91 · 2023-08-07T09:20:11Z

src/pages/settings/Profile/CustomStatus/StatusPage.js

+        User.clearDraftCustomStatus();
+    };
+
+    const footerComponent = useMemo(


i will say that here we do not need memoization - because you returning JSX which is not a heavy calculation - also moving this code directly in render - removes not needed useCallback for updateStatus - because Button component is still a Class which is extended on Component (not PureComponent) and it will be re-rendered in any case.

As we gradually migrate all Class components to FC, it's prudent to prepare our code accordingly. Even if the Button component were to be a highly optimized FC, the onPress={updateStatus} would still trigger a re-render. So, I think it makes sense to use useCallback here, as well as useMemo. @hannojg, what do you think?

Not sure if i agree with re-render for button - if it will be correctly specified with React.memo - it will be re-renders only if any of the props will be changed. Also if we talking about FC - i see that a lot of components still not have memo wrappers - which means that most of the useCallbacks still not needed, as an example in your code a little above src/components/EmojiPicker/EmojiPickerButtonDropdown.js - you have onPress function which is not wrapped in useCallback, because PressableWithoutFeedback - is not memoized. Also your useCallback will be re-creates every time because defaultEmoji, and defaultText are not memoized and will be new for any re-render. And making them memoized doesn't make any sense because both are not expensive calculations - as the result - memoized all that items will not bring and performance improvements but will keep more memory :-)

👍🏻 okay, I'll remove it

src/pages/settings/Profile/CustomStatus/StatusPage.js

narefyev91 · 2023-08-07T10:45:13Z

src/components/StaticHeaderPageLayout.js

+function StaticHeaderPageLayout({backgroundColor, children, image: Image, footer, imageContainerStyle, style, ...propsToPassToHeader}) {
+    const {windowHeight} = useWindowDimensions();
+
+    const titleColor = useMemo(() => (backgroundColor === themeColors.appBG ? undefined : themeColors.textColorfulBackground), [backgroundColor]);


const {titleColor, iconFill } = useMemo(() => {your logic here}) - you have the same check backgroundColor === themeColors.appBG - and both logic can be combined in one.

narefyev91 · 2023-08-08T11:57:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

8mb.video-0YB-PWNy2X2C.mp4

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

Some code clean up should be made - but those changes will not really effect user experience - i tested on all platforms - working fine. We need to get approves from design team and internal dev as well
🎀 👀 🎀 C+ reviewed

stitesExpensify

Code is looking pretty good! Just a couple of small comments

stitesExpensify · 2023-08-08T20:37:15Z

src/pages/settings/Profile/ProfilePage.js

            pageRoute: ROUTES.SETTINGS_CONTACT_METHODS,
            brickRoadIndicator: contactMethodBrickRoadIndicator,
        },
+        ...(Permissions.canUseCustomStatus(props.beta)


Suggested change

...(Permissions.canUseCustomStatus(props.beta)

...(Permissions.canUseCustomStatus(props.betas)

This variable is wrong

stitesExpensify · 2023-08-08T20:41:35Z

src/pages/settings/Profile/CustomStatus/StatusPage.js

+                inputID="test"
+                onPress={() => Navigation.navigate(ROUTES.SETTINGS_STATUS_SET)}
+            />
+            <MenuItemWithTopDescription


Let's get rid of this for now since it doesn't do anything. We can add it in the PR for making this work

stitesExpensify · 2023-08-08T20:55:04Z

src/pages/settings/Profile/CustomStatus/StatusPage.js

+    const hasDraftStatus = !!draftEmojiCode || !!draftText;
+
+    const updateStatus = useCallback(() => {
+        const endOfDay = new Date();


I think that we can do this cleaner/easier using moment.js endOf method

stitesExpensify · 2023-08-08T21:45:19Z

src/pages/settings/Profile/CustomStatus/StatusSetPage.js

+    const defaultEmoji = lodashGet(draftStatus, 'emojiCode') || lodashGet(currentUserPersonalDetails, 'status.emojiCode', '💬');
+    const defaultText = lodashGet(draftStatus, 'text') || lodashGet(currentUserPersonalDetails, 'status.text', '');
+
+    const onSubmit = (v) => {


Why v? I think we should change this to have a more descriptive variable name

Just a shortcut. I replaced it with the fully spelled version

…pensify#23130-status-page-settings

stitesExpensify

Looking great just one last comment!

src/ONYXKEYS.js

src/pages/settings/Profile/CustomStatus/StatusPage.js

OSBotify · 2023-08-09T15:25:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-10T20:32:04Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-14T19:39:56Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.53-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

eVoloshchak · 2023-10-27T13:57:11Z

src/components/EmojiPicker/EmojiPickerButtonDropdown.js

+    const emojiPopoverAnchor = useRef(null);
+    useEffect(() => EmojiPickerAction.resetEmojiPopoverAnchor, []);
+
+    const onPress = () =>


Coming from #29093
I wouldn't call it a regression per se, but rather a case that was missed/not planned, but the button didn't toggle an emoji picker (i.e. pressing a button when the emoji picker is already open didn't close it)

allroundexperts · 2023-11-28T09:44:32Z

src/components/EmojiPicker/EmojiPickerButtonDropdown.js

+                onPress={onPress}
+                nativeID="emojiDropdownButton"
+                accessibilityLabel="statusEmoji"
+                accessibilityRole="text"


Setting accessibilityRole as text caused #29097. This should have been button instead.

hannojg changed the title ~~[Feat #23130] Add custom status settings to profile~~ [WIP][Feat #23130] Add custom status settings to profile Jul 20, 2023

wip: adding status page

ccd3017

hannojg force-pushed the feat/##23130-status-page-settings branch from eccc84e to ccd3017 Compare July 20, 2023 12:43

wip

cf6fa1c

perunt added 20 commits July 30, 2023 11:49

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

95d18ee

…into feat/#Expensify#23130-status-page-settings

add routes

725f8eb

add const

10b1779

update onyx keys

f054f6f

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

c7e3c84

…into feat/#Expensify#23130-status-page-settings

add svg

f5bdc40

add translations

87fcf74

update StatusPage

bd5ff5d

create analog for IllustratedHeaderPageLayout

5a8f8b1

add actions

5052d01

create StatusSetPage

c414d49

display status on profilePage

591a518

create EmojiPickerButtonDropdown

43d6e53

remove link to ClearAfter

c126d26

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

577d412

…into feat/#Expensify#23130-status-page-settings

use lodashGet

8a97e33

prettier

71cac3a

remove todo

6bc1743

remove unused set date

4856a08

add betas flag for status

4e0d0f2

stitesExpensify assigned hannojg Aug 4, 2023

stitesExpensify marked this pull request as ready for review August 4, 2023 15:05

stitesExpensify requested a review from a team as a code owner August 4, 2023 15:05

melvin-bot bot requested review from narefyev91 and removed request for a team August 4, 2023 15:05

Merge branch 'main' of https://github.com/margelo/expensify-app-fork …

7b9eaf3

…into feat/#Expensify#23130-status-page-settings

narefyev91 reviewed Aug 7, 2023

View reviewed changes

src/components/EmojiPicker/EmojiPickerButtonDropdown.js Show resolved Hide resolved

narefyev91 reviewed Aug 7, 2023

View reviewed changes

src/pages/settings/Profile/CustomStatus/StatusPage.js Show resolved Hide resolved

clean code

805ce5e

narefyev91 reviewed Aug 7, 2023

View reviewed changes

update titleColor and iconFill

e914658

narefyev91 approved these changes Aug 8, 2023

View reviewed changes

stitesExpensify reviewed Aug 8, 2023

View reviewed changes

perunt added 3 commits August 9, 2023 10:00

clean

d416ddc

Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…

e34095c

…pensify#23130-status-page-settings

lint

ce4f923

stitesExpensify requested changes Aug 9, 2023

View reviewed changes

src/ONYXKEYS.js Outdated Show resolved Hide resolved

src/pages/settings/Profile/CustomStatus/StatusPage.js Outdated Show resolved Hide resolved

remove onyx key

b36faec

stitesExpensify approved these changes Aug 9, 2023

View reviewed changes

stitesExpensify merged commit 457c6df into Expensify:main Aug 9, 2023

OSBotify mentioned this pull request Aug 10, 2023

Deploy Checklist: New Expensify 2023-08-10 #24388

Closed

45 tasks

melvin-bot bot mentioned this pull request Aug 14, 2023

[HOLD for payment 2023-08-21] [Custom Status] Add Main Custom Status page for setting / manually clearing status #23130

Closed

burczu mentioned this pull request Aug 17, 2023

Display status emojis in the LHN (including the user's own status) #24414

Merged

59 tasks

kbecciv mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-27] [$250] Dev: Emojipicker in Set status page has a text cursor instead of pointer #29097

Closed

6 tasks

eVoloshchak reviewed Oct 27, 2023

View reviewed changes

eVoloshchak mentioned this pull request Oct 27, 2023

[$500] [HOLD for payment 2023-10-27] EmojiPicker popover in Status picker is not toggle popover #29093

Closed

6 tasks

allroundexperts reviewed Nov 28, 2023

View reviewed changes

	...(Permissions.canUseCustomStatus(props.beta)
	...(Permissions.canUseCustomStatus(props.betas)

Conversation

hannojg commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

hannojg commented Jul 24, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Aug 8, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

OSBotify commented Aug 14, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannojg commented Jul 20, 2023 •

edited

Loading