Skip to content

Revert "Apple sign-in" #23295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcochavezf merged 1 commit into from
Jul 20, 2023
Merged

Revert "Apple sign-in" #23295

marcochavezf merged 1 commit into from
Jul 20, 2023

Conversation

@iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jul 20, 2023

Reverts #16723

Due to #23285 (comment)

@iwiznia iwiznia requested a review from a team as a code owner July 20, 2023 18:51
@iwiznia iwiznia self-assigned this Jul 20, 2023
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team July 20, 2023 18:51
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@iwiznia iwiznia requested review from marcochavezf and removed request for techievivek July 20, 2023 18:56
@marcochavezf marcochavezf merged commit 948f7a1 into main Jul 20, 2023
@marcochavezf marcochavezf deleted the revert-16723-apple-sign-in branch July 20, 2023 19:08
@melvin-bot melvin-bot bot added the Emergency label Jul 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

@marcochavezf looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@marcochavezf
Copy link
Contributor

marcochavezf commented Jul 20, 2023

Removing emergency label since it was direct revert that caused some regressions.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 20, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 21, 2023
@marcochavezf @OSBotify
Merge pull request #23295 from Expensify/revert-16723-apple-sign-in
97a29a8 
Revert "Apple sign-in"

(cherry picked from commit 948f7a1)
@OSBotify
Copy link
Contributor

OSBotify commented Jul 21, 2023

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.43-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Nikhil-Vats Nikhil-Vats mentioned this pull request Jul 21, 2023
Closed
6 tasks
@OSBotify OSBotify mentioned this pull request Jul 21, 2023
Closed
lindboe added a commit to infinitered/ExpensifyApp that referenced this pull request Jul 21, 2023
@lindboe
Revert "Merge pull request Expensify#23295 from Expensify/revert-1672…
e30d9d2 
…3-apple-sign-in"

This reverts commit 948f7a1, reversing
changes made to 99519f2.
@OSBotify
Copy link
Contributor

OSBotify commented Jul 22, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.43-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 25, 2023
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 25, 2023

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.45-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jul 26, 2023

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcochavezf marcochavezf marcochavezf approved these changes

Assignees

@iwiznia iwiznia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iwiznia @marcochavezf @OSBotify