Conversation
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebSkipped because this is a straight revert and nothing depends on the new library yet. Mobile Web - ChromeSkipped because this is a straight revert and nothing depends on the new library yet. Mobile Web - SafariSkipped because this is a straight revert and nothing depends on the new library yet. DesktopSkipped because this is a straight revert and nothing depends on the new library yet. iOSSkipped because this is a straight revert and nothing depends on the new library yet. AndroidSkipped because this is a straight revert and nothing depends on the new library yet. |
…animated-340 Revert "Bump Reanimated to 3.4.0" (cherry picked from commit 0435b6a)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.46-2 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀
|
Reverts #23550
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.