Refactor `EmojiPickerMenu` native to functional component and using `scrollTo` method by shubham1206agra · Pull Request #23854 · Expensify/App

shubham1206agra · 2023-07-29T12:12:35Z

Details

Fixed Issues

$ #23716
PROPOSAL: #23716 (comment)

Tests / QA Steps

Access a conversation chat with another user.
Long press on any of your messages.
Tap the "emoji reaction" icon.
Tap the "emoji" icon that is above the "Frequently used label".

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Screen.Recording.2023-07-29.at.5.11.45.PM.mov

Android

Screen.Recording.2023-07-29.at.5.22.23.PM.mov

github-actions · 2023-07-29T12:12:51Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

shubham1206agra · 2023-07-29T12:13:27Z

I have read the CLA Document and I hereby sign the CLA

shubham1206agra · 2023-07-29T12:13:44Z

recheck

melvin-bot · 2023-07-29T12:16:32Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/EmojiPicker/EmojiPickerMenu/index.native.js

mananjadhav · 2023-07-30T04:53:50Z

@shubham1206agra Let's rebump the reanimated version to 3.4.0, without that we won't be able to test the crash.

shubham1206agra · 2023-07-30T12:03:39Z

@mananjadhav Let me rebump in a separate PR so that any other problem with v3.4 should not revert this PR as it works at v3.1 also.

mananjadhav · 2023-07-30T14:13:46Z

@shubham1206agra the challenge for the us to reproduce the crash would then require two PRs. Are you suggesting you'll raise another PR right after this is merged? I think it's double the effort.

shubham1206agra · 2023-07-30T14:16:17Z

I can open the PR simultaneously and add the note here if in any case this PR should be reverted, revert the bump too

shubham1206agra · 2023-07-30T14:17:43Z

@shubham1206agra the challenge for the us to reproduce the crash would then require two PRs. Are you suggesting you'll raise another PR right after this is merged? I think it's double the effort.

Let's merge the rebump first.
You can in this case easily reproduce the problem

mananjadhav · 2023-07-31T03:54:25Z

@shubham1206agra The app crashes on when I submit an emoji.

shubham1206agra · 2023-07-31T04:42:56Z

Can you quickly send me error log or repro steps

mananjadhav · 2023-07-31T04:46:35Z

Steps to reproduce on mobile app:

Open any chat
Click on the Emoji icon on the composer
Select one of the emojis, and click on Send.

shubham1206agra · 2023-07-31T04:51:37Z

Can't reproduce it

Screen.Recording.2023-07-31.at.10.19.54.AM.mov

shubham1206agra · 2023-07-31T04:52:48Z

Send me the error log so I can check what's the issue

shubham1206agra · 2023-07-31T05:12:35Z

Still can't reproduce :(

shubham1206agra · 2023-07-31T06:25:38Z

@mananjadhav ??

shubham1206agra · 2023-07-31T06:42:42Z

@mananjadhav Looks like you haven't downgraded to v3.1

See this #23151 (comment)

mountiny · 2023-07-31T08:50:38Z

@shubham1206agra @mananjadhav Jumping in for urgency purposes of the RN 0.72 update #18507 we also need to bump the reanimated version here to 3.4.0. Can you please do that? Will the App not crash after the update?

mountiny · 2023-07-31T13:12:48Z

SWM will look into this

shubham1206agra · 2023-07-31T14:30:59Z

SWM will look into this

It is done. You can test now. It should be working fine now. :)

shubham1206agra · 2023-07-31T14:36:39Z

This PR software-mansion/react-native-reanimated#4503 introduced changes to _updatePropsPaper function.

We should also look out for software-mansion/react-native-reanimated#4595 in the future updates once merged.

shubham1206agra · 2023-07-31T14:43:18Z

@mananjadhav @mountiny Can you check now?

mountiny · 2023-07-31T15:18:19Z

Thanks @shubham1206agra! Can you please retest now @shubham1206agra

mananjadhav · 2023-07-31T15:19:13Z

@mountiny I think you meant me? I'll be on this in an hour.

mountiny · 2023-07-31T15:21:57Z

Correct haha thanks

mananjadhav · 2023-07-31T17:17:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-reanimated-upgrade.mov

Mobile Web - Chrome

mweb-chrome-reanimated-upgrade.mov

Mobile Web - Safari

mweb-safari-reanimated-upgrade.mov

Desktop

desktop-reanimated-upgrade.mov

iOS

ios-reanimated-upgrade.mov

Android

android-reanimated-upgrade.mov

mananjadhav · 2023-07-31T17:19:00Z

@shubham1206agra Thanks for the updated changes. This works fine.

@stitesExpensify @mountiny This seems to be working fine.

🎀 👀 🎀 C+ reviewed.

mountiny · 2023-08-01T09:27:08Z

Going to merge this to speed up the react native update

melvin-bot · 2023-08-01T09:28:02Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2023-08-01T09:30:19Z

There was an old checklist, everything checked off on the latest one

OSBotify · 2023-08-01T09:37:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-02T01:22:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T17:43:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:15:00Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:32:15Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra added 2 commits July 29, 2023 08:56

converted emojipickermenu native to functional component

9848482

small bug fix

882a134

shubham1206agra marked this pull request as ready for review July 29, 2023 12:16

shubham1206agra requested a review from a team as a code owner July 29, 2023 12:16

melvin-bot bot requested review from mananjadhav and removed request for a team July 29, 2023 12:16

mananjadhav reviewed Jul 30, 2023

View reviewed changes

src/components/EmojiPicker/EmojiPickerMenu/index.native.js Outdated Show resolved Hide resolved

removed unecessary comment

41a9f04

mananjadhav approved these changes Jul 31, 2023

View reviewed changes

melvin-bot bot requested a review from stitesExpensify July 31, 2023 03:48

Merge branch 'Expensify:main' into emojipickermenu-native-functional

f3e0d48

fabioh8010 mentioned this pull request Jul 31, 2023

Update App to React Native 0.72 version #18507

Merged

57 tasks

updated for newer definition

d45112b

mountiny approved these changes Aug 1, 2023

View reviewed changes

mountiny merged commit 52b8ddc into Expensify:main Aug 1, 2023

melvin-bot bot added the Emergency label Aug 1, 2023

mountiny removed the Emergency label Aug 1, 2023

Expensify deleted a comment from mananjadhav Aug 1, 2023

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

This was referenced Aug 2, 2023

Gyroscope-driven animations of empty chats #23737

Merged

Payment issue for E/App PR#23550 #23564

Closed

shubham1206agra mentioned this pull request Aug 2, 2023

[HOLD][$250] Migrate index.native.js to function component #16146

Closed

1 task

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

melvin-bot bot mentioned this pull request Aug 3, 2023

[HOLD for payment 2023-08-10] [$1000] Android - Emoji - App crashes after selecting Emoji icon that is above the "Frequently used label" #23716

Closed

6 tasks

shubham1206agra deleted the emojipickermenu-native-functional branch August 16, 2023 12:38

Conversation

shubham1206agra commented Jul 29, 2023

Details

Fixed Issues

Tests / QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jul 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Jul 29, 2023

Uh oh!

shubham1206agra commented Jul 29, 2023

Uh oh!

melvin-bot bot commented Jul 29, 2023

Uh oh!

Uh oh!

mananjadhav commented Jul 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Jul 30, 2023

Uh oh!

mananjadhav commented Jul 30, 2023

Uh oh!

shubham1206agra commented Jul 30, 2023

Uh oh!

shubham1206agra commented Jul 30, 2023

Uh oh!

mananjadhav commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

mananjadhav commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

mountiny commented Jul 31, 2023

Uh oh!

mountiny commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

shubham1206agra commented Jul 31, 2023

Uh oh!

mountiny commented Jul 31, 2023

Uh oh!

mananjadhav commented Jul 31, 2023

Uh oh!

mountiny commented Jul 31, 2023

Uh oh!

mananjadhav commented Jul 31, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Aug 1, 2023

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

mountiny commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 2, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

github-actions bot commented Jul 29, 2023 •

edited

Loading

mananjadhav commented Jul 30, 2023 •

edited

Loading

mananjadhav commented Jul 31, 2023 •

edited

Loading