Fix: Composer top padding collapsed in room after scroll up #23992

procrastagonist · 2023-08-01T11:47:14Z

Details

If it's multi-user chatroom or concierge room composer top padding was collapsed in room after scroll up. I updated styling of ReportFooter and ReportActionsList components.

Fixed Issues

$ #22389
PROPOSAL: #22389 (comment)

Tests

Test 1

Go to a 1-to-1 room with any user
Add some chats until we can scroll up the screen
Scroll to the bottom and scroll up
Turn off your network connection
Scroll to the bottom and scroll up
Verify that composer looks correct and paddings are not collapsed

Test 2

Create own workspace if you don't have
Go to the announce room of your workspace
Add some chats until we can scroll up the screen
Scroll to the bottom and scroll up
Verify that composer looks correct and paddings are not collapsed

Test 3

Create own workspace if you don't have
Go to the announce room of your workspace
Add some chats until we can scroll up the screen
Delete your workspace, this will mark announce room as archived
Go to the archived announce room.
Scroll to the bottom and scroll up
Turn off your network connection
Scroll to the bottom and scroll up
Verify that paddings around ReportFooter are not collapsed

Test 4

As UserA, create own workspace if you don't have
As UserA, go to the announce room of your workspace
As UserA, add some chats until we can scroll up the screen
As UserA, go to workspace settings and change "Who can post" to "Admins only"
As UserA, add UserB to this workspace.
As UserB, go to the announce room of UserA's workspace
As UserB, scroll to the bottom and scroll up
As UserB, verify that bottom area looks correct

Test 5

Open public room (I used https://staging.new.expensify.com/r/5303403427249671) as anonymous user
Scroll to the bottom and scroll up
Verify that paddings around ReportFooter are not collapsed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as "Tests" Section above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

desktop-22389.mp4

Mobile Web - Chrome

mobile-web-chrome-22389.mp4

Mobile Web - Safari

mobile-safari-22389.mp4

Desktop

desktop-22389.mp4

iOS

ios-22389.mp4

Android

android-22389.mp4

2. Updated styling of messages scrollarea

melvin-bot · 2023-08-01T11:47:19Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

procrastagonist · 2023-08-01T11:48:35Z

@situchan @marcaaron #22389 . I will upload screencast for iOS, Android and mobile Chrome soon

procrastagonist · 2023-08-01T13:44:57Z

Uploaded last videos for iOS, Android and web mobile Chrome. Ready for review

… hidden composer

procrastagonist · 2023-08-01T19:12:56Z

@situchan

Fixed MentionSuggestions position

Removed gap under report list with hidden composer

Ready for review.

src/pages/home/report/ReportFooter.js

src/pages/home/report/ReportActionsList.js

mkhutornyi

Looks good to me.
All yours @situchan

src/pages/home/report/ReportActionsList.js

procrastagonist · 2023-08-02T21:34:46Z

Thanks for review @mkhutornyi! So the ball is on your side @situchan ;)

situchan · 2023-08-02T22:08:48Z

@mkarkachov Not sure what to verify. Please add "Verify that ..." at the end of Tests step

situchan · 2023-08-02T22:37:11Z

@mkarkachov please add all possible cases in Tests step:

DM (which shows local time)
Any group chat
Public room where comment is allowed
Public room where comment is not allowed
Archived room
Anonymous user visiting public room

situchan · 2023-08-02T23:14:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

web-anonymous.mov

web-offline.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan · 2023-08-02T23:15:57Z

@mkarkachov please update Tests steps as I request changes - #23992 (comment), #23992 (comment).

And then all good.

procrastagonist · 2023-08-03T05:08:49Z

@mkarkachov please update Tests steps as I request changes - #23992 (comment), #23992 (comment).

And then all good.

@situchan Updated tests as requested

situchan

LGTM
@marcaaron all yours

marcaaron

LGTM - Thanks for the teamwork on this one everyone 💪

OSBotify · 2023-08-03T21:02:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-07T18:55:58Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:45:06Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:14:11Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:52:54Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:11:20Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

procrastagonist added 5 commits July 7, 2023 21:49

1. Added to marging to compose component.

7d723ae

2. Updated styling of messages scrollarea

1. Added to marging to compose component.

f9410ff

2. Updated styling of messages scrollarea

Merged main

0a0d6af

Updated styles of ReportActionsList, ReportFooter components

a1ef999

Merge branch 'main' into fix/issue-22389

f5704ec

procrastagonist requested a review from a team as a code owner August 1, 2023 11:47

melvin-bot bot requested review from situchan and removed request for a team August 1, 2023 11:47

procrastagonist changed the title ~~Fix/issue 22389~~ Fix: Composer top padding collapsed in room after scroll up Aug 1, 2023

mkhutornyi mentioned this pull request Aug 1, 2023

[Awaiting checklist completion] [$1000] Composer top padding collapsed in room after scroll up #22389

Closed

6 tasks

Fixed MentionSuggestions position, removed gap under report list with…

b0a551c

… hidden composer

mkhutornyi reviewed Aug 2, 2023

View reviewed changes

src/pages/home/report/ReportFooter.js Outdated Show resolved Hide resolved

mkhutornyi reviewed Aug 2, 2023

View reviewed changes

src/pages/home/report/ReportActionsList.js Outdated Show resolved Hide resolved

procrastagonist added 2 commits August 2, 2023 15:13

Decreased ReportFooter top margin for archived room

fca7a07

Merge branch 'main' into fix/issue-22389

c0c451f

procrastagonist requested a review from mkhutornyi August 2, 2023 13:38

mkhutornyi reviewed Aug 2, 2023

View reviewed changes

situchan suggested changes Aug 2, 2023

View reviewed changes

src/pages/home/report/ReportActionsList.js Outdated Show resolved Hide resolved

procrastagonist added 2 commits August 2, 2023 20:55

Avoid boolean style for styling view ReportActionsList

3fe6e74

Merge branch 'main' into fix/issue-22389

e457492

procrastagonist requested review from mkhutornyi and situchan August 2, 2023 19:04

mkhutornyi approved these changes Aug 2, 2023

View reviewed changes

situchan approved these changes Aug 3, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron August 3, 2023 09:48

marcaaron approved these changes Aug 3, 2023

View reviewed changes

marcaaron assigned procrastagonist Aug 3, 2023

marcaaron merged commit b08bf66 into Expensify:main Aug 3, 2023

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

Fix: Composer top padding collapsed in room after scroll up #23992

Fix: Composer top padding collapsed in room after scroll up #23992

Uh oh!

Conversation

procrastagonist commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

procrastagonist commented Aug 1, 2023

Uh oh!

procrastagonist commented Aug 1, 2023

Uh oh!

procrastagonist commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkhutornyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

procrastagonist commented Aug 2, 2023

Uh oh!

situchan commented Aug 2, 2023

Uh oh!

situchan commented Aug 2, 2023

Uh oh!

situchan commented Aug 2, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Aug 2, 2023

Uh oh!

procrastagonist commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

procrastagonist commented Aug 1, 2023 •

edited

Loading

procrastagonist commented Aug 1, 2023 •

edited

Loading

procrastagonist commented Aug 3, 2023 •

edited

Loading