[CP Staging] Remove reference to missing method #24010

tgolen · 2023-08-01T15:24:37Z

@NikkiWines @multijump

Details

This method was originally removed in Remove passwordless beta logic #22461
There was a refactoring of BasePaymentsPage.js which added the reference back in refactored BasePaymentsPage to function based component #22412
This PR removes the reference again and hopefully fixes the crash

Fixed Issues

$ #24005

Tests

Launch App
Navigate to Settings -> Payments
Add a new bank account and save it
In the list of payments, click on the newly added bank account
Tap on "Make default payment method"
Verify the app doesn't crash and there are no JS console errors

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

2023-08-01_09-32-35.mp4

Mobile Web - Chrome

Unable to test on mobile web chrome due to #22395

Mobile Web - Safari

2023-08-01_09-54-20.mp4

Desktop

2023-08-01_09-37-58.mp4

iOS

2023-08-01_09-48-41.mp4

Android

2023-08-01_10-06-51.mp4

melvin-bot · 2023-08-01T15:24:43Z

@mollfpr @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-08-01T15:31:50Z

src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

@@ -453,14 +453,7 @@ function BasePaymentsPage(props) {
                                    // InteractionManager fires after the currently running animation is completed.
                                    // https://github.com/Expensify/App/issues/7768#issuecomment-1044879541
                                    InteractionManager.runAfterInteractions(() => {


@tgolen Is runAfterInteractions() still needed? I believe we can remove it because we're just making an API call inside it.

No component state is being changed, so the app freeze described in #7768 shouldn't happen

It wasn't removed in Nikki's PR... which doesn't really answer your question, but I think that could be part of the additional cleanup.

mollfpr · 2023-08-01T15:34:27Z

@rushatgabhane Would you mind taking the review? I didn't have time left and felt unwell to stay up late. Thanks!

rushatgabhane · 2023-08-01T15:35:31Z

feel better soon! @mollfpr

rushatgabhane · 2023-08-01T15:42:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-01.at.21.33.42.mov

Mobile Web - Chrome

WhatsApp.Video.2023-08-01.at.21.41.12.mp4

Mobile Web - Safari

Screen.Recording.2023-08-01.at.21.38.59.mov

Desktop

Screen.Recording.2023-08-01.at.21.46.33.mov

iOS

Screen.Recording.2023-08-01.at.21.37.29.mov

Android

Screen.Recording.2023-08-01.at.21.42.41.mov

Beamanator

I think we can also do more cleanup surrounding showPassword.shouldShowPasswordPrompt and showPassword.passwordButtonText since those will never get updated after this change, right?

tgolen · 2023-08-01T15:51:44Z

How about we just fix the crash for now in this PR?

rushatgabhane · 2023-08-01T15:54:56Z

@tgolen cool, that works too. If you want, I could create a follow up PR to remove deadcode and link it to the same issue.

We still need to fix lint errors tho

Beamanator

Might be fine to not do any refactoring, but as Rushat said - lint is not happy b/c setShowPassword is assigned but not used anywhere

rushatgabhane

LGTM and tests well!

NikkiWines · 2023-08-01T16:13:49Z

src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

    const [shouldShowAddPaymentMenu, setShouldShowAddPaymentMenu] = useState(false);
    const [shouldShowDefaultDeleteMenu, setShouldShowDefaultDeleteMenu] = useState(false);
-    const [showPassword, setShowPassword] = useState({
+    const [showPassword] = useState({


Do we still need showPassword? In what scenario is it going to be true if everyone is passwordless?

will be addressed in a follow up PR #24010 (comment)

That could be addressed in the additional cleanup PR. I think we just stop the crash for now with this PR and CP it.

melvin-bot · 2023-08-01T16:14:05Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen · 2023-08-01T16:17:57Z

OK, should be all tested and have all the videos added that I can

rushatgabhane · 2023-08-01T16:18:24Z

can be merged @Beamanator

[CP Staging] Remove reference to missing method (cherry picked from commit 3bdfd45)

OSBotify · 2023-08-01T16:29:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Beamanator · 2023-08-01T16:32:22Z

CPing 👍

OSBotify · 2023-08-01T17:07:46Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.48-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

JmillsExpensify · 2023-08-01T19:06:24Z

@tgolen or @Beamanator Can either of you confirm, per our new SOX process, that @rushatgabhane should be compensated $1,000 for the review of this PR?

tgolen · 2023-08-01T19:49:22Z

I confirm 👍

OSBotify · 2023-08-01T23:58:27Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T17:43:22Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:31:42Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove reference to missing method

e621934

tgolen requested a review from Beamanator August 1, 2023 15:24

tgolen requested a review from a team as a code owner August 1, 2023 15:24

tgolen self-assigned this Aug 1, 2023

melvin-bot bot requested review from mollfpr and removed request for a team August 1, 2023 15:24

rushatgabhane reviewed Aug 1, 2023

View reviewed changes

Beamanator requested changes Aug 1, 2023

View reviewed changes

Beamanator previously approved these changes Aug 1, 2023

View reviewed changes

Remove unused method

a867bbc

tgolen dismissed Beamanator’s stale review via a867bbc August 1, 2023 16:03

rushatgabhane approved these changes Aug 1, 2023

View reviewed changes

NikkiWines reviewed Aug 1, 2023

View reviewed changes

melvin-bot bot requested a review from youssef-lr August 1, 2023 16:14

Beamanator changed the title ~~Remove reference to missing method~~ [CP Staging] Remove reference to missing method Aug 1, 2023

Beamanator approved these changes Aug 1, 2023

View reviewed changes

Beamanator merged commit 3bdfd45 into main Aug 1, 2023

Beamanator deleted the tgolen-fix-missingmethodcrash branch August 1, 2023 16:25

OSBotify pushed a commit that referenced this pull request Aug 1, 2023

Merge pull request #24010 from Expensify/tgolen-fix-missingmethodcrash

0441436

[CP Staging] Remove reference to missing method (cherry picked from commit 3bdfd45)

rushatgabhane mentioned this pull request Aug 1, 2023

Remove dead code #24014

Merged

58 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

melvin-bot bot mentioned this pull request Aug 1, 2023

[HOLD for payment 2023-08-17] [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Payments - App crashed when try to set default if added BA #24005

Closed

6 tasks

Beamanator mentioned this pull request Aug 2, 2023

[HOLD] Manually CPing a pull request does not add the PR to the checklist #4379

Closed

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

[CP Staging] Remove reference to missing method #24010

[CP Staging] Remove reference to missing method #24010

Uh oh!

Conversation

tgolen commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

rushatgabhane Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen commented Aug 1, 2023

Uh oh!

rushatgabhane commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NikkiWines Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

rushatgabhane Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

tgolen Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

tgolen commented Aug 1, 2023

Uh oh!

rushatgabhane commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 1, 2023

Uh oh!

Beamanator commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 1, 2023

Uh oh!

JmillsExpensify commented Aug 1, 2023

Uh oh!

tgolen commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

tgolen commented Aug 1, 2023 •

edited

Loading

rushatgabhane Aug 1, 2023 •

edited

Loading

mollfpr commented Aug 1, 2023 •

edited

Loading

rushatgabhane commented Aug 1, 2023 •

edited

Loading

rushatgabhane commented Aug 1, 2023 •

edited

Loading

rushatgabhane commented Aug 1, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading