Fix popover menu position for three dots menu and settlement button #24013

Nikhil-Vats · 2023-08-01T16:07:39Z

Details

Fixed Issues

$ #23140
PROPOSAL: #23140 (comment)

Tests

Request money from one of your account to your other account.
Locally, login to the account to which you requested the money (the payer).
Open the Report preview for this and in the header, click on the dropdown icon, the popover menu should open below the button and there should be a gap 8px between the button and menu. For this menu to be visible, currency should be USD and you should have permissions to use the wallet.
Go to settings > payments. Click on add payment method button. There should be a padding of 8px between the button and menu and the menu should open above the button. To verify this, compare the gap in prod and your testing environment.

For task header menu position -

Go to FAB > Assign task. Fill details and click on next to create the task.
Go to the task report.
In the header, on the right, click on the three dots menu.
Verify that menu should not cover the three dots icon, header. It should open below the button.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

23140_web1.mov

23140_web2.mov

Mobile Web - Chrome

23140_mchrome1.mov

23140_mchrome2.mov

Mobile Web - Safari

23140_msafari1.mov

23140_msafari2.mov

Desktop

23140_desktop1.mov

23140_desktop2.mov

iOS

23140_ios1.mov

23140_ios2.mov

Android

23140_android1.mov

23140_android2.mov

melvin-bot · 2023-08-01T16:07:44Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nikhil-Vats · 2023-08-01T16:08:55Z

src/components/MoneyReportHeader.js

            <HeaderWithBackButton
                shouldShowAvatarWithDisplay
                shouldShowPinButton={false}
-                shouldShowThreeDotsButton={false}


This was being passed unnecessarily so I removed it.

Nikhil-Vats · 2023-08-01T16:11:17Z

src/components/HeaderWithBackButton/index.js

    subtitle = '',
    title = '',
    titleColor = undefined,
-    threeDotsAnchorAlignment = {


Three Dots Menu is shown in HeaderWithBackButton only in MoneyRequestHeader and WorkspaceInitialPage and none of them override this since the three dots menu is at top and menu always opens below it. To verify search for - shouldShowThreeDotsButton or threeDotsMenuItems.

Nikhil-Vats · 2023-08-01T16:16:34Z

To test SettlementButton in MoneyRequestConfirmationList to verify menu opens above the button with padding. Add true || in below lines (because it is only visible for send money which is disabled) -

App/src/components/SettlementButton.js

Lines 106 to 107 in 9dc5f19

    
           const canUseWallet = 
        
               !isExpenseReport && this.props.currency === CONST.CURRENCY.USD && Permissions.canUsePayWithExpensify(this.props.betas) && Permissions.canUseWallet(this.props.betas);

App/src/components/MoneyRequestConfirmationList.js

Line 256 in 9dc5f19

return shouldShowSettlementButton ? (

Nikhil-Vats · 2023-08-01T17:51:07Z

Hey @situchan, PR is ready for review.

situchan · 2023-08-02T20:13:42Z

Code looks good. Thanks for the detailed comments per each change.

situchan · 2023-08-02T21:00:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

LGTM
@Julesssss all yours

Nikhil-Vats · 2023-08-04T13:24:08Z

Hey @Julesssss, friendly bump here.

Nikhil-Vats · 2023-08-06T18:25:37Z

Hey @situchan @Julesssss, there was a minor merge conflict here but it was not related at all to this feature -

See the changes in the latest merge commit to verify yourself.

I have still verified that the feature works as expected after the latest merge -

Screen.Recording.2023-08-06.at.11.48.56.PM.mov

Screen.Recording.2023-08-06.at.11.49.36.PM.mov

Julesssss · 2023-08-07T12:53:00Z

I was away on Thursday/Friday

OSBotify · 2023-08-07T13:20:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-07T18:54:37Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:43:45Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:12:41Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:51:24Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:09:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Nikhil-Vats added 2 commits August 1, 2023 20:26

Fix position of settlement button popover menu

fc2c0b4

Fix task header three dots menu popover position

742cea2

Nikhil-Vats requested a review from a team as a code owner August 1, 2023 16:07

melvin-bot bot requested review from situchan and removed request for a team August 1, 2023 16:07

Nikhil-Vats commented Aug 1, 2023

View reviewed changes

Julesssss assigned Nikhil-Vats Aug 2, 2023

situchan approved these changes Aug 2, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss August 2, 2023 21:03

Merge branch 'main' into 23140_fix_popover_menu_position

4d0df0c

Julesssss approved these changes Aug 7, 2023

View reviewed changes

Julesssss merged commit 474a8f1 into Expensify:main Aug 7, 2023

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

melvin-bot bot mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-16] [$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button #23140

Closed

6 tasks

Nikhil-Vats mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-10-16] [$500] Add payment method popover has wrong position #26070

Closed

6 tasks

Fix popover menu position for three dots menu and settlement button #24013

Fix popover menu position for three dots menu and settlement button #24013

Uh oh!

Conversation

Nikhil-Vats commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 1, 2023

Uh oh!

Nikhil-Vats Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

Nikhil-Vats Aug 1, 2023

Choose a reason for hiding this comment

Uh oh!

Nikhil-Vats commented Aug 1, 2023

Uh oh!

Nikhil-Vats commented Aug 1, 2023

Uh oh!

situchan commented Aug 2, 2023

Uh oh!

situchan commented Aug 2, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Nikhil-Vats commented Aug 4, 2023

Uh oh!

Nikhil-Vats commented Aug 6, 2023

Uh oh!

Julesssss commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Nikhil-Vats commented Aug 1, 2023 •

edited

Loading