migrate ReportScreen.js by SosenWiosen · Pull Request #24111 · Expensify/App

SosenWiosen · 2023-08-03T13:40:30Z

Details

This pull request migrates ReportScreen from being a class component to a functional component.

Fixed Issues

$ #16255

Tests

Send a simple text message in a room.
Send a picture.
Send request to split bill.
Exit the room on another device and check if you get navigated to concierge.

Verify that no errors appear in the JS console

Offline tests

When in a room, check if OfflineIndicator is visible.
Try to send a simple text message.
Try to send a picture.
Try to send a request to split bill.

QA Steps

Send a simple text message in a room.
Send a picture.
Send request to split bill.
Exit the room on another device and check if you get navigated to concierge.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/43684335/1a2e90a8-a6a6-4e67-90ec-a80e1491814a

Mobile Web - Chrome

android.chrome.test.mp4

Mobile Web - Safari

https://github.com/Expensify/App/assets/43684335/618324ab-b091-4923-bca2-cb98da92034a

Desktop

https://github.com/Expensify/App/assets/43684335/fafce4e8-e3c5-4d13-9b99-afd8d4e3f86d

iOS

https://github.com/Expensify/App/assets/43684335/8102730d-da5d-453e-81d0-59804082323d

Android

https://github.com/Expensify/App/assets/43684335/b7a5e9d0-610e-4c15-bc88-aa67c0a5e428

github-actions · 2023-08-03T13:40:47Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

SosenWiosen · 2023-08-03T13:41:08Z

I have read the CLA Document and I hereby sign the CLA

SosenWiosen · 2023-08-03T14:12:19Z

Recheck

melvin-bot · 2023-08-04T14:34:12Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

SosenWiosen · 2023-08-04T14:36:41Z

In one of the videos there's a warning. It is because of a regression from another PR (not connected with my code), and has already been reported on slack.

SosenWiosen · 2023-08-04T15:55:10Z

Recheck

…n-component

neil-marcellini · 2023-08-07T17:55:59Z

Bump @aimane-chnaif

aimane-chnaif · 2023-08-10T05:56:27Z

@SosenWiosen please fix conflict

…js-to-function-component

SosenWiosen · 2023-08-10T11:16:48Z

Merged it and resolved conflicts. Still passes my tests.

SosenWiosen · 2023-08-10T13:29:31Z

I have added displayName as i forgot about it earlier.

src/pages/home/ReportScreen.js

SosenWiosen · 2023-08-16T12:09:03Z

recheck

aimane-chnaif · 2023-08-20T15:25:34Z

@SosenWiosen please fix conflict

SosenWiosen · 2023-08-21T13:14:55Z

Fixed conflict :) @aimane-chnaif

blazejkustra · 2023-08-24T09:27:51Z

@aimane-chnaif Could you take a look?

SosenWiosen · 2023-08-25T08:41:14Z

@aimane-chnaif Please take a look 🙏

aimane-chnaif · 2023-08-27T14:53:37Z

Add attachment seems not working after merging main into this branch locally. Also happens on main so not blocker.

ios.mov

aimane-chnaif · 2023-08-27T14:56:41Z

Another weird issue on mSafari. Also happens on main so not blocker

Screen.Recording.2023-08-27.at.3.54.39.PM.mov

aimane-chnaif · 2023-08-27T15:17:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

There are many regressions from composer, popover but already happens on main, not caused by this PR.
Otherwise, looks good!

melvin-bot · 2023-08-27T15:18:20Z

🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #26039.

neil-marcellini

Some NABs but looks great overall. Thanks for your work.

neil-marcellini · 2023-08-28T15:32:12Z

src/pages/home/ReportScreen.js

+    const chatWithAccountManager = useCallback(() => {
+        Navigation.navigate(ROUTES.getReportRoute(accountManagerReportID));
+    }, [accountManagerReportID]);



NAB: Can these callbacks be declared inline instead, for simplicity?

OSBotify · 2023-08-28T15:43:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-28T18:47:38Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:16:41Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:55:00Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:55:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

burczu · 2023-09-25T13:01:20Z

This PR introduced a regression fixed here: #27270

This line was, for some reason, removed while doing this migration:

const isTopMostReportID = Navigation.getTopmostReportId() === getReportID(route);

SosenWiosen added 3 commits August 3, 2023 19:18

migrate ReportScreen.js

5146626

fixes and delete unnecessary code.

faa1e27

fix prevReportRef.current being undefined

5715e91

SosenWiosen force-pushed the Migrate-ReportScreen.js-to-function-component branch from 0719827 to 5715e91 Compare August 3, 2023 17:18

SosenWiosen marked this pull request as ready for review August 4, 2023 14:33

SosenWiosen requested a review from a team as a code owner August 4, 2023 14:33

melvin-bot bot requested review from neil-marcellini and removed request for a team August 4, 2023 14:34

neil-marcellini requested a review from aimane-chnaif August 4, 2023 15:33

Merge branch 'Expensify:main' into Migrate-ReportScreen.js-to-functio…

2770795

…n-component

SosenWiosen added 2 commits August 10, 2023 12:19

Merge remote-tracking branch 'origin/main' into Migrate-ReportScreen.…

6e030b6

…js-to-function-component

fixes

823e886

add displayName

63e3a76

aimane-chnaif suggested changes Aug 15, 2023

View reviewed changes

src/pages/home/ReportScreen.js Show resolved Hide resolved

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

use usePrevious hook

2e1089d

SosenWiosen requested a review from aimane-chnaif August 16, 2023 11:37

merge

9d2c48c

Merge branch 'main' into Migrate-ReportScreen.js-to-function-component

9f56f32

Merge branch 'main' into Migrate-ReportScreen.js-to-function-component

8fe1778

Merge branch 'main' into Migrate-ReportScreen.js-to-function-component

5532ced

aimane-chnaif approved these changes Aug 27, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Aug 27, 2023

[HOLD for payment 2023-09-06] Payment issue for E/App PR#24111 #26039

Closed

neil-marcellini approved these changes Aug 28, 2023

View reviewed changes

neil-marcellini merged commit bd81e8c into Expensify:main Aug 28, 2023

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

lanitochka17 mentioned this pull request Aug 28, 2023

[$500] Room - Hmm... it's not here page appears when leaving the room on another device #26136

Closed

6 tasks

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

aimane-chnaif mentioned this pull request Sep 1, 2023

[$250] Migrate ReportScreen.js to function component #16255

Closed

1 task

tienifr mentioned this pull request Sep 10, 2023

[$500] LHN - Сonversation is not displayed in bold when new messages are received #27038

Closed

6 tasks

burczu mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-09-27] [$500] Desktop - Unread messages get marked as read without me visiting the chats #26824

Closed

6 tasks

Conversation

SosenWiosen commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SosenWiosen commented Aug 3, 2023

Uh oh!

SosenWiosen commented Aug 3, 2023

Uh oh!

melvin-bot bot commented Aug 4, 2023

Uh oh!

SosenWiosen commented Aug 4, 2023

Uh oh!

SosenWiosen commented Aug 4, 2023

Uh oh!

neil-marcellini commented Aug 7, 2023

Uh oh!

aimane-chnaif commented Aug 10, 2023

Uh oh!

SosenWiosen commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SosenWiosen commented Aug 10, 2023

Uh oh!

Uh oh!

Uh oh!

SosenWiosen commented Aug 16, 2023

Uh oh!

aimane-chnaif commented Aug 20, 2023

Uh oh!

SosenWiosen commented Aug 21, 2023

Uh oh!

blazejkustra commented Aug 24, 2023

Uh oh!

SosenWiosen commented Aug 25, 2023

Uh oh!

aimane-chnaif commented Aug 27, 2023

Uh oh!

aimane-chnaif commented Aug 27, 2023

Uh oh!

aimane-chnaif commented Aug 27, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 27, 2023

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

burczu commented Sep 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

SosenWiosen commented Aug 3, 2023 •

edited

Loading

github-actions bot commented Aug 3, 2023 •

edited

Loading

SosenWiosen commented Aug 10, 2023 •

edited

Loading