Fix: Two reports are opened when two users first open the report simultaneously by tienifr · Pull Request #24295 · Expensify/App

tienifr · 2023-08-08T20:12:15Z

Details

When two users first open the same DM simultaneously, two new reports are opened on each account, one of them is invalid. This PR fixes that.

Fixed Issues

$ #23437
PROPOSAL: #23437 (comment)

Tests

Precondition: A and B have never chat before.

Login with account A and B on different devices
On A, search for B; on B, search for A
Press the target DMs simultaneously on both devices
On A, send a message
Verify that it is sent without errors
Verify that only one new report is created in LHN

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Precondition: A and B have never chat before.

Login with account A and B on different devices
On A, search for B; on B, search for A
Press the target DMs simultaneously on both devices
On A, send a message
Verify that it is sent without errors
Verify that only one new report is created in LHN

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Untitled-compressed.mov

Mobile Web - Chrome

mweb.mp4

Mobile Web - Safari

Screen.Recording.2023-08-09.at.02.51.50.mov

Desktop

desktop-compressed.mov

iOS

Screen.Recording.2023-08-09.at.02.48.25.mov

Android

Screen.Recording.2023-08-09.at.03.11.20.mov

…usly

melvin-bot · 2023-08-08T20:13:22Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-08-09T10:59:04Z

src/pages/home/ReportScreen.js

+        // When a new DM is opened simultaneously from 2 accounts, there'll be 2 different optimistic reports & OpenReport calls
+        // The latter will contain preexistingReportID of the initial report and thus is invalid.
+        if (_.has(this.props.report, 'preexistingReportID') && !_.has(prevProps.report, 'preexistingReportID')) {
+            Report.deleteReport(onyxReportID);
+            Navigation.goBack();
+            const preexistingReportID = lodashGet(this.props.report, 'preexistingReportID');
+            Navigation.navigate(ROUTES.getReportRoute(preexistingReportID));
+            this.setState({isReportRemoved: true});
+            return;
+        }


@tienifr I think we can update the next block, the code doesn’t look dry. I don't think we need to check for prevProps.report.preexistingReportID, we just have to redirect once there is preexistingReportID , can be update to :

const preexistingReportID = lodashGet(this.props.report, 'preexistingReportID', false); if ((...) || preexistingReportID) { Navigation.goBack(); if (preexistingReportID){ Report.deleteReport(onyxReportID); Navigation.navigate(ROUTES.getReportRoute(preexistingReportID)); } else { Report.navigateToConciergeChat(); } // isReportRemoved will prevent <FullPageNotFoundView> showing when navigating this.setState({isReportRemoved: true}); return; }

I have updated it.

tienifr · 2023-08-09T11:36:16Z

@fedirjh It might flicker when navigating from the invalid to the valid report. Is it acceptable?

mweb.mp4

fedirjh · 2023-08-09T11:40:24Z

It might flicker when navigating from the invalid to the valid report

@tienifr What do you mean by flicker? It just displays the skeleton view which is the intended behavior, No?

tienifr · 2023-08-09T11:45:51Z

@fedirjh Great! I was a little bit worried about that skeleton effect. But I think it's expected as well.

fedirjh · 2023-08-09T11:48:29Z

But I think it's expected as well.

Yes, the preexistingReport doesn’t exist for the second user, it should be fetched after navigation, hence a skeleton view is expected.

fedirjh · 2023-08-09T12:33:22Z

@tienifr For offline tests, we can test the scenario when user 1 is online and user 2 is offline and they start a discussion, for this case, it should redirect to the existing report when user 2 goes online.

fedirjh · 2023-08-09T12:38:37Z

src/pages/home/ReportScreen.js

+                Report.deleteReport(onyxReportID);
+                Navigation.navigate(ROUTES.getReportRoute(preexistingReportID));


Let's reverse the order here.

fedirjh · 2023-08-09T15:37:14Z

@tienifr I got this error on IOS Native, the report shown in the screenshot is the preexistingReport

fedirjh · 2023-08-09T23:50:11Z

We got some conflicts as well.

tienifr · 2023-08-10T08:41:55Z

About the conflicts, the Concierge redirection was treated as a regression and reverted in PR #23394. They discussed that it was not optimal and decided to revert it here while looking for a better solution.

So I think I should revert that logic as well in this PR.

fedirjh · 2023-08-10T11:19:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-08-09.at.13.27.43.mp4

Mobile Web - Chrome

CleanShot.2023-08-09.at.16.43.46.mp4

Mobile Web - Safari

CleanShot.2023-08-09.at.16.22.33.mp4

Desktop

CleanShot.2023-08-09.at.16.18.57.mp4

iOS

CleanShot.2023-08-09.at.16.25.47.mp4

Android

CleanShot.2023-08-09.at.17.03.53.mp4

fedirjh · 2023-08-10T11:31:17Z

cc @tienifr, the code looks good and tests well however, we still have this console error on native
#24295 (comment)

tienifr · 2023-08-10T11:35:39Z

I'm working on that. But seems hard to find RCA.

…two-report-screens-open-when-open-report-with-each-other-simultaneously

tienifr · 2023-08-12T17:53:44Z

There're major Onyx updates in #24041. Now I can neither delete the report nor log in a new account. I think it's better to hold until #24041 is merged so that we can continue testing.

fedirjh · 2023-08-12T19:09:01Z

That make sense, let's hold.

…two-report-screens-open-when-open-report-with-each-other-simultaneously

tienifr · 2023-08-21T08:17:07Z

@fedirjh After pulling main, I found out that this issue was resolved by #24320. It was merged 5 days ago but we weren't aware of that. However, it also had the same console error that we've faced. I've spent a long time on that but still not sure about RCA.

I think we're good to revert the changes and close this one out 👐👐.

fedirjh · 2023-08-21T08:39:17Z

I think it makes sense to close this PR, #24320 seems to have fixed this case.

cc @NikkiWines

🎀 👀 🎀 C+ reviewed

NikkiWines · 2023-08-21T18:45:27Z

Cool! Sounds like this is no longer needed, closing!

fix: two reports are opened when two users open the report simultaneo…

1d5e1dc

…usly

tienifr marked this pull request as ready for review August 8, 2023 20:13

tienifr requested a review from a team as a code owner August 8, 2023 20:13

melvin-bot bot requested review from fedirjh and removed request for a team August 8, 2023 20:13

tienifr mentioned this pull request Aug 8, 2023

[Waiting for payment][$1000] LHN - Face issue when two user click each another at same time #23437

Closed

6 tasks

fedirjh suggested changes Aug 9, 2023

View reviewed changes

refactor

1d9f739

fix lint

e7efa13

fedirjh reviewed Aug 9, 2023

View reviewed changes

reverse delete order

b5b045b

resolve conflicts

ff5a63b

Merge branch 'main' of https://github.com/tienifr/App into fix/23437-…

019d625

…two-report-screens-open-when-open-report-with-each-other-simultaneously

Merge branch 'main' of https://github.com/tienifr/App into fix/23437-…

8274497

…two-report-screens-open-when-open-report-with-each-other-simultaneously

revert changes

d79fb52

NikkiWines closed this Aug 21, 2023

		Report.deleteReport(onyxReportID);
		Navigation.navigate(ROUTES.getReportRoute(preexistingReportID));

Conversation

tienifr commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 8, 2023

Uh oh!

fedirjh Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr commented Aug 9, 2023

Uh oh!

fedirjh commented Aug 9, 2023

Uh oh!

tienifr commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh commented Aug 9, 2023

Uh oh!

fedirjh commented Aug 9, 2023

Uh oh!

fedirjh Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

fedirjh commented Aug 9, 2023

Uh oh!

fedirjh commented Aug 9, 2023

Uh oh!

tienifr commented Aug 10, 2023

Uh oh!

fedirjh commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fedirjh commented Aug 10, 2023

Uh oh!

tienifr commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Aug 12, 2023

Uh oh!

fedirjh commented Aug 12, 2023

Uh oh!

tienifr commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NikkiWines commented Aug 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tienifr commented Aug 8, 2023 •

edited

Loading

tienifr commented Aug 9, 2023 •

edited

Loading

fedirjh commented Aug 10, 2023 •

edited

Loading

tienifr commented Aug 10, 2023 •

edited

Loading

tienifr commented Aug 21, 2023 •

edited

Loading

fedirjh commented Aug 21, 2023 •

edited

Loading