Add Waypoint Editor #24301

thienlnam · 2023-08-08T21:15:22Z

Details

Fixed Issues

$ #22705
PROPOSAL:

Tests

Go to 'Request Money' from the LHN
Hit the 'Distance' tab
Click on one of the waypoints
Add some jibberish, and press 'enter'
Notice that you are not able to submit the form
If you are online, you should always see a hint that says 'Please select a suggested address'
Choose a suggested addresss from the dropdown
Verify you are navigated back to select another waypoint
Open another waypoint
Enter some text and then hit the back button
(The draft text won't be saved and that is expected)
Add a stop
Enter an address
For that waypoint, add an empty value and verify the waypoint is removed

Offline tests

Go to 'Request Money' from the LHN
Hit the 'Distance' tab
Click on one of the waypoints
Enter some legitimate address and press enter - it should save while you are offline as the BE will try to fill the lat/long
Add a stop
Enter some random address and press enter - it should save
Click on that same waypoint and add an empty value
It should be removed

QA Steps

Addressed in the online and offline tests

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-11.at.11.29.16.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-11.at.11.52.39.AM.mov

Mobile Web - Safari

Desktop

Screen.Recording.2023-08-11.at.11.51.28.AM.mov

iOS

Screen.Recording.2023-08-11.at.11.43.57.AM.mov

Android

melvin-bot · 2023-08-10T19:41:55Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-08-10T19:56:49Z

@rushatgabhane @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-08-10T21:20:22Z

I changed the base to make it easier to review.

rushatgabhane · 2023-08-10T22:13:47Z

can the hold be lifted?

Santhosh-Sellavel · 2023-08-16T20:15:01Z

Even weirder on the web, after editing waypoint the RHN gets dismissed

Screen.Recording.2023-08-17.at.1.44.06.AM.mov

thienlnam · 2023-08-16T20:56:04Z

We're discussing here https://expensify.slack.com/archives/C01GTK53T8Q/p1692216780044899

I feel like this happened recently, as I wasn't running into it until recently

src/libs/actions/Transaction.js

src/pages/iou/WaypointEditor.js

neil-marcellini · 2023-08-17T01:48:55Z

src/pages/iou/WaypointEditor.js


        // Other flows will be handled by selecting a waypoint with selectWaypoint as this is mainly for the offline flow
-        Navigation.navigate(ROUTES.getMoneyRequestDistanceTabRoute(iouType));
+        Navigation.goBack();


We should specify the route to go back to, otherwise it will go back to the home page if you refresh the page and trigger this. I'm currently managing an issue to make the route param mandatory.

We actually talked about here https://expensify.slack.com/archives/C01GTK53T8Q/p1692216780044899

TLDR: For tab navigation, Navigation.goBack() is the only solution for now as using Navigate will push the page to the RHP which we don't want

EDIT: Oh, I see I didn't realize you could add the route to goBack()

Santhosh-Sellavel · 2023-08-17T16:24:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-08-17.at.10.09.34.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-08-17.at.10.15.57.PM.mov

iOS & Android

Screen.Recording.2023-08-17.at.1.51.34.AM.mov

Santhosh-Sellavel · 2023-08-17T17:03:53Z

src/pages/iou/WaypointEditor.js

+            onEntryTransitionEnd={() => textInput.current && textInput.current.focus()}
+        >
+            <HeaderWithBackButton
+                title="Waypoint Editor"


LocalizationMissing

Santhosh-Sellavel · 2023-08-17T17:37:24Z

LGTM, Just this Localization

melvin-bot · 2023-08-17T17:57:23Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini

Woohoo!

OSBotify · 2023-08-17T18:16:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:25:49Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:08:50Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

thienlnam added 2 commits August 8, 2023 14:14

Create WaypointEditor bones

208f430

Start DistanceRequest actions

cc0352a

thienlnam self-assigned this Aug 8, 2023

thienlnam added 11 commits August 8, 2023 14:51

Add route navigation

8dd750b

Update linkingConfig.js

4192bcb

Update passed in props

b63cdbb

Add navigation and form draft

975863c

Have draft keys shown

3aa122c

return the lat/long/address!

98fbf35

Make it so waypoint form only updates the waypoint index

e8b0c98

Prevent you from inputting null keys

fdcdc46

Save waypoint to transaction

f3296cd

Handle saving an empty waypoint

68d1d68

Add offline functionality

6ac9183

neil-marcellini self-requested a review August 10, 2023 16:27

thienlnam added 2 commits August 10, 2023 11:49

comments & translations

5b5fc38

Merge branch 'main' into jack-branchedWaypointEditor

9724ebe

prettier

55586ab

thienlnam changed the title ~~Add Waypoint Editor~~ [HOLD] Add Waypoint Editor Aug 10, 2023

thienlnam marked this pull request as ready for review August 10, 2023 19:50

thienlnam requested a review from a team as a code owner August 10, 2023 19:50

melvin-bot bot requested review from rushatgabhane and removed request for a team August 10, 2023 19:56

neil-marcellini changed the base branch from main to neil-waypoints-list August 10, 2023 21:16

neil-marcellini changed the base branch from neil-waypoints-list to main August 10, 2023 21:19

neil-marcellini changed the base branch from main to neil-waypoints-list August 10, 2023 21:19

mountiny reviewed Aug 16, 2023

View reviewed changes

src/libs/actions/Transaction.js Show resolved Hide resolved

mountiny reviewed Aug 16, 2023

View reviewed changes

src/pages/iou/WaypointEditor.js Outdated Show resolved Hide resolved

src/pages/iou/WaypointEditor.js Outdated Show resolved Hide resolved

src/pages/iou/WaypointEditor.js Outdated Show resolved Hide resolved

Update to goBack

4bda6ad

thienlnam dismissed neil-marcellini’s stale review via 4bda6ad August 16, 2023 22:18

neil-marcellini requested changes Aug 17, 2023

View reviewed changes

hayata-suenaga mentioned this pull request Aug 17, 2023

Display single waypoint #25161

Merged

57 tasks

Add goback route

5a383c7

add prop lol

9f57e7f

Santhosh-Sellavel reviewed Aug 17, 2023

View reviewed changes

thienlnam added 2 commits August 17, 2023 12:52

Add translation for Waypoint Editor

10c6a56

Oops, swap the waypoints

d0ae0fd

Santhosh-Sellavel approved these changes Aug 17, 2023

View reviewed changes

melvin-bot bot requested a review from stitesExpensify August 17, 2023 17:57

Add approved copy

ff4a775

thienlnam removed the request for review from stitesExpensify August 17, 2023 17:58

neil-marcellini approved these changes Aug 17, 2023

View reviewed changes

neil-marcellini merged commit 5321074 into main Aug 17, 2023

neil-marcellini deleted the jack-branchedWaypointEditor branch August 17, 2023 18:11

Pujan92 mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-10-16] [$1000] Dev: The "No result found" message showing after selecting a address from the drop-down menu #25595

Closed

6 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

lanitochka17 mentioned this pull request Aug 22, 2023

Request money - Console error shows up when opening request money page #25683

Closed

6 tasks

jjcoffee mentioned this pull request Sep 28, 2023

[$500] PR 27825 RM - Save button should remain disabled until something is entered in the input field. #27998

Closed

6 tasks

Add Waypoint Editor #24301

Add Waypoint Editor #24301

Uh oh!

Conversation

thienlnam commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 10, 2023

Uh oh!

melvin-bot bot commented Aug 10, 2023

Uh oh!

neil-marcellini commented Aug 10, 2023

Uh oh!

rushatgabhane commented Aug 10, 2023

Uh oh!

Santhosh-Sellavel commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thienlnam commented Aug 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neil-marcellini Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

thienlnam Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Aug 17, 2023

Uh oh!

melvin-bot bot commented Aug 17, 2023

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

thienlnam commented Aug 8, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 16, 2023 •

edited

Loading

thienlnam Aug 17, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 17, 2023 •

edited

Loading