Skip to content

Don't retry request to check online status and update online status in Ion when request succeeds #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 1 commit into from
Aug 19, 2020
Merged

Don't retry request to check online status and update online status in Ion when request succeeds #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/Network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,8 @@ function processNetworkRequestQueue() {
// 2. Getting a 200 response back from the API (happens right below)

// Make a simple request every second to see if the API is online again
request('Get', null)
request('Get', {doNotRetry: true})
.then(() => Ion.merge(IONKEYS.NETWORK, {isOffline: false}))
.then(() => isAppOffline = false);
return;
}
Expand Down