-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[NO QA][CardSettings] replace corporateCardList with cardList #25939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
167f5ef
6874aba
9f3d591
7ae5bc3
667f6d3
6985a2d
a290a6f
a8011b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,17 @@ | ||
| type AdditionalData = { | ||
| isBillingCard?: boolean; | ||
| isP2PDebitCard?: boolean; | ||
| }; | ||
|
|
||
| type AccountData = { | ||
| additionalData?: AdditionalData; | ||
| addressName?: string; | ||
| addressState?: string; | ||
| addressStreet?: string; | ||
| addressZip?: number; | ||
| cardMonth?: number; | ||
|
|
||
| /** The masked credit card number */ | ||
| cardNumber?: string; | ||
|
|
||
| cardYear?: number; | ||
| created?: string; | ||
| currency?: string; | ||
| fundID?: number; | ||
| }; | ||
| import {ValueOf} from 'type-fest'; | ||
| import CONST from '../../CONST'; | ||
|
|
||
| type Card = { | ||
flodnv marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| accountData?: AccountData; | ||
| accountType?: string; | ||
| description?: string; | ||
| key?: string; | ||
| methodID?: number; | ||
| title?: string; | ||
| cardID: number; | ||
| state: number; | ||
| bank: string; | ||
| availableSpend: number; | ||
| domainName: string; | ||
| maskedPan: string; | ||
| isVirtual: boolean; | ||
| fraud: ValueOf<typeof CONST.EXPENSIFY_CARD.FRAUD_TYPES>; | ||
| cardholderFirstName: string; | ||
| cardholderLastName: string; | ||
|
Comment on lines
+13
to
+14
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would this be optional, or always available?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. right now always available |
||
| }; | ||
|
|
||
| export default Card; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| type AdditionalData = { | ||
| isBillingCard?: boolean; | ||
| isP2PDebitCard?: boolean; | ||
| }; | ||
|
|
||
| type AccountData = { | ||
| additionalData?: AdditionalData; | ||
| addressName?: string; | ||
| addressState?: string; | ||
| addressStreet?: string; | ||
| addressZip?: number; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here too, I feel like most of these aren't optional...
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't modify these , just moved what was in the old Card.ts file into Fund.ts
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I get that, but that's not really a good reason to not fix issues with code 😄 |
||
| cardMonth?: number; | ||
|
|
||
| /** The masked credit card number */ | ||
| cardNumber?: string; | ||
|
|
||
| cardYear?: number; | ||
| created?: string; | ||
| currency?: string; | ||
| fundID?: number; | ||
| }; | ||
|
|
||
| type Fund = { | ||
grgia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| accountData?: AccountData; | ||
| accountType?: string; | ||
| description?: string; | ||
| key?: string; | ||
| methodID?: number; | ||
| title?: string; | ||
| }; | ||
|
|
||
| export default Fund; | ||
Uh oh!
There was an error while loading. Please reload this page.