Fix: Fail to request camera permission in Scan receipt screen by tienifr · Pull Request #26231 · Expensify/App

tienifr · 2023-08-29T16:43:01Z

Details

The app shows error message when tapping on the capture button. User is required to go to Settings to manually allow camera permission via Give permission CTA.

Basically, Android "allows" user to deny a specific permission twice. Otherwise, they would need to manually grant permission in Settings. Meanwhile iOS only "allows" once.

Fixed Issues

$ #24160
PROPOSAL: #24160 (comment)

Tests

Precondition: The device has not granted camera permission to NewDot app before.

Login with any account
Go to any report
Press + button > Add attachments > Take photo
Verify that a camera permission prompt popup appears
Press Don't allow to deny permission
Verify an error popup appears >> Close
Press FAB > Request money > Scan
Press Give permission
=== On Android
Verify that a camera permission prompt popup appears
Press Don't allow to deny permission
Press Give permission
Verify that we are navigated to the device Settings
=== On iOS
Verify that we are navigated to the device Settings

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Precondition: The device has not granted camera permission to NewDot app before.

Login with any account
Go to any report
Press + button > Add attachments > Take photo
Verify that a camera permission prompt popup appears
Press Don't allow to deny permission
Verify an error popup appears >> Close
Press FAB > Request money > Scan
Press Give permission
=== On Android
Verify that a camera permission prompt popup appears
Press Don't allow to deny permission
Press Give permission
Verify that we are navigated to the device Settings
=== On iOS
Verify that we are navigated to the device Settings

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS

Screen.Recording.2023-08-30.at.00.15.47.mov

Android

Screen.Recording.2023-08-30.at.01.45.24.mov

melvin-bot · 2023-08-29T18:53:15Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-08-29T18:57:07Z

src/pages/iou/ReceiptSelector/index.native.js

    const askForPermissions = () => {
-        if (permissions === 'not-determined') {
-            Camera.requestCameraPermission().then((permissionStatus) => {
+        // Android will never return blocked after a check, you have to request the permission to get the info.


Also mentioned in the doc: https://github.com/zoontek/react-native-permissions/blob/a836e114ce3a180b2b23916292c79841a267d828/README.md?plain=1#L670

There's no way we can check for the BLOCKED status without requesting the permission first, even with react-native's PermissionsAndroid.

Context: https://developer.android.com/training/permissions/requesting#workflow_for_requesting_permissions (point 4).

I know this is a hack thus really looking forward to your feedback!

I think we should put this in the description as comments. I think this is fine for the current change.

You mean the PR description, right?

We should put a proper description on why we're doing along with the link in the code comment.

mananjadhav · 2023-08-30T19:33:44Z

@tienifr Can you resolve the conflicts?

mananjadhav

Code change looks fine, once conflicts are resolved, I'll test.

tienifr · 2023-08-31T02:50:23Z

@mananjadhav Conflicts resolved!

mananjadhav · 2023-08-31T18:09:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-scan-receipt.mov

Mobile Web - Chrome

mweb-chrome-scan-receipt.mov

Mobile Web - Safari

mweb-safari-scan-receipt.mov

Desktop

desktop-scan-receipt.mov

iOS

ios-scan-receipt.mov

Android

android-scan-receipt.mov

mananjadhav · 2023-08-31T18:15:28Z

@AndrewGable All yours.

melvin-bot · 2023-09-05T19:01:08Z

@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

AndrewGable · 2023-09-05T19:02:19Z

Oops, checklist test must have been running. It was green when I merged.

OSBotify · 2023-09-05T19:06:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-06T18:59:40Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-08T07:01:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.65-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-08T07:32:02Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-11T09:12:59Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.66-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ntdiary · 2023-10-23T15:27:36Z

src/pages/iou/ReceiptSelector/index.native.js

+        // Android will never return blocked after a check, you have to request the permission to get the info.
+        if (permissions === RESULTS.BLOCKED || isAndroidBlockedPermissionRef.current) {
+            Linking.openSettings();
+        } else if (permissions === RESULTS.DENIED) {


Coming from #27442. We improved the UX to avoid the permission button does nothing on first click

tienifr added 3 commits August 29, 2023 23:25

fix: fail to request camera permission in scan receipt screen

da87d1b

fix request permission on android

72bc75f

use predefined constants

d16d979

tienifr marked this pull request as ready for review August 29, 2023 18:49

tienifr requested a review from a team as a code owner August 29, 2023 18:49

tienifr mentioned this pull request Aug 29, 2023

[HOLD for payment 2023-09-15] [$1000] Android - Request money - Different app behavior when asking for camera permission in Scan receipt #24160

Closed

6 tasks

melvin-bot bot removed the request for review from a team August 29, 2023 18:53

melvin-bot bot requested a review from mananjadhav August 29, 2023 18:53

tienifr commented Aug 29, 2023

View reviewed changes

add comment

0d8d9ee

mananjadhav approved these changes Aug 30, 2023

View reviewed changes

melvin-bot bot requested a review from AndrewGable August 30, 2023 20:18

Merge branch 'main' into fix/24160

652d8ac

fix lint

fd64c22

tienifr added 2 commits September 4, 2023 22:49

Merge branch 'main' into fix/24160

5bc697c

fix lint

6c0320f

AndrewGable approved these changes Sep 5, 2023

View reviewed changes

AndrewGable merged commit 30076c5 into Expensify:main Sep 5, 2023

melvin-bot bot added the Emergency label Sep 5, 2023

AndrewGable removed the Emergency label Sep 5, 2023

OSBotify mentioned this pull request Sep 6, 2023

Deploy Checklist: New Expensify 2023-09-06 #26894

Closed

35 tasks

OSBotify mentioned this pull request Sep 8, 2023

Deploy Checklist: New Expensify 2023-09-08 #27003

Closed

28 tasks

This was referenced Sep 11, 2023

[HOLD for payment 2023-10-23] [$500] [Android] User isn't prompted for Camera permission via the native Modal #26499

Closed

[HOLD for payment 2023-10-23] [$500] Android - Grant Camera Permission button not working on first click #27442

Closed

ntdiary reviewed Oct 23, 2023

View reviewed changes

Conversation

tienifr commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 29, 2023

Uh oh!

tienifr Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Aug 30, 2023

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Aug 31, 2023

Uh oh!

mananjadhav commented Aug 31, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Aug 31, 2023

Uh oh!

melvin-bot bot commented Sep 5, 2023

Uh oh!

AndrewGable commented Sep 5, 2023

Uh oh!

OSBotify commented Sep 5, 2023

Uh oh!

OSBotify commented Sep 6, 2023

Uh oh!

OSBotify commented Sep 8, 2023

Uh oh!

OSBotify commented Sep 8, 2023

Uh oh!

OSBotify commented Sep 11, 2023

Uh oh!

ntdiary Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tienifr commented Aug 29, 2023 •

edited

Loading

ntdiary Oct 23, 2023 •

edited

Loading