-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update landing page copy (below headline) for SaaStr & SBE Conferences #26278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Confirmed copy is good in slack, still waiting on spanish translations but at least we can review! |
|
Sorry @jjcoffee unassigning b/c this is a very small change, won't need C+ help testing here 🙏 |
|
Ready for final review! |
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.62-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀
|



Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/311877
Tests
/saastr(without logging in)/sbe(without logging in)Offline tests
N/A have to be online
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Not needed - this new text won't show on small screens
Mobile Web - Safari
Not needed - this new text won't show on small screens
Desktop
Not needed, deep linking will occur after logging in i believe
iOS
Not needed - this new text won't show on small screens
Android
Not needed - this new text won't show on small screens