[26737] Made sure that the sections from the request money are scroll…

[DanutGavrus]

As this is a draft PR, I'm adding here a video with before(latest staging as of now) and after(this PR changes) so we may decide if we want(or not) to proceed with these changes:

scroll_1.mp4

scroll_2.mp4

scroll_3.mp4

[DanutGavrus]

Differences in MoneyRequestSelectorPage are strangely shown, I've just added a <ScrollView contentContainerStyle={[styles.flexGrow1]}> around the OnyxTabNavigator and nothing else.

[DanutGavrus]

The comparison was made against the latest staging, when on main, we have this PR: #26728 which added the <ScrollView contentContainerStyle={styles.flex1}> in the distance request. The only difference on main is that we may now scroll down to the button, but we lose the bottom margin when we scroll as seen here(I can't scroll anymore):

And we still have 1 problem left, we have functionality in code which wants to show 4 locations before making the list scrollable, and to also show only half of the fifth and up location as to indicate that the list is scrollable as seen here:

App/src/components/DistanceRequest.js

Line 42 in b9c4832

const MAX_WAYPOINTS_TO_DISPLAY = 4;

App/src/components/DistanceRequest.js

Lines 133 to 135 in b9c4832

	// Show up to the max number of waypoints plus 1/2 of one to hint at scrolling
	const halfMenuItemHeight = Math.floor(variables.baseMenuItemHeight / 2);
	const scrollContainerMaxHeight = variables.baseMenuItemHeight * MAX_WAYPOINTS_TO_DISPLAY + halfMenuItemHeight;

But doesn't work on current main.

[DanutGavrus]

I'll close this based on this discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1693986149607419. We've fixed the mentioned issues on the main branch by replacing flex1 with flexGrow1 in the distance page. This PR's only remaining benefit would be that it would remove all scroll views from sections and place only 1 upper in the hierarchy, making any existing & future section scrollable. We don't know for sure that it won't introduce new problem and It doesn't seem required for now.