[NoQA] Replace iOS provision profile to allow dev builds from XCode#26860
Closed
[NoQA] Replace iOS provision profile to allow dev builds from XCode#26860
Conversation
Contributor
|
Where is the encrypted profile used? I thought we just had to update this on Apple's backend. |
neil-marcellini
approved these changes
Sep 6, 2023
Contributor
neil-marcellini
left a comment
There was a problem hiding this comment.
Nice, I'm now able to run the App on my physical iOS device on dev!
There's still the problem that it connects to the staging API, and it also shows the badge as if it's the staging app. We can fix that separately.
Contributor
|
Also IDK how to do the first test step |
Contributor
Author
@AndrewGable oh interesting. I assumed all certs had to be committed, but that would make sense. The app builds from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AndrewGable @neil-marcellini
Details
When I generated the Expensify Dev provisioning profile I selected AdHoc instead of development. This prevented us from building to physical devices from XCode.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/314417
Tests
expensify_chat_devprov profileDebug Developmentselected as the Capability [1]importand locate the updated provisioning file you downloaded earlier [2]cd ios && pod installOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Only iOS is relevant here