Skip to content

[TS migration] Migrate 'Receipt.js' lib to TypeScript #26965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 1 commit into from
Sep 8, 2023
Merged

[TS migration] Migrate 'Receipt.js' lib to TypeScript #26965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/libs/actions/Receipt.js → src/libs/actions/Receipt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@ import ONYXKEYS from '../../ONYXKEYS';

/**
* Sets the upload receipt error modal content when an invalid receipt is uploaded
*
* @param {Boolean} isAttachmentInvalid
* @param {String} attachmentInvalidReasonTitle
* @param {String} attachmentInvalidReason
*/
function setUploadReceiptError(isAttachmentInvalid, attachmentInvalidReasonTitle, attachmentInvalidReason) {
function setUploadReceiptError(isAttachmentInvalid: boolean, attachmentInvalidReasonTitle: string, attachmentInvalidReason: string) {
Copy link
Member

@s77rt s77rt Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to specify the return type? void in this case (same for the other function)

Copy link
Contributor Author

@Skalakid Skalakid Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to guidelines, I think this function is simple enough that we don't need to specify return type

Onyx.merge(ONYXKEYS.RECEIPT_MODAL, {
isAttachmentInvalid,
attachmentInvalidReasonTitle,
Expand Down