Skip to content

Mark all actions as read immediately after the chat becomes active/visible #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MonilBhavsar merged 2 commits into from
May 7, 2021
Merged

Mark all actions as read immediately after the chat becomes active/visible #2699

MonilBhavsar merged 2 commits into from
May 7, 2021

Conversation

@Gonals
Copy link
Contributor

@Gonals Gonals commented May 5, 2021 •
edited by MonilBhavsar
Loading

Fixed Issues

Fixes #2573
Fixes https://github.com/Expensify/Expensify/issues/162219

Tests / QA Steps

  1. Have, at least, 2 chats in the LHN.
  2. While chat 1 is open, receive a message in chat 1. It should not get highlighted in the LHN
  3. While chat 2 is open, receive a message in chat 1. It should get highlighted in the LHN
  4. Open Chat 1. The highlight should disappear immediately
  5. In web, have chat 1 open in a hidden tab and receive a message in it. After you receive the notification, open it. The highlight should disappear immediately.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Gonals Gonals requested a review from a team as a code owner May 5, 2021 15:13
@Gonals Gonals self-assigned this May 5, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team May 5, 2021 15:13
@Gonals Gonals changed the title [HOLD] Mark all actions as read immediately after the chat becomes active/visible Mark all actions as read immediately after the chat becomes active/visible May 6, 2021
@MonilBhavsar MonilBhavsar merged commit 2f544a6 into main May 7, 2021
@MonilBhavsar MonilBhavsar deleted the alberto-removeTimer branch May 7, 2021 05:58
@OSBotify OSBotify mentioned this pull request May 7, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

OSBotify commented May 7, 2021

🚀 Deployed to staging in version: 1.0.39-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes

Assignees

@Gonals Gonals

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Immediately mark a conversation as "read" when switching browser tabs and seeing the message in Expensify.cash

4 participants

@Gonals @OSBotify @MonilBhavsar