migrate PopoverReportActionContextMenu class to function component by OlimpiaZurek · Pull Request #27221 · Expensify/App

OlimpiaZurek · 2023-09-12T08:30:35Z

Details

PR involves refactoring the PopoverReportActionContextMenu from a class to a functional component

Fixed Issues

$ #16260

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mobile_web_chrome.mov

Mobile Web - Safari

mobile_web_safari.mp4

Desktop

desktop.mov

iOS

iOS.mp4

Android

android.mov

koko57 · 2023-09-12T08:40:07Z

something's wrong with indentation width - sometimes is 2 and in other places 4 - should be 4 (run prettier 😉)

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

melvin-bot · 2023-09-14T07:20:06Z

@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga · 2023-09-14T07:22:48Z

@gedu or @thiagobrez could one of you fill the checklist please 🙇 ?

thiagobrez · 2023-09-14T08:11:46Z

@hayata-suenaga Sure! I'm on it 👍🏻

thiagobrez · 2023-09-14T08:48:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.web.mov

Mobile Web - Safari

ios.web.mp4

Desktop

desktop.mov

iOS

ios.native.mp4

Android

android.native.mov

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

melvin-bot · 2023-09-27T03:36:31Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-09-27T03:42:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:18:12Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dummy-1111 · 2023-09-29T10:08:52Z

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

+                    reportIDRef.current = '0';
+                    reportActionRef.current = {};


I'm not sure why this was added.
@OlimpiaZurek Can you explain?

@s-alves10 This shouldn't be here. I will prepare a PR to fix this.

Link to PR: #28462

OSBotify · 2023-10-02T17:22:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:50:46Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:51:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

DylanDylann · 2023-10-05T07:57:07Z

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

-    }
+            </PopoverWithMeasuredContent>
+            <ConfirmModal
+                title={translate('reportActionContextMenu.deleteAction', {reportAction})}


@OlimpiaZurek Why you change this line? It should be
title={this.props.translate('reportActionContextMenu.deleteAction', {action: this.state.reportAction})}

It causes regression here

cc @hayata-suenaga @thiagobrez

abdulrahuman5196 · 2023-10-09T17:44:44Z

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

+        setIsDeleteCommentConfirmModalVisible(true);
+    };
+
+    useImperativeHandle(ref, () => ({


We missed to add contentRef which caused this issue - #28538

cc: @OlimpiaZurek

This regression has already been fixed here: #28558 . Is there anything else that needs to be done?

ikevin127 · 2025-03-15T01:07:56Z

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

+        vertical: 0,
+    });
+
+    const [instanceID, setInstanceID] = useState('');


Looks like transforming this from class component to functional useState led to the following issue:

[Due for payment 2025-03-21] [$250] Chat - Opened twice 3 dot action menu appears at the top left corner after dismissing it #57699

which we fixed by using ref instead.

thiagobrez reviewed Sep 12, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

thiagobrez reviewed Sep 12, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

gedu reviewed Sep 12, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

gedu reviewed Sep 12, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

gedu reviewed Sep 12, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

OlimpiaZurek force-pushed the feat/16260-migrate-PopoverReportActionContextMenu-to-functional branch from 86b28fd to 4ff55d1 Compare September 12, 2023 16:05

OlimpiaZurek marked this pull request as ready for review September 14, 2023 07:19

OlimpiaZurek requested a review from a team as a code owner September 14, 2023 07:19

melvin-bot bot requested review from hayata-suenaga and removed request for a team September 14, 2023 07:20

OlimpiaZurek mentioned this pull request Sep 14, 2023

[HOLD for payment 2023-10-10] [$250] Migrate PopoverReportActionContextMenu.js to function component #16260

Closed

1 task

hayata-suenaga reviewed Sep 22, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

OlimpiaZurek added 4 commits September 22, 2023 10:46

migrate PopoverReportActionContextMenu class to function component

8e3baa2

code improvements after cr

eebfe3d

fix lint issue

0f6938d

fix conflicts

a6f63a2

OlimpiaZurek force-pushed the feat/16260-migrate-PopoverReportActionContextMenu-to-functional branch from dd65a06 to a6f63a2 Compare September 22, 2023 10:35

prettier fix

594bd6b

hayata-suenaga reviewed Sep 26, 2023

View reviewed changes

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Show resolved Hide resolved

hayata-suenaga approved these changes Sep 27, 2023

View reviewed changes

hayata-suenaga merged commit 9806b65 into Expensify:main Sep 27, 2023

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

dummy-1111 mentioned this pull request Sep 29, 2023

[HOLD for payment 2023-10-28] [$500] Chat - Focus is lost after deleting a message from edit mode #28420

Closed

6 tasks

dummy-1111 reviewed Sep 29, 2023

View reviewed changes

aimane-chnaif mentioned this pull request Sep 29, 2023

[CP Staging] Fix the main composer not regaining focus after action is deleted #28456

Closed

59 tasks

hungvu193 mentioned this pull request Sep 30, 2023

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$250] Chat - Console error "Cannot read properties of undefined (reading 'current')" on emoji picker #28538

Closed

6 tasks

bernhardoj mentioned this pull request Oct 2, 2023

[HOLD 2023-10-16] [$125] mweb/Safari - Composer - Cursor does not moved to a new line in the composer when tapped on the "return" #28501

Closed

6 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

DylanDylann reviewed Oct 5, 2023

View reviewed changes

DylanDylann mentioned this pull request Oct 5, 2023

[$500] Delete request confirmation modal has Delete comment as the title #28861

Closed

6 tasks

abdulrahuman5196 reviewed Oct 9, 2023

View reviewed changes

hungvu193 mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Web – Chat - Unable to delete message using Context menu #29159

Closed

6 tasks

FitseTLT mentioned this pull request Nov 22, 2023

[HOLD for payment 2024-01-11] [$500] Wallet - The popup moves to the side if the page is resized #31706

Closed

6 tasks

bernhardoj mentioned this pull request Mar 4, 2025

[Due for payment 2025-03-21] [$250] Chat - Opened twice 3 dot action menu appears at the top left corner after dismissing it #57699

Closed

8 tasks

ikevin127 reviewed Mar 15, 2025

View reviewed changes

Conversation

OlimpiaZurek commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

koko57 commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Sep 14, 2023

Uh oh!

hayata-suenaga commented Sep 14, 2023

Uh oh!

thiagobrez commented Sep 14, 2023

Uh oh!

thiagobrez commented Sep 14, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Sep 27, 2023

Uh oh!

OSBotify commented Sep 27, 2023

Uh oh!

OSBotify commented Sep 28, 2023

Uh oh!

dummy-1111 Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 2, 2023

Uh oh!

OSBotify commented Oct 2, 2023

Uh oh!

OSBotify commented Oct 3, 2023

Uh oh!

DylanDylann Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga Oct 10, 2023

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

ikevin127 Mar 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

OlimpiaZurek commented Sep 12, 2023 •

edited

Loading

koko57 commented Sep 12, 2023 •

edited

Loading

DylanDylann Oct 5, 2023 •

edited

Loading