Migrate SearchPage.js to function component by Piotrfj · Pull Request #27924 · Expensify/App

Piotrfj · 2023-09-21T08:40:39Z

Details

Fixed Issues

$ #16251
PROPOSAL: #16251 (comment)

Tests

Click on search icon in chat list to enter search page.
Verify if the results are the same as on production version of the application.

Verify that no errors appear in the JS console

Offline tests

Click on search icon in chat list to enter search page.
Verify if the results are the same as on production version of the application.

QA Steps

Click on search icon in chat list to enter search page.
Verify if the results are the same as on production version of the application.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Kapture.2023-08-23.at.14.57.44.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Kapture.2023-08-23.at.14.57.44.mp4

iOS

Kapture.2023-08-24.at.13.12.01.mp4

Android

Kapture.2023-08-23.at.15.14.34.mp4

…1-SearchPage-refactoring

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

melvin-bot · 2023-09-21T08:41:16Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2023-09-25T05:01:43Z

Assigning @allroundexperts since this is another attempt to fix #16251

@luacmartins gonna remove ya from this one.

allroundexperts · 2023-10-01T20:39:29Z

@Piotrfj Bump for the lint errors and conflicts!

koko57 · 2023-10-17T08:11:34Z

@allroundexperts Piotr is on a sick leave, he'll be back tomorrow

Piotrfj · 2023-10-20T19:15:35Z

@allroundexperts I have been working on the fix, but first solution turn out to be buggy and too much of workaround, today I was working on the different approach and will present it fully on monday

Piotrfj · 2023-10-25T20:11:04Z

That comment was put here by mistake. I'm surprised that there are still conflicts. Will solve them tomorrow morning

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

Piotrfj · 2023-10-26T13:43:01Z

@allroundexperts conflicts and lint issues resolved, ready to check and merge, sorry it took so long.

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

Piotrfj · 2023-10-30T17:05:26Z

@allroundexperts conflicts resolved again, please merge so we can close it

allroundexperts · 2023-10-31T07:00:50Z

Still lint errors!

Piotrfj · 2023-11-02T15:58:53Z

@allroundexperts fixed, lint error was related to changes outside of my refactor

allroundexperts · 2023-11-02T16:02:58Z

@Piotrfj Conflicts now!

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

Piotrfj · 2023-11-06T10:33:21Z

@allroundexperts fixed, there were some logic changes again outside of the refactoring, please review and merge.

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

Piotrfj · 2023-12-08T13:48:57Z

waiting for review

allroundexperts · 2023-12-10T23:42:33Z

@Piotrfj There are still pending comments.

koko57 · 2023-12-11T06:55:50Z

@allroundexperts I'm taking over this PR from @Piotrfj as he's ooo.

allroundexperts · 2023-12-11T07:08:40Z

Sounds good @koko57!

Please take care of comments and we should be good here.

koko57 · 2023-12-13T14:53:25Z

@allroundexperts I've merged with main and answered on your comments 🙂

allroundexperts · 2023-12-14T02:25:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-14.at.8.30.25.AM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-14.at.8.29.42.AM.mov

iOS: Native

Screen.Recording.2023-12-14.at.7.52.11.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-14.at.7.51.13.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-14.at.7.43.37.AM.mov

MacOS: Desktop

Screen.Recording.2023-12-14.at.7.46.52.AM.mov

allroundexperts

Looks good!

marcaaron

Couple small comments. Thanks for the changes!

src/pages/SearchPage.js

koko57 · 2023-12-15T15:17:54Z

@marcaaron ready for re-review

marcaaron · 2023-12-19T20:48:45Z

@koko57 thanks for your patience! I am sorry there are conflicts again. Hopefully we can resolve the conversation above on the next exchange 🚀

koko57 · 2023-12-20T08:25:38Z

@marcaaron conflicts resolved, changes applied

OSBotify · 2023-12-20T18:36:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-21T05:30:14Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-22T05:18:57Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

youssef-lr · 2024-01-09T19:26:59Z

src/pages/SearchPage.js

+    };
+
+    const onChangeText = (value = '') => {
+        Report.searchInServer(searchValue);


This is causing the previously stored searchValue to be sent and not the newest value

Piotrfj added 4 commits August 23, 2023 14:45

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

7aae936

…1-SearchPage-refactoring

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

cc5deed

…1-SearchPage-refactoring

remove unnecessary search actions

86aa3a1

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

6e31b01

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

Piotrfj requested a review from a team as a code owner September 21, 2023 08:40

melvin-bot bot requested review from luacmartins and removed request for a team September 21, 2023 08:41

Piotrfj mentioned this pull request Sep 22, 2023

[HOLD for payment 2023-12-29] [$250] Migrate SearchPage.js to function component #16251

Closed

1 task

marcaaron requested a review from allroundexperts September 25, 2023 05:01

marcaaron removed the request for review from luacmartins September 25, 2023 05:01

marcaaron assigned Piotrfj Sep 25, 2023

Piotrfj added 3 commits October 26, 2023 15:28

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

1b81d14

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

fixes after conflicts

3a20b60

fix lint error

e212f25

Piotrfj added 2 commits October 30, 2023 18:00

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

0565cd3

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

fix lint error

0cd0edc

fix lint error

0b0359e

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

1b9d837

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

Merge branch 'main' of https://github.com/Expensify/App into fix/1625…

c6f6911

…1-SearchPage-refactoring # Conflicts: # src/pages/SearchPage.js

bring back accidentally deleted code

8ad959a

Merge branch 'main' into fix/16251-SearchPage-refactoring

8cc6813

allroundexperts approved these changes Dec 14, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron December 14, 2023 03:38

marcaaron requested changes Dec 14, 2023

View reviewed changes

src/pages/SearchPage.js Outdated Show resolved Hide resolved

src/pages/SearchPage.js Show resolved Hide resolved

koko57 added 3 commits December 15, 2023 15:37

Merge branch 'main' into fix/16251-SearchPage-refactoring

9fd4f3a

Merge branch 'main' into fix/16251-SearchPage-refactoring

8d329e8

fix: apply requested changes

443a9ca

fix: restore latest changes to SearchPage

ad4cea8

koko57 added 2 commits December 20, 2023 09:11

fix: resolve conflicts

0bbf68e

fix: revert changes applied after another commit

253ccdd

marcaaron approved these changes Dec 20, 2023

View reviewed changes

marcaaron merged commit 8669b24 into Expensify:main Dec 20, 2023

github-actions bot mentioned this pull request Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

koko57 mentioned this pull request Dec 21, 2023

[CP Staging] Fix/searchpage optimization #33399

Merged

61 tasks

youssef-lr reviewed Jan 9, 2024

View reviewed changes

allgandalf mentioned this pull request Jan 15, 2024

[$500] Search - No loading animation when pasting text for first time #34516

Closed

6 tasks

Conversation

Piotrfj commented Sep 21, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 21, 2023

Uh oh!

marcaaron commented Sep 25, 2023

Uh oh!

allroundexperts commented Oct 1, 2023

Uh oh!

koko57 commented Oct 17, 2023

Uh oh!

Piotrfj commented Oct 20, 2023

Uh oh!

Piotrfj commented Oct 25, 2023

Uh oh!

Piotrfj commented Oct 26, 2023

Uh oh!

Piotrfj commented Oct 30, 2023

Uh oh!

allroundexperts commented Oct 31, 2023

Uh oh!

Piotrfj commented Nov 2, 2023

Uh oh!

allroundexperts commented Nov 2, 2023

Uh oh!

Piotrfj commented Nov 6, 2023

Uh oh!

Piotrfj commented Dec 8, 2023

Uh oh!

allroundexperts commented Dec 10, 2023

Uh oh!

koko57 commented Dec 11, 2023

Uh oh!

allroundexperts commented Dec 11, 2023

Uh oh!

koko57 commented Dec 13, 2023

Uh oh!

allroundexperts commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

koko57 commented Dec 15, 2023

Uh oh!

marcaaron commented Dec 19, 2023

Uh oh!

koko57 commented Dec 20, 2023

Uh oh!

OSBotify commented Dec 20, 2023

Uh oh!

OSBotify commented Dec 21, 2023

Uh oh!

OSBotify commented Dec 22, 2023

Uh oh!

youssef-lr Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Piotrfj commented Sep 21, 2023 •

edited by github-actions bot

Loading

allroundexperts commented Dec 14, 2023 •

edited

Loading