Make sure withLocalize forwards its ref #2800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
reviewed
May 11, 2021
src/components/withLocalize.js
Outdated
| WithLocalize.displayName = `WithLocalize(${getComponentDisplayName(WrappedComponent)})`; | ||
| WithLocalize.propTypes = { | ||
| preferredLocale: PropTypes.string, | ||
| forwardedRef: PropTypes.func, |
Contributor
There was a problem hiding this comment.
This is not necessarily going to be a func.
e.g.
tgolen
previously approved these changes
May 11, 2021
marcaaron
previously approved these changes
May 11, 2021
5 tasks
jasperhuangg
approved these changes
May 12, 2021
Contributor
jasperhuangg
left a comment
jasperhuangg
left a comment
There was a problem hiding this comment.
Looks great, thanks!
36 tasks
Contributor
|
🚀 Deployed to staging in version: 1.0.42-1🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgolen please review
cc @HorusGoul @marcaaron @Julesssss
Details
Make withLocalize forward its ref. Remove a hack from #2320 that was getting around the fact that this wasn't happening.
Fixed Issues
Fixes #2786
Fixes #2785
Tests/QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android