Rory functional composition #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thIon to follow hoc naming convention
marcaaron
previously approved these changes
Aug 21, 2020
Contributor
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
Seems like a pretty reasonable change to me.
tgolen
requested changes
Aug 21, 2020
Contributor
tgolen
left a comment
tgolen
left a comment
There was a problem hiding this comment.
Cool, this is nice! Thanks
Contributor
Author
|
@tgolen @marcaaron Resolved merge conflicts so this one should be good-to-go |
tgolen
requested changes
Aug 26, 2020
tgolen
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgolen @AndrewGable @marcaaron Would you please review this?
Details
WithIon->withIon, to follow naming convention for HOCsFixes
$ #279